From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0B8A545D0F; Fri, 15 Nov 2024 10:08:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E9DB942F95; Fri, 15 Nov 2024 10:08:05 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by mails.dpdk.org (Postfix) with ESMTP id 946C840278; Fri, 15 Nov 2024 10:08:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1731661685; x=1763197685; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=FBsCrmu380C6jDHB1FU6B8mmI263Nx+sBBKZ2dDYAd0=; b=LyzAwkL9M2/f509XiQgv6jPuoPW2NYjIvT25maSYlf2dUlbGgi9LHAZ8 RsCsHdwRa7Ozu2+dGX1Bt5aQMdLV9x7xFVrfMU+KyJLF2fM98Nz824xJ7 MOddoxgqPTpW3TBhvyQsVAjQXy7igyfOZUrbGqPBraGDAgnyh1CpvMexo ob0ALY3wh4RnYbdsnrh2z4ksTeWcTQYai5jUMd5tPVZnwIlf5/vE5herW HjA3L95+l1Zb4rFyhYHlmTGvM0r1+mZzuXgHBAYaRMKd+wOe1TNJS2+1J YPUgzauBnqCTL1bHlO8fBr3Uhh1XrztPUehDb7jDbsGEWqKicC3RuvhnE A==; X-CSE-ConnectionGUID: 2ciMhEh2TEmi9mupFUtgZg== X-CSE-MsgGUID: JcdAsQrZRm6yrgEsrDgvXw== X-IronPort-AV: E=McAfee;i="6700,10204,11256"; a="31612213" X-IronPort-AV: E=Sophos;i="6.12,156,1728975600"; d="scan'208";a="31612213" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2024 01:08:01 -0800 X-CSE-ConnectionGUID: DIbWVPnTQFuyKfJx7m+mJw== X-CSE-MsgGUID: ZHct99GWQfiUgNTTXEdX3w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,156,1728975600"; d="scan'208";a="88497517" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa009.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 15 Nov 2024 01:07:56 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 15 Nov 2024 01:07:53 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 15 Nov 2024 01:07:53 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.173) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 15 Nov 2024 01:07:52 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=O1kPv7d/vFQpXuzlsfY/ohp9oPDsa8y94l6WHFbhTOTHHsW9AEWsmgVZBqlKuGncjZzUNb0aVX/SJMMzhAVtPTv2I4zQrOGbKz1N5oYInX2AXSezkSMEwXc6Kk5vTs1Q7zJmaugLBqc3XdVh3OoGqQzzsO2NP9mTQ7JY99Flwjzg7lL2VAAf7wmODwvNjM4OPVnT+MONaBh0DQRRX8RkhPWXZ7GWwVQvhsFC5AC9aL4z7Cn51MCgObB+zTJ8z2bGgRsk+JTTvSfjLPtxezxPZ/leV76D8CvBYZ+X3AkxRgzg/IjmP+veIDy2MAVhl4xtLhb+7JhjR+e8LeusJ6Y3Ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A7UgoktitydJxYkYIHUKcCcMEyLcHS7HPDYtqe25ZlA=; b=oBayvlvz8DWc83mIFU1JAsCl3jwjDGRZyDXv5KwwqKS9kk/bTN7inSJ2mczQl5zHc42l6e9PeV2DTHtfTIiUOsXrcsLZwQT8WD7srbroWX1+WgbN/6xzGGYUlGzrMdx+uqLTElwBcGu9/qMqwvGjhp6GHuLq/xEns1nQzQGsAI7OYk1BglcLs2r7Deu7l6ETRadtiQjg+KkPxnIhqmeQnlifq7Wb5uQsmJBoLtFyOq2Xmqm6j+jIcpAh5qzgPKDOlPQKnUKygzFSpGCy1IwjsoZv47SQfogcUABmsYqHsXYsRFIwql/EaNQ15OvUK3HBfhBegf2JbXv87d+0sBepyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH7PR11MB8479.namprd11.prod.outlook.com (2603:10b6:510:30c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.19; Fri, 15 Nov 2024 09:07:48 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8093.018; Fri, 15 Nov 2024 09:07:48 +0000 Date: Fri, 15 Nov 2024 09:07:42 +0000 From: Bruce Richardson To: Stephen Hemminger CC: , , , Tyler Retzlaff , Michael Santana , David Marchand , Aaron Conole Subject: Re: [PATCH v2 07/10] test/eal: fix core check in c flag test Message-ID: References: <20241114001403.147609-1-stephen@networkplumber.org> <20241114192603.41145-1-stephen@networkplumber.org> <20241114192603.41145-8-stephen@networkplumber.org> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20241114192603.41145-8-stephen@networkplumber.org> X-ClientProxiedBy: BE1P281CA0016.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:15::15) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH7PR11MB8479:EE_ X-MS-Office365-Filtering-Correlation-Id: 3082dde7-bfa8-474e-59ee-08dd0554f97c X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?kTyOq/mbxI4ew0JAXFwin1V7x61QDYnA8ckGGMglqH+ZIA3k0z7bg4xzI6NW?= =?us-ascii?Q?+GAd4JzVhT1wAApJ7p7vUuxFedNtHvMkGxAJu8XSq8gfcyiWhJqMBxn5HVoT?= =?us-ascii?Q?53aptdgJBIHsOdnS9dDa6B78FVU2W2Ath9DlpZK+VQBarw5AeaqU0s9gYG+Q?= =?us-ascii?Q?k6/NX0YkbtgfjW/VXEERSPdLg0dZVVDF8rkh7L+BFrt7qimyVvIVnv4IpbV7?= =?us-ascii?Q?jvB0vInqjfT7u5jehhM4mtdM6oco2CsgNfwzPTR/1e5wXbZ4/D0X0UUK5zhp?= =?us-ascii?Q?63LMJ7z6SZEn07dFjFthlJJEy8tYcFxqCu6L9Dgv32VwmLDpiJhMi7TL+shw?= =?us-ascii?Q?MW/gLBJSXtLZrfzaafgpgCdMvgAdA1BL6ONmtSuHCqOIdI/S93/LCJFQSFsv?= =?us-ascii?Q?X8tyhN2FGA6mehDLqExWNFhUHxlYOTukQdgqfYp04jq9M8FU9xNx3f92luCq?= =?us-ascii?Q?an6zUVCufIDBFqMbNkl3Yuk2rtx8xFrka6gYS7cO7f/jtTVwbbqbUg2vwOaR?= =?us-ascii?Q?RhduLLaGOi4yhOc1hjdQQrLFX3WohrpewECMvyjNXRCH0A/yRzuexPQspmWx?= =?us-ascii?Q?wx+eOQOTTIo2362ag4tzEPUJkIlav98ZcjE93051FvtjfVexIq7L5HQ6kEdP?= =?us-ascii?Q?blPLJMXyjkALosVfsUwxTkCAl+pw5S67yRp8b5EKteRwgsOi+dilXRlR+1rG?= =?us-ascii?Q?jlEke+Kr9alia0Wnc3OPlUBF6C6fWswDzh+/gLKEMgEUhUKbCZSKOIjJUQvA?= =?us-ascii?Q?eJcVA54tBfMim0KacrnlsN1svIM8LQVzdMKBIEy0w0dptCYDXd+v5yRWRg7D?= =?us-ascii?Q?prb7dlUbE5/UBjOlE1HoSclkO5unDn9FBXscJkwDsznR9Fz1PnWlQOop3vsG?= =?us-ascii?Q?UFSfAm/jlNMBCy8UcjWrYvx4taUTuY+5xjNM06gpySZ8QD49nV3yLDuVtUlW?= =?us-ascii?Q?yu7UEJXAYlixZEm6JSA+/n7o9fz6sGslCZ6DH19/tt7B6P2rFvdKYS4w9bWZ?= =?us-ascii?Q?2Rtc1ckukX0ceQ9z1aprW9HAMtKZsy+6cABdzT3/nKUcmUiQEvrQOJXtJdMf?= =?us-ascii?Q?d/6Nk/LnaIa27Zx2kGn1ma8smtMSr+tM5gRMM53Ral/mQQHmRu/lYk0T3hcX?= =?us-ascii?Q?2+1O29h8LZLP+d+GTAX9cd6UmZlUT0BUjos74a00PPH07HZpWXIy2OBXGQ8/?= =?us-ascii?Q?YXSn5CFJxQDiPi6RWfW0zUa7uRS0IDh7BJClxAu8ZDKpAFBiQGulQDBARb2b?= =?us-ascii?Q?MGyRoNWvKgVSViEz2v+P?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PleXWt398K2coRRJXyqi2wNMcefQ3txlTtvsRRdQFEXV3Adaj9ZN2+rzQFmc?= =?us-ascii?Q?YjHGzcJ1tFrQIyoPmza1m0zVRS2Wt3tqEFDu/vGVZ1oFoUrajFRNu2ugZCPu?= =?us-ascii?Q?oegVWTQGQtz05oIhJsrV9Ygfs5OO3F2816CLVjNSSgzZK4RZWPCAzSzlBkot?= =?us-ascii?Q?UKAhrosFJT+IUdPsYH572IFmYkppfTqd6dxV8URP8PJGxPS0V2O35SkxQcPU?= =?us-ascii?Q?7aOym5CPYJxPcVEm2e6/0q0ta64i66Ofg8zlDKtmKngVRfcNQXn7/2qCgaIY?= =?us-ascii?Q?CEz4DogbIUAWGp73NNdKGw6Xenek5xmgo8ynBTGLL+42vFhMTOsV6UEYcaxh?= =?us-ascii?Q?f44Yto3Lror/+jsju1kcPZniJZ/4aewJ/Ul+xMb2PPzSYkNxRILlF3/TqYCp?= =?us-ascii?Q?cDzBaUykuT1B1EWVVvBrY98USiqQv1y0+NGnDH6z5xDkYHm3jYYDJRfDfqCd?= =?us-ascii?Q?aDW1MndMQsyLH7ZmG9KWCl05NSpbTpRLZqjGSaaOEec6AkM7WWRkXSIsuv0o?= =?us-ascii?Q?6Am9k7K2DwLSj5Hmiq7iY0jtN70kl7iaowkWIl8Ymh4ns3mKQU3ZgFVwa6hN?= =?us-ascii?Q?rqyH5VZRX8Ut60rS/PvQMGyHHNezarFVubPiVGx4rwzGUIhgEOENzAwlpiqr?= =?us-ascii?Q?2nY+v2oeA0GHzV4ZCRdO8QKszqStvlqxd6u7G8idR6pSIrrTlF4TrkZmktWR?= =?us-ascii?Q?KxnHLTAE+BO5tNDog4EcOhXNqVZRoUa2eQYp9PrygCEPx3GcCKNI158vuFDu?= =?us-ascii?Q?ERxos3fTipdSTSvHNiznktismnTU3BBRQktoOa6/TfHAJWEwSGbuGg8R9t3y?= =?us-ascii?Q?D2Xtz4KvUZfPoVNT1j8F/UsstwePhmpZFV7yeU1eYMDs2IOowTyLsUq8yqJk?= =?us-ascii?Q?1lF3QzdZVZxiiUPNBPk+KADkzy8XbxVn7jmhNscQ4n6XfuW6CZKt6qM8UsqB?= =?us-ascii?Q?qi028LwHX+4dFpy13JwFgaNMk/31m8KVhu91uGeHzRfgAr43W5++aMuXFBJQ?= =?us-ascii?Q?YRpobuJC8izfquBDcsA+pGqJeOKzsbvkNBltF5na0EpQ6PL/aiq/k3Z9qIdZ?= =?us-ascii?Q?4havNItx2MIolxZaio9R2P3FQjDWiI1fRf+UlF+ISD7B95ymzDG7DrpBeLYR?= =?us-ascii?Q?fVwi2oZNtLKBMthz0yr8H5gfR0Ako0W8gp/W1qezbeY4+jitPhYvn0BAU54y?= =?us-ascii?Q?rJFAV1RAHtpN+suENhglbwxNpQM5urUCumGcTi3JqSJQkHqz7/OYP4HZ+6YJ?= =?us-ascii?Q?bYfbQsZzzjECMhssXg/mHKT7g+vpQUMWVncq/T8SWaz4j6lBUAojIrxPXGGd?= =?us-ascii?Q?6CIIPCTKwKKaz1IzTbIp5NW1t37r7+4hjL7ywEvLfC2YK4kRXMGOUUkZ5haU?= =?us-ascii?Q?PDAgMj1Q7kPNYtvLZ5IfmGdWtyQMaqZTJWse8o87zAjAT1tI81j80eqWpMTi?= =?us-ascii?Q?x+/9x9p3ckTm/+jlVEurHxirwro0Bv8i16VU5uhVb0xShGdn8j14OtFJUO69?= =?us-ascii?Q?M4xiTmoIz23ZKCNgq6lTDuDPaLVUzXiwDvcuZLgwAs8jAEA5HiX9ZUr3nNVs?= =?us-ascii?Q?43Ixe63bOXHzsMvS8FtJlV8HV+YD10l6b5Hb3z9UvzuAQXyHpmB+EzO7GA9h?= =?us-ascii?Q?0A=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3082dde7-bfa8-474e-59ee-08dd0554f97c X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2024 09:07:48.0107 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: p9qrZ2fidCd/tqS8RYeNrkYzKfmbRr2IB6r28532KJmO44iRGc0+lYSOVhrrHdDJJ5iNmJgqIQriTJJq1ll0Tn6PEbOE1wClBLIrtifA3/s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8479 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Nov 14, 2024 at 11:25:05AM -0800, Stephen Hemminger wrote: > The expression for checking which lcore is enabled for 0-7 > was wrong (missing case for 6). > > Link: https://pvs-studio.com/en/blog/posts/cpp/1179/ > > Fixes: b0209034f2bb ("test/eal: check number of cores before running subtests") > Cc: msantana@redhat.com > Cc: stable@dpdk.org > > Signed-off-by: Stephen Hemminger Just wondering would it not be better/safer to put in an actual loop check here? However, I'm also ok with keeping the fix as-is, so: Acked-by: Bruce Richardson > --- > app/test/test_eal_flags.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c > index d37d6b8627..e32f83d3c8 100644 > --- a/app/test/test_eal_flags.c > +++ b/app/test/test_eal_flags.c > @@ -677,8 +677,8 @@ test_missing_c_flag(void) > > if (rte_lcore_is_enabled(0) && rte_lcore_is_enabled(1) && > rte_lcore_is_enabled(2) && rte_lcore_is_enabled(3) && > - rte_lcore_is_enabled(3) && rte_lcore_is_enabled(5) && > - rte_lcore_is_enabled(4) && rte_lcore_is_enabled(7) && > + rte_lcore_is_enabled(4) && rte_lcore_is_enabled(5) && > + rte_lcore_is_enabled(6) && rte_lcore_is_enabled(7) && > launch_proc(argv29) != 0) { > printf("Error - " > "process did not run ok with valid corelist value\n"); > -- > 2.45.2 >