From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6A83845D0F; Fri, 15 Nov 2024 10:08:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 55F54402B5; Fri, 15 Nov 2024 10:08:58 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by mails.dpdk.org (Postfix) with ESMTP id 2B05640278 for ; Fri, 15 Nov 2024 10:08:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1731661737; x=1763197737; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=tVzhGJuC8Wgq4j2mqgCeum7XhA2qafP4/DjxGk3LQqg=; b=H8R7fES0U2gtxwJG+wMw4pF7HGqOwXYxzZCBMKEKEJ/vqZ7NvyXATmLe 0Fy7bP8W0uzU2bM9klUpjvDyy5A6Hml7/njJT13SKkKURYys2+r8F2G4l HfIvYtH6Sx5aoKUtwNkdfzPFNI7L9AAGMPXaiz+85iicts1PHNTqd+oH/ lpRE8iDoEzs0BSxGrqmNCwhef5GHmYjmq9EJ5RO2PE8AyMghHAgf6XipG j2l2yZEhAp89d7xzegJ7FscQugyaMBEHbXj49Ckb44DOKA+/WDUGSnnaX WEe5t99n9LQ4mS0WyXyTrc2+YLW2ZpcuRPBHGybMvmMityTcpb1yz5RLB g==; X-CSE-ConnectionGUID: rHY7fkcPSdy43clqGEr0ug== X-CSE-MsgGUID: vG0NjpM8TjSjQ0d05C5+bQ== X-IronPort-AV: E=McAfee;i="6700,10204,11256"; a="31814796" X-IronPort-AV: E=Sophos;i="6.12,156,1728975600"; d="scan'208";a="31814796" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2024 01:08:56 -0800 X-CSE-ConnectionGUID: b3H2hI93QDqwI+rkZQEYsA== X-CSE-MsgGUID: mIFmS5X4TNqpRT9+b8nn1A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,156,1728975600"; d="scan'208";a="92568396" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmviesa003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 15 Nov 2024 01:08:55 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 15 Nov 2024 01:08:54 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 15 Nov 2024 01:08:54 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.172) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 15 Nov 2024 01:08:54 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FDZ7jAauqplwy/eB9rOIzRX/Uc3bnSbvePSjaa1UbtKzCvoS0jD0S2jbdXW5Fr/pWb4iHhgjQCKVMG9h8cxYbMCMSrJ3DY+3KyhDfAqF8PHiBR1py2juj97lKICkYjpcvifCGFZQPjQWrZS97JLas80dF9CvEbnmgAONXu+8cUdNw0bmD+Gz+bYNnQHGHeqYYlA9NqFLI/prTzddpq6WnTPIt/qOcifmBzkGcR5o2QyciB0AtxsDx9ORwtDxbf7TXHc/LBeN5g0IYUidc1Xyjy2t+rrDG6fPFHU/Ff/R3aRR5KQ6DIzOVAI8zCWaIUtAaabzrrA7OoideNof08ymuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2S9/CBgs8386VFoNrbcZbj97ORKDao/B5RUrGdmHTRI=; b=On80Z2k06U65tpTPfYMxGfQqr33gO02iIQhdP1M3VhTaB05pk0fufkyr0oC0GkxqGezSAXZKiRB5a6eHzCPsInVho2Hw4Do/5qRch/LkzhM07lA9yPBWzZZh5UBuHaiyvtf93rnB0s+OqHVb+7QtfA+iChsZXMp5Wxvt265uGjRoyazw2zItQs9gUhT/fGzmonoy8YaMK48OfFslxybqJ2yJLft0veF0QLy94dTxvrKwdd5m48IuAbwX+ghUz9ZOlEuO1oYmw0y2NXxN8SOnXVrd4mrcojFihgZZQ2evAnKzWrfBuTDe8hZorW5IEDqxf6BKT5X560csubD/MJZf8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA2PR11MB5180.namprd11.prod.outlook.com (2603:10b6:806:fb::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.19; Fri, 15 Nov 2024 09:08:52 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8093.018; Fri, 15 Nov 2024 09:08:52 +0000 Date: Fri, 15 Nov 2024 09:08:46 +0000 From: Bruce Richardson To: Stephen Hemminger CC: , , Aman Singh , Ajit Khaparde , Matan Azrad Subject: Re: [PATCH v2 08/10] app/test-pmd: remove redundant condition Message-ID: References: <20241114001403.147609-1-stephen@networkplumber.org> <20241114192603.41145-1-stephen@networkplumber.org> <20241114192603.41145-9-stephen@networkplumber.org> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20241114192603.41145-9-stephen@networkplumber.org> X-ClientProxiedBy: ZR0P278CA0159.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:41::8) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA2PR11MB5180:EE_ X-MS-Office365-Filtering-Correlation-Id: 5e2d394a-6401-455d-3dc7-08dd05552004 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?06LHk0C1y75WwWt9WlVwvx7kCqOwxPTLVh6ydVnxojnSJaDpqJu4jKrb6/3B?= =?us-ascii?Q?ExcDWW3XuLYcpfijPIMMqDQ7cLy/JwvCfsKXuKIYzgCf8m4lhXag+myzs/AY?= =?us-ascii?Q?O9yxoDJ/LXVwD/7cXg3G8/HGa7ihvv606os8gVk0JgzYTAWrNdMfj0IhVuHW?= =?us-ascii?Q?gCjihDFU7TRhsTMjEBDonnI4zbXeaA8+1Y0rMUknu1mPN/yKhy/WQUPD9HKb?= =?us-ascii?Q?n1AdjnvQI9S87hGyy+eOKhA1o7MdwZ18Ku5g4YWe4/nYgZ09u5apM1HZlSU9?= =?us-ascii?Q?AACqNBawyYf/OP/CJ9lhbGybNbc9W+Ul5IJWx0Fm74n2d5M4x3FRH/62vV8Q?= =?us-ascii?Q?TqOuCMPZcd8grZO+8kXzhFd5NfWj5XgzfOFecTXYq582fnqaLF+l0zPhgioY?= =?us-ascii?Q?uEW9L6P7YZPbY9qbO24GOhr8DL0WA+vL26C12jjw7WsKX1DGvrZviZ62qHOr?= =?us-ascii?Q?MdAKrjXjQbC9lyrm7r2fIN4cke1IjQuizLHe8JXz62WlDBON9UPwpPM9/vdC?= =?us-ascii?Q?zuHctDOxTCeJhqxPUto2bFvIX4zZiF8b2J6ZZv/I/GAq/HTN2y6GOML2oGAr?= =?us-ascii?Q?wHikFTRdjbfu9q4mXsjdmWlt4mwamnq++LKkLNKSL4qwdZWij0i/wp6aM/lx?= =?us-ascii?Q?t1omXq4KflqNzco8ALDg0ezA2LEnCsA6pxe/yJ+i4lml8SkMjyJ0+hx6GBfF?= =?us-ascii?Q?toKpfls+4H+HoSeCQEgZvUyenCAxV1mtFBtX9c964969uP6rBRiOY2kRwuNl?= =?us-ascii?Q?k2jkWotV1IIptlyTAYvPUBRiy89a8pwveDMhyj7OYY06SFKtOlgqCJNcm+si?= =?us-ascii?Q?BSlqC+/kndasRuo5Ln8Jj2AuJZcPPXGawxQHrvH2ayaDVa3Jci0VMv8o8sgz?= =?us-ascii?Q?Mg9jVWTE0HYQIxn8ozu+aXieNvU/7WhKvM6NkDh2yBW5T8867mWo8v4AHsLW?= =?us-ascii?Q?10w6xN+BEHzI4jlIkVH91B/fuhS7B87fcpjB7u/J5ioY3RweqyO4HVcRZaGB?= =?us-ascii?Q?cVKKqUpoJ166PoC493KZKizMAHlfaGYBdw+XmRBHoHVtDtiuRtGkKnkwqALT?= =?us-ascii?Q?5ymhymBe0ppl4PxaD2hmDuUkKIQ3r3uefBND9qBoyj+hj3hiJU7/VsdIzSfa?= =?us-ascii?Q?nCYFPgEDugSMKNZGTshG3/sj7rn6TWNAON5RMKG6j2c0VHZl6kw//nKIAanZ?= =?us-ascii?Q?8Wko3cthFS7vk0i304sqxJV1BFoSwNb5Pi5rB8e4D3C1RAAuJZr4ar4JVNmD?= =?us-ascii?Q?02yulOZpgOvGbMEnWgRE?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?I3xgSdF/0f6A5k9kg9UTN4EAJmUeoe7CXrcuM0SyW1Dmt9V2G8j0WMf3KI9X?= =?us-ascii?Q?/OWaMFnb86K7qIX1WrHFp8oKgwB+Lf3teKpCwWZrlwLxZvls0YNeTWPayUor?= =?us-ascii?Q?SeyP6NWo35DhYq27TYUcWXFIB8nHMTeF21D1gHL7YXeXrkAEeP2mPl0teFmR?= =?us-ascii?Q?wZugrzsZzrniCY69SZNYSprnCsE7Gg0fJAVC9qvB4zNaiLecsd9YN1R4dVzw?= =?us-ascii?Q?p+SstPO6T9q4C5oHDMs1cNnr4b5XlK69Oddg63zwjQeBVgv9X/l3WFMGdbU9?= =?us-ascii?Q?gqXwPxwPucvlID3rH0xJgEdr2GbfmcBDw6+EDFrRo2DdxQNnl10wR0IPx1XL?= =?us-ascii?Q?vT4YrRveHLkQncUjG9PwnnpAtgIUpjslWPRYuGdnhlIBLoURmRKy7GnOIRCX?= =?us-ascii?Q?LHCzuAVeJq2p/T/olpV137M1Iic9I9NoHlqTGPNAYgx2/AvOyQPhBsbgiBLy?= =?us-ascii?Q?R8Wcn2W4CvAtJKwxLQeqRVM0pPG6UxyXMhz6bSdTUkiHHP4UH1LGh28pp+MQ?= =?us-ascii?Q?HFVMyGhnOmyDghX61aeYWEsBhj7wG2OEcZZhjmjSFtB+A9oFmRl/XFuNTA2m?= =?us-ascii?Q?xOKMaF4Z+SzDznGRKhhesDAVhQy8x7UDHL6ZwCeNzkGpKEoe8152agwJnpkT?= =?us-ascii?Q?3pfgtXKCXkjP9zFOYg/X/HjChtn7urs3K12KR6hhK1s1TbgFcfUmiyojulz2?= =?us-ascii?Q?ON3gYM0HB2pHUoWdGp5mbmh6fJ1O9Flha5w3TcKVJ9gAIvXoV3zkgPm/5m2y?= =?us-ascii?Q?/a3qYGHoQW/FYgWr8r30PdCPzIwNXKvl5ApIMl9u8NBlcf8XIXdu7/fW6c3S?= =?us-ascii?Q?KHfLLG000Osp4fAscQyfV9S5hDRVkNtqt5i4pERhG4RfrfTMXjhZfI2kiL/T?= =?us-ascii?Q?WTk8WnctUjEBh0Ox0w6nh4FQJqOvx3l/5zmuH87uuiWu5K5h7MLJp34SJON2?= =?us-ascii?Q?4EcHGdD9VAVHea3fDMSU4hkxTHkuBbYouJxHAC+7WPl2u37MgetHq8escV9X?= =?us-ascii?Q?j+gBkQ8IA+O/ELRDEAJKgr2YNCNSCyMMadfaGMGfk+CqWmi47YKu9unX3Nrm?= =?us-ascii?Q?aWiUZuGhj5nvRi2p9TdrhmotmBPeuvraOijeNDGxdUi4u0ynBf25cTr27ujK?= =?us-ascii?Q?+l7t3KnuDdk1yzYI2q8Hq9DI8EqWrNKDD9HokUJVd9WNjbAT86UuPEpTDU+x?= =?us-ascii?Q?a2KFVgf1EfRX0xEhg1bRRII1SpYq6835TL6aQ7VMreRXhHd6S71JnP0j4tYP?= =?us-ascii?Q?s+DWmmtRATMf/RrpTdjne8DWQw0FN5x6qoQWqokx+wwy+nBELnomS5gqk5sK?= =?us-ascii?Q?6DfegK41YdNYr2ygfKwHKTfapCfjcdzXIV9fnck7KdglH/hG3uN6kp53CLOt?= =?us-ascii?Q?UuWidJX52u3ArpPMyDdtYpqSM3nKprLS+qhTOf9X9LKJ0pKlHMLKqZVaLbBS?= =?us-ascii?Q?kG31ukqhaz4waaaFenJZfwUi/giCxAIuX6ocV2CFmaawN0/kQJb5UV2ts/Vt?= =?us-ascii?Q?h/jb3p6qVPlwuTD5gDlhjKRJYibDhp+eFYSiH63DOv0iy4XKSIsG22sz4fdw?= =?us-ascii?Q?4FbPB1lJ865Vnfwb7LSVWlbKlF/EpEKGDAx5T6sUUhMM+06j+wR+rFe+poXr?= =?us-ascii?Q?Kw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5e2d394a-6401-455d-3dc7-08dd05552004 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2024 09:08:52.4809 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OxDdniH725apto6Au3edFlpTaMJfcCgABowNmz9DWlx0jPSsDK7a2P4xq/58U7z4nyIdb5uuF1G0qZ8247UQvJNzCTvOCwkX5MhkbxguPWg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5180 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Nov 14, 2024 at 11:25:06AM -0800, Stephen Hemminger wrote: > The loop over policy actions will always exit when it sees > the flow end action, so the next check is redundant. > > Link: https://pvs-studio.com/en/blog/posts/cpp/1179/ > > Fixes: f29fa2c59b85 ("app/testpmd: support policy actions per color") > Cc: haifeil@nvidia.com > Signed-off-by: Stephen Hemminger > --- Acked-by: Bruce Richardson