From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8128845D13; Fri, 15 Nov 2024 15:07:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0B7B542FE5; Fri, 15 Nov 2024 15:07:35 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by mails.dpdk.org (Postfix) with ESMTP id 418B3402A9 for <dev@dpdk.org>; Fri, 15 Nov 2024 15:07:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1731679654; x=1763215654; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=Yra0xT0GjOxy76+YIjL2JtFZBG/CX/6bPvS0eT/tPxw=; b=ePk7UBzONGegcODwNwwTeR44oyGsSMp0eIoVXq20QiFzZrYNAM0NP9on qU3UVwqTlJYEGXFp88dMiu2cYFYCa2Yy7ILBWw1P2+1CrgP+L91/HKcR1 i3x/Ssz59wHOP/cTfUss/gFMDTJzhUEidK76Y2Mk+zSu8UH2Hj0ykma/a AeLvLN4fDuIErvA3cd7tFJKSCiRH3yIqeA9Q/8GrH7T6YDFzmDjqAfOAM 1YB4ttxU4e3ivbBjAmAtGDWcSL6HgAQ8EZncFMMSxsNBF9JfVI2sQAhp2 5/Gb7jCLotbLWdRk5KJ7SB+tyfgejWjy5G7n3vRf0IQawQbhSktLAmfFD Q==; X-CSE-ConnectionGUID: wrVfZ8pYReW+jDWh3DZMig== X-CSE-MsgGUID: QE8nVRORS3+b72xGWJBM3w== X-IronPort-AV: E=McAfee;i="6700,10204,11257"; a="31790276" X-IronPort-AV: E=Sophos;i="6.12,157,1728975600"; d="scan'208";a="31790276" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2024 06:07:32 -0800 X-CSE-ConnectionGUID: 0/laEpxHQTC+3vwaNgsm8g== X-CSE-MsgGUID: TKkFETvpSnSYSVdLFn3K/Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,157,1728975600"; d="scan'208";a="93396242" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 15 Nov 2024 06:07:32 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 15 Nov 2024 06:07:31 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 15 Nov 2024 06:07:31 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.176) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 15 Nov 2024 06:07:31 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pz+T2Et51lox4kzNjLnH9x+CBBAfE+7i5Sm+szBddZTj8PQvwZKOVFK7ZfHXZ6R/mfI1Q2ZqXG6DMgGjIOfHBZZpikA2jrvnBKlre5SQljfOiS2bKNjEh/3Dkv/E8A5nk0mmGwc2TeNS2sNr+PBhKJLGkNGmco/TFT2MvMHQinvijyQed1VjIvaTJUp21ufp8SO5bFQ16hyfChUV2T6y+w4vOJg6+Dlqay/Fje1KJ4oi1BdEEA/P8H11YOSR5Wlh+VQ9okQ74DQIZrbu+2Ok+vPZZoEjykwvZxsferg4UVdq9dltl7HOU6mFJu0VbUQtUhwf8m6OyYZ3pErm9goHbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uFX5eXRu1S6BVJpDSRM8neRaSGDu1iT7QQfoRdGIhYw=; b=hhozrGPdfx0LN5CITH3IkjZbYRuL30azs+qOoHSPKQANPOHcMJnyig2Tgiu3gM3XhGcqz5FPi6ajvwD9T2UwBDSx0z8BFAEESO8XRWLpMKeDWxt+2LmXEgBXPa855jevXo9/nAL6VV2J6F858kq/M1L6It8H0JB4RuvaEjgCqAhp+TomlR0IAjjGSvX6PduA7utKiLrUfiTsT5QF+x4+ctkPjEsNPCJQbgZuVsRGxJepAdLqC6UlxcUe6MnKhyjyUs6raYnhJNrvIuGWvAwg537nGpvUgWfo7rlvGbo6RVWLrjI+fKbWJlowR5aaJWcGP4cS0tZjx1Fw8dL+RqJJVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MN0PR11MB5963.namprd11.prod.outlook.com (2603:10b6:208:372::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.18; Fri, 15 Nov 2024 14:07:28 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8093.018; Fri, 15 Nov 2024 14:07:28 +0000 Date: Fri, 15 Nov 2024 14:07:18 +0000 From: Bruce Richardson <bruce.richardson@intel.com> To: Morten =?iso-8859-1?Q?Br=F8rup?= <mb@smartsharesystems.com> CC: Robin Jarry <rjarry@redhat.com>, "Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>, <dev@dpdk.org> Subject: Re: rte_fib network order bug Message-ID: <ZzdVlqGHJgJW0WBV@bricha3-mobl1.ger.corp.intel.com> References: <D5K3GCR2XSBG.287JQOMCHLET6@redhat.com> <da689769-f9e3-43c1-95ce-cd8e0478c4a4@intel.com> <D5L33CJLU6T3.29EVLGR8HT22W@redhat.com> <SJ0PR11MB5772666B44B818FE71F7F147965A2@SJ0PR11MB5772.namprd11.prod.outlook.com> <98CBD80474FA8B44BF855DF32C47DC35E9F8CB@smartserver.smartshare.dk> <D5LTPJ4FK5O0.1C6RBQKKUU055@redhat.com> <98CBD80474FA8B44BF855DF32C47DC35E9F8CC@smartserver.smartshare.dk> <D5MRT5QLHY40.38W3GI5FJ5SCX@redhat.com> <98CBD80474FA8B44BF855DF32C47DC35E9F8CD@smartserver.smartshare.dk> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F8CD@smartserver.smartshare.dk> X-ClientProxiedBy: BE1P281CA0295.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:8a::18) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MN0PR11MB5963:EE_ X-MS-Office365-Filtering-Correlation-Id: 02395181-bd63-43ac-56d3-08dd057ed6d9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?iso-8859-1?Q?LBvGxD2sDQEG3iLtbnRCiTV2iDCAVphG/d79lek7Newcohy+np8Rm3Yw7D?= =?iso-8859-1?Q?4Gn5qjQ6OUyy+GJoJAOObDsG0kkp7CIS7P0sAe/6r2lq8he3rPN0mkItNs?= =?iso-8859-1?Q?5/ZeiOZ9ZkMVlsxl2mq2RALHoyJeTDPwWI95JplLFISoyDPvraN5MuYWpQ?= =?iso-8859-1?Q?MIo7Vmg5PhbU61srwhrHBut3+FryGvJrfMHukIezVAYhzm7yvvvbOKuSh/?= =?iso-8859-1?Q?0Yx2Il40S7QHAaTnz3vAhMqdPQfPIj2diOmsX+9ZIfvb58PCY7AyTTURaC?= =?iso-8859-1?Q?uikHEVUwTRB/b27EF2QAT69POFQOzsiULPLs4mQRrmId2lzouq0yQQoVrq?= =?iso-8859-1?Q?RDwWW/KehD3qoutusTUt/Rz+4l2LaN8ZyAl7si5f/ZBP+rmzuTnXMYvmyy?= =?iso-8859-1?Q?/ouBSP0KliVg6iXUVzfzGIaKjSPvDIt6LCqoehaA1HHmWWVA/VE3el1pSH?= =?iso-8859-1?Q?FFcG3MU+HPJWrxS6VyPJqSucILFT8fNQjU3BkrZvQNW4vHjS4awgM0gA9c?= =?iso-8859-1?Q?wcebNXDjNSA3DkoM8Zx95ISYELpkO3Gmiwql3NHy/S8X4c3UazMU4gqvJ2?= =?iso-8859-1?Q?MUxm/+koj+Pcj7cKJqIaiKGwPkY5aITGDScrZiw6RxXJqjPGMMI3dF0Xam?= =?iso-8859-1?Q?ftgrEdKv/n3P0sUPuN+YZ/gtDudAjNocLDWeJCVL/dkV624u2cb+94sp1j?= =?iso-8859-1?Q?WlGoxNej8KAYW343B0P+hsxAXr2iRHzz4AYlwHcRikx0lhiGmFgUtdC/GV?= =?iso-8859-1?Q?mUhwuwCN7rWszgF3BnbQ5yKf36k+aHf8gBc7/NvB+U9uUu5f5rTkV1Yo/i?= =?iso-8859-1?Q?QgVwV/T4BiaVewEVNX43GR1WpVfdmG8DE0hJ7q5M9a4JW32aC90K2b36hU?= =?iso-8859-1?Q?06EukbLFzEruCCYRHny/JHaqgaIU9Lv/B7t05QekLOpOX+OVpv15aNpDgu?= =?iso-8859-1?Q?ZcB0zoZHIsi8/7utUKmTxmdKa++whj/PWMtfsVfQVzRhpT8okzY73X5yFE?= =?iso-8859-1?Q?EeMJjk3eInrZdIZpsCIWht7DVeBCHpu47t0btZ4DdZTDA4AtorItgWM9zZ?= =?iso-8859-1?Q?VPdC8T0UdU3DVox+ysxfM6jnv+5kM0REb+pwAGVxFdAV3QMnV4DlvlMlZb?= =?iso-8859-1?Q?oO9cg+wqB+P2LW5uNzVLUNQQKDJOT85lhEbFOg5wHo6yzGLjfxTUAGy6qK?= =?iso-8859-1?Q?Qtbjpx/XB8FI9LMMBGfTyj2jjTr09S7UgaS2Fh50VNHg8o+tpDxe7Wa0B2?= =?iso-8859-1?Q?TMwWVnSmuWoFS4BU2ogPwSk3MTCRuX4ri7nMxZFMh04XxYzt+uMO1JP3vV?= =?iso-8859-1?Q?NlKRyJBk3LI1XWSdi+Y/clFleFtc0CS/ampFZ4JFij4kXZ7y2BNaSPQ4wU?= =?iso-8859-1?Q?5aYnbCSUr5?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?08IwJACI1o+Gm45f2Fc0W6jaap5z3IsIhkzOQL7u8Qicsmad+rAfsc/4uh?= =?iso-8859-1?Q?eYAp337YouYIxwzcZR6i3ot6+XYqx1yUcCpzub4ui6ntV3ojTiAJJLLHMM?= =?iso-8859-1?Q?PI+IfFZmZUDYHsYBRvXvbEWA1XcoBdpva33q1ddn4AsmgNnVXROhCR16Xn?= =?iso-8859-1?Q?OMWrzifRdH5UYCn2HSv+f+VmjcoCEWf/WnJGlk5w6qJXQfgN4FK2ZttdgJ?= =?iso-8859-1?Q?3LMdsg9HZK4hVFAIVwfmHUPx+EhhH2Sj1i4VfDtyAUNhZCAem8ntjzEaAE?= =?iso-8859-1?Q?q9c0/8kiy76pzyjlIF0JPcGCmHCNb5w5oCMQHV7BLLkHaTgNPqmYWRwIpv?= =?iso-8859-1?Q?kXuPyPFhP9C4H7Ckq+tRplgsjTVzLshl/5FFqYoVu/V0GQMk4pDfCNwZ6z?= =?iso-8859-1?Q?59XObXqQoCG6wYsm+klxip11EIxujEOWDLvGT6LTWB+MXyVEZIWGawyfpb?= =?iso-8859-1?Q?oZsIm93tpIiS2TsuboWs4kff83RFt6Y1WX/hCXxwPjluPJqfK2OMPMrXKU?= =?iso-8859-1?Q?2THQjQel9t23AQcXI/x/1grAs4+Ap5loy404IThcQFUHZKKCw46rcFfYbA?= =?iso-8859-1?Q?Ru5fVDa4rLOqQii69Mp/bYrNcL1GOWqQMYJlXy4fXshEUN7mHKIvWfY8UL?= =?iso-8859-1?Q?NPSWpo6tIEZ6YFwKMGNSEdq0vadxglhRTo7I7GxPiQJsBN6EhFLrnlI+eT?= =?iso-8859-1?Q?7Jaij/EwWz25CO9a+wA6bsg7Z8tPwatXOHHYld+qAaLUACAgjRvx47AWK3?= =?iso-8859-1?Q?vo64zI9xyBaRisRxAsgWSoRnoeBxpN3vxRh6ZdinrKSO6RLJaa3dM2OjmH?= =?iso-8859-1?Q?iiKcimvSBKGpiLL0iarx+OdkUqUFi1XA5ckcxe7pvHHqXDDN2Uuf0+cL7N?= =?iso-8859-1?Q?tgHpB/P8fO3rmiQHJAiAUasDd2bV+lReUuJ6EDiKGL9fPd1XYmjD/2SATP?= =?iso-8859-1?Q?qK936xWbKsxAacpdqN1x/vqnogxW0blBoEJvBZu3AZs5BP+99aiHMfXJv8?= =?iso-8859-1?Q?vMvw3B91USC0XAAIKDNC5uujqQ7Xg8CkRLepk4WN2pkxfuFIj54cA5/66t?= =?iso-8859-1?Q?cm2AfxKjdPvBVdYqjfViYo1z1wpNglolJCZHF8ENwkMZxmupox7ZLRKLNx?= =?iso-8859-1?Q?dThUkS10NmH0Ja0e8McC/q2sMbeSy0qWy6IET/vep774DH1FrP6i4qTPPh?= =?iso-8859-1?Q?KQdymMEdqXosZhwLnupB6lbnOfOdhSjBCozUjOAX3fcCSHk010fPIBgHfX?= =?iso-8859-1?Q?kJYGmB1ADBnyuVCQWYpOSX7nWsmGbC3APWHNyrUPmhjPYcwJQde07Y4RxV?= =?iso-8859-1?Q?tRwYxVdTIMhhs9aBxhnRg6/lAyir92zaCZ3d9gxJGkdaIsd1cYyUfuO7O7?= =?iso-8859-1?Q?FB8qqJnEKJT4l0LzZpxkTmbIXCpW1kKoMwRLhVhUmkRWSvnx0/UhUKqYlj?= =?iso-8859-1?Q?pee7+Ylc1E0kw6saxBUVJVSOJ5Hs3gcgEYA/rBdGCLGKogLi2nw8S+3BVO?= =?iso-8859-1?Q?axc8Kef1OHE09U+nl7YIwzqdBd6RxaOb7oJPvDcjZxDoXBb0JktJDpEoUK?= =?iso-8859-1?Q?jmY4A/cf83kBwFTpwkJ/ohAOmuIGC4EbVRwtTH2GJJYT567+MeKpOlwUAm?= =?iso-8859-1?Q?VLfEoCQ+dysKfkhWXxTLeTqQw+cxP3VFUBW3BeXdsam5lmOEmQSy18/g?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 02395181-bd63-43ac-56d3-08dd057ed6d9 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2024 14:07:28.8068 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tCMN4n6Hr0Q/51AsI+/4al8Pq0pmizknRQ+0sb6xpCrkiolwGfCtutYR1fdD/kEXMwJpTU+PsUwn8/tK3aJYGUl4jQwOsrs4T/svL+ovvnw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB5963 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Fri, Nov 15, 2024 at 02:52:57PM +0100, Morten Brørup wrote: > > From: Robin Jarry [mailto:rjarry@redhat.com] > > Sent: Friday, 15 November 2024 14.02 > > > > Morten Brørup, Nov 14, 2024 at 15:35: <snip> > > > > On that same topic, I wonder if it would make sense to change the API > > parameters to use an opaque rte_ipv4_addr_t type instead of a native > > uint32_t to avoid any confusion. > > It could be considered an IPv4 address type (like the IPv6 address type) (which should be in network endian), which it is not, so I don't like this idea. Can you clarify your objection to this idea? For me, the idea of having IPv4 addresses as a 4-byte array seems to offer a lot of advantages over treating it as a single 32-bit value. We don't need to worry about packing or alignment of the values, and everything would always be treated in network-byte order. The main downside I see is compatibility - we'd need a whole new set of definitions and functions in libs to make the change. /Bruce