From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3599645D42; Tue, 19 Nov 2024 12:41:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1F10140268; Tue, 19 Nov 2024 12:41:33 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by mails.dpdk.org (Postfix) with ESMTP id D099440041; Tue, 19 Nov 2024 12:41:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1732016493; x=1763552493; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=TfEkGNbOJ8uSv2Ne/plAcxvGKU2ysqhPuqdsSZie2oQ=; b=E/4egcLtVsllUSJU/PGv0+2E3NNTUWZPx8sTORGH890x9MmTYK2PHj2r 4202ZLjKt5gEwzKkqGUsick7pOmaTcF7aFFELPd67HFQuWVtVpsEaC2Z4 AEEgZGjktBnZejEVNUWXff/aVUZ33DPmQTMZvifVr8P+wVbJXoM6zKss4 yrzgqs4AhYXaxd0m3cfept3wBGrPHv6tIB8iJ+K3ZLD4KgYzQ5/Dmgd+4 92bVIFtR1QeJUxmcklKSNP5a88ReVLmb550OWiswceiOfEzV76u7BWxNe F38ZBVBCuANCgMci2Aq/a7xSCtGzi2Puk4TiyDqhcvrSkJatzsvaINBMT A==; X-CSE-ConnectionGUID: Gg+VWsVfSDiSLnuVrIcjvA== X-CSE-MsgGUID: YffBm2RKTjuEmONll+ZVnw== X-IronPort-AV: E=McAfee;i="6700,10204,11260"; a="35677720" X-IronPort-AV: E=Sophos;i="6.12,165,1728975600"; d="scan'208";a="35677720" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Nov 2024 03:41:31 -0800 X-CSE-ConnectionGUID: tldn7MoaSkCqLgA7T1dVng== X-CSE-MsgGUID: 3ZaNi/Q/QU6S4EW7pOApjA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,165,1728975600"; d="scan'208";a="89692414" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmviesa008.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 19 Nov 2024 03:41:31 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 19 Nov 2024 03:41:30 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 19 Nov 2024 03:41:30 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.48) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 19 Nov 2024 03:41:29 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ji6hoC2CsBA547XF7i92+F3AEYt/wtd1rijGQtu2slUxGZcYvxcOdaQ5EFHYwc/yzL+z2sqv9plrREgtwGcmn4+dJ62yeE7na75BKEG0MkC6elGh2VlvZuDCnvOsWSYZZWpGGuA+es/ajLJf7BtbhYtDxEmRo1UE9UO5k5FU5dALf6/ByCIy6b3ZSWcXdf8SRarJYrzzA2+nXfs35RQ6cVK79ekzJUufmT5alPJNNIq/Xk7UH8POsmLOYCh9X95oIhEDJOYhCd2uPcYgCWhoj0EVCYT1+UcQd4+bzWbCdLkINs29FSkZK5YwmeCGX/F/2vmTz8Ba2UI41hhKxeKj3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P0j8TYSz8wCSxdlTvM8yPu9m3Sa2NeeSJx9xwrqZ9aM=; b=hMcXy7c6ECrDBRIB36g60v6WbPz1AvlCyKpymUN1viR4Lw189ZVE+rxq0K7wOQAz/LkkbEzqWG4RqaUkxd2mLzIAwb5FGzLBcyEhiyGbWOG5nA5xXhj8+aoYte+pj31bhE3FlSpswIWGEdy7uwAUrXPoHdPPZ0Trq24H+fuzc88UgLED8Mc4jUPrZc0REkqsG2MWJeeJC1AffDueMwjgKuFthHJARiJKjIAqzb6u4/rVwxo0pkTYqXG4s2IEgQpNUM4tnFg0f7Dqlps0CCRciqhbyY5n5ug1ULManGkbfjRmkVrGE9HIPf2acfIZQZMynhfoz1aRtPAlTmPOO6MK8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by IA1PR11MB7293.namprd11.prod.outlook.com (2603:10b6:208:42a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.32; Tue, 19 Nov 2024 11:41:27 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8093.018; Tue, 19 Nov 2024 11:41:27 +0000 Date: Tue, 19 Nov 2024 11:41:22 +0000 From: Bruce Richardson To: "Connolly, Padraig J" CC: "Medvedkin, Vladimir" , "dev@dpdk.org" , "stable@dpdk.org" , "Stokes, Ian" , "Zhang, Qi Z" , Kevin Liu Subject: Re: [PATCH] net/iavf: add segment-length check to Tx prep Message-ID: References: <20241111164221.3031276-1-bruce.richardson@intel.com> <1acab313-ba0a-4934-8183-624ab8a1cb07@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DB8P191CA0003.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::13) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|IA1PR11MB7293:EE_ X-MS-Office365-Filtering-Correlation-Id: 5713c596-fd15-456a-4827-08dd088f1a89 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?JdipPuZmgHgnZ1z+DbvaA2wXZtOEJn4rovgcKw0XhXEhSFhtStOJBm9oOJ0Q?= =?us-ascii?Q?RJT29S61oExjIFbGewDCINiD/8MVXg55U4rFveqU83ZcmCeb1sgX6C0rCaG6?= =?us-ascii?Q?g33K6pV5YW0j0cZXIcUtfu8kUlUBaio7driZEAPZdtkJT7sOiplkMvmNApL1?= =?us-ascii?Q?ST6s9iOL3xZESRdB8AF4suRjJhH0ZxDJBsakRxCEemqKJXc4hud5mHAA7ZH/?= =?us-ascii?Q?BCBNUQe1khLVyuTvT0sKxQZ61JSt3TrIJRZYWOgxjJUql/F2m47DpjY3976n?= =?us-ascii?Q?NhQ4nFhN8MfE5C7icDxz8G2tNNwyMFMC+5byM5/6lIkrz4ZT2yV/fB6ICCBR?= =?us-ascii?Q?hWIzZJUf+LbCautkW4/DMKkPPKBvGpZu0rNlsSgQF40P1wKtEWEBeJh1lzrQ?= =?us-ascii?Q?jzIgYCP1g9RzbjH8edeDxTC3+T/IM41OjdTNdCH9ud1Q6yqAXgLE6k6G9EX9?= =?us-ascii?Q?J0PU7oErHOjD0cZ9nd+y5l9WSG+xgLQB7qR/WCH2bOdSn0n9ztnmpR+vJhQt?= =?us-ascii?Q?2OAsSs2oTbMz2ruDILWI/7wmvaNqC0CPdZdly7s77CuunCk3kQZ1vY/xMJOH?= =?us-ascii?Q?4xzohJ5E+Z8xDWIosGhnQlUB4NVek3ozpOEwtDiJiTeFAtpu6Z1UB9WWKGKb?= =?us-ascii?Q?TquKzEWf1V3qUpvkwV148UCfRJvTNWP4c/B6K38+qtwWSFAI4t0EZwQgLgoK?= =?us-ascii?Q?/ttMCb6x5OVItonHc65zEsCIspFvAyIcYk8kG4gk4BZHdSg1FW3+sq4sJjzZ?= =?us-ascii?Q?qxv1lWob1MvxK/Fik5yIaqP9ImqrSI+RCsGz9FX8msbWpyO7cZM+xBfhBt2k?= =?us-ascii?Q?JgcL7lJ/OU/xJ1sTeHXYVZtpqFDYPxt/npcaBDwYDtS/Qxle4tQwl1ZPgo7r?= =?us-ascii?Q?uZ397Rrb9xwn6MWObpUzQqlnZqa4U1eEM+AEuvJkvJximkRwznNmDLxGzSXa?= =?us-ascii?Q?cmw7YRRD/43V6u1YjI+SwBem62voc8zr7x04eCedNQU0eYESC/OLFyrjoBmi?= =?us-ascii?Q?EAhHAi0FS5i+zVAJ+i0XX2Z9GqC3Pe6CpPTA+ytV3vaK+t3DhfX/0601a1fz?= =?us-ascii?Q?OAs3KrtJJyMcWEtaCpsqHdzakggxCLSEZw5hgDS+y12jGBMzB0FMyxXgThj0?= =?us-ascii?Q?E1xJlraQOk3RGSn4s9r0vEOifDwYsMCkMcyqUEQE83JMCS/3oD8M9ttgEEw3?= =?us-ascii?Q?Mq60TeNi2w0Nscq+5qwOLzNvxzHcTTiBrtrzAFAaTJBodgwDjDCWAraTTNaX?= =?us-ascii?Q?zN3jIRCmvUM0zCxxZ8JCOJEwZpqKSv4dauFt9RsvbWLm6ynV94fWuH1AH6mE?= =?us-ascii?Q?1WA=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5fkzG3yEc9FJEYwJ3ffPeCGpipJtRSCoVeqzbAOTGFQHQsnsc55oy/czrGzu?= =?us-ascii?Q?Y1c3jBaRVx5f5RwWxpt5PppjLfhTzthKL/aBsZC3oE2P4FWvgHMdeCqyM5z7?= =?us-ascii?Q?b786kEoaDhYaXrZKeLAqPkLneatMC0I+RH4+Zg5vdTm+eBDmzB19y4o81TBr?= =?us-ascii?Q?Yy3AvJxaGhsKjPGpEQ3WPelhVD0n1EVQLaJt9z66QYhxpX2obYdo23jI2TEG?= =?us-ascii?Q?KFJr36quvTg7IBufqHiphdn7vYBptQ9QOVhqeFwAYXm/uUV+Rxu3R92CvU2B?= =?us-ascii?Q?5zgUbyC8JddmUszMw4gNzUoR8V+hfvybOCjFb90HvNlecy/1D20aGCcl5T3L?= =?us-ascii?Q?ePeJ3C6CWFSkxyqBUwp9KvYTnAHA1NU7SvotdIffM2mO+RqnQnayCQwqswgf?= =?us-ascii?Q?dzfR40QiiOE/MKuVAbtnHxffsBXAb1dz57YLBxVmtlOfWaXeDS0YifU1LDnh?= =?us-ascii?Q?cG+xga9AkaBT544BXYP567X7jRHFT3M5USLtH96R4JqW7Wyhqbp7omS6Z0an?= =?us-ascii?Q?eMZyXPt8mGS1otqegbMD21/x7HSoB8MNhz74uECnbKT61D4Qd3i8Qpto1uUw?= =?us-ascii?Q?rAClxtac9TIhaA7iP4RViTRXXyysJzD1b8PwXRwwgO3soMX38onuyMSCXMOA?= =?us-ascii?Q?Isu2lFAJwSq6Ar/NgpBCGXxAS3XfmEQijAN4kRxA7aAwolwLAFqNY76fy68D?= =?us-ascii?Q?uJo4wids3wuSxGvhVtj3DNhAAfpZAaFwWUgwWJUFYCJt4So9RJeVUfw0o7tq?= =?us-ascii?Q?riF618VnufbeFV26Kscc8OmNCK284332ltjl0fZACswlZTfUDu3DiSyw/Fss?= =?us-ascii?Q?2LIGpiJsp7e18zS748NTMxcAYnYBA04jn+LTiwChRUYfqwHFpyGaRYxx7/go?= =?us-ascii?Q?LpeMg3U36Yq2UxaWXzSKBCQPCOH8CfLT3yjTplms1HN0BDmhzT2+0LkEJQZt?= =?us-ascii?Q?uyDPq1MTZ/+seosM8xRsbcQ4eoltK7WtZLS2j3otEffLuBVWDgXLw/lX/dvf?= =?us-ascii?Q?7qFMoMPzM+xodJKddJMfSc3VxT6PBNBM+dQB9jbIx52VKTlLUEg0SZJtaCCu?= =?us-ascii?Q?v/y0Wgx/mI+Ue62Zrd2hb1ZfkJuFMsT6ugoht2Lqz6IBGpeYqCWz2Wk7Nud4?= =?us-ascii?Q?dqzVTGipNuzurrlKiua2x+W3qLW2oxymd9/mTWty0v1FMIIX3VO62OFJs4t7?= =?us-ascii?Q?PXX0QCVaW+O9vJw7hOfmrxhcGvMGWp9KtfPirPCd0pIk8w7Ao3k7Phr5elsU?= =?us-ascii?Q?Hnxxe3h1NbBfe6g2vzBc8e6F6bUg/6MuNsysj9j6FbQgEZLOwnq+yZyUapkL?= =?us-ascii?Q?v/P1DJ19M7WzQXgi5vZ1ZAsUQ1TZasRd3gDUNUPmlmEUpCXcKqVLagVPpjpA?= =?us-ascii?Q?mBBwCMm/hdPZmGGsXSE/omSZBdDGJSk6kV0wgM7Mb5+XH4IDwWul1/dlvAzk?= =?us-ascii?Q?J2CUhVSaCS0NwH3pR8jOVdM1MePT5ua9pmHL775PAz7Q7duEJVhlkSsdc7Gs?= =?us-ascii?Q?jyTu4HbTv/AjJaTROVV16LPEbf3QeHXBFHlu2gTuns7M3V0qOp2hT2N2lhi3?= =?us-ascii?Q?E3EJpUKn9tUfO6GQfLWkBFeb6EoXLQjY/O8sj7EndFTKtSYdfdGRfPnIEYu9?= =?us-ascii?Q?rA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5713c596-fd15-456a-4827-08dd088f1a89 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Nov 2024 11:41:27.6349 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2T4hfoFr3JblEtvbmdutzYVtb1Z4yqPrcwbjCcLrS+tM06p2LrhjCUZ0kSqxmOEzTXD1ibSOEBE/rcmwVtVFe5zbUXwdtRi/8Yn6VW1s4SI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7293 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Nov 19, 2024 at 09:17:57AM +0000, Connolly, Padraig J wrote: > __________________________________________________________________ > > From: Medvedkin, Vladimir > Sent: Monday 11 November 2024 5:46 pm > To: Richardson, Bruce ; dev@dpdk.org > > Cc: stable@dpdk.org ; Connolly, Padraig J > ; Stokes, Ian ; > Zhang, Qi Z ; Kevin Liu > Subject: Re: [PATCH] net/iavf: add segment-length check to Tx prep > > On 11/11/2024 16:42, Bruce Richardson wrote: > > In the Tx prep function, the metadata checks were only checking the > > packet length and ignoring the data length. For single-buffer packets > we > > can quickly check that the data length is the packet length. > > > > Fixes: 19ee91c6bd9a ("net/iavf: check illegal packet sizes") > > Cc: stable@dpdk.org > > > > Reported-by: Padraig Connolly > > Signed-off-by: Bruce Richardson > Acked-by: Vladimir Medvedkin > Tested-by: Padraig Connolly Applied to dpdk-next-net-intel /Bruce