From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E7EF145D44; Tue, 19 Nov 2024 16:43:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7A7284029B; Tue, 19 Nov 2024 16:43:37 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by mails.dpdk.org (Postfix) with ESMTP id C050F4028A for ; Tue, 19 Nov 2024 16:43:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1732031016; x=1763567016; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=u5mlIhtG5/kjr94Z6CeTBQtLzZLJnKRGSoebC4VmLt4=; b=LPVFojpmXJ1DDxowDGzADD1jncNiVO6BACgYI8XQfsJ9Tj4BZIbgmq1M hV/E0MVW2MjEyq032IIjL/B359DsnHdxFNTYRtiij7/N+a8ffcBGpyO3u Y8F83zDnsqRF3MagiS89IhQ3Uc4Soq8qp/kR4OFvzzywWSLGLMNaddv+K pm6Q+U5lhtGDwXo1L0OHK+E9Orep04fXfpNFc+ENx0vopSdwdNSVsLP4a 9pTQ1ORA0jSV3exKHWnWlVyQaArdBBXPBUOXeNFOEGEbvZ4eHggYMJtRx s3sx2PiohycVYSCyYFvTQbLvpv1N0UZFfEYKDajMZh8up4riPsAyJN8Nu g==; X-CSE-ConnectionGUID: jtxYinNmS22yS84DWih6tg== X-CSE-MsgGUID: zaYjeIc5QKGmU6Sm4yFYcw== X-IronPort-AV: E=McAfee;i="6700,10204,11261"; a="35710769" X-IronPort-AV: E=Sophos;i="6.12,166,1728975600"; d="scan'208";a="35710769" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Nov 2024 07:43:35 -0800 X-CSE-ConnectionGUID: uNHJxmH5TyOL45sBUZE5Aw== X-CSE-MsgGUID: hvTiMz8uSYK4kmC8XbPe/Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,166,1728975600"; d="scan'208";a="89600561" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa009.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 19 Nov 2024 07:43:35 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 19 Nov 2024 07:43:34 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 19 Nov 2024 07:43:34 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.49) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 19 Nov 2024 07:43:34 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fS8rr2Ct5bDK1ppl7AogNgSftWzJo1xsNU28MxqKh69NObH5i8QszPpDzTRDN7xM3ltWwGtz4w8GZpnz9lPSl1ye92MHtxnTHngtxdkB4A6DjmHlW5jGZ+VLTMHa+CHQadFCGUgCNlpWTotfgSy2NHztTTo9e2zJ6EDWXSlg6kzjxhG4h90GhdKdrqqRTxggVS9wphmxe0zkqwQRgnCxcGTIA4tE0I6KUGPJOy5bsYJXlnvk29OX5zFLbbV5cgWyuRdrtUcfO9hhYF5bKTGJsIQlrI+qPif0XMTaoPjkDN2xe9K0QG+XkixnrfjfGUa0LQDUFJZSTG7Z7sxNDeWvJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v/871ip4CXb135UKqKk/+xdKqQJprrUKEvwLmwlIU4A=; b=Hlh8AzI1jMFSmsTYSG2erGoWhW55EFaoSncPsWTxXhk6OBsWw9Fcgb/ua8GznsV/a38t015Mj+ACu49l1iAoow5GNnANso/bD19QOUL9QBiXaJcOAka5zSXLqcMJZfTarSXC0XdTGuu86co1P0pH0QLzlqQCZl2yq0/x8x2M5zDpfUE1SAk7l/aoLFGkw0c9GxVdClG1teLY96hODf09RjvYqG53IFS9DeuWvj1l2sFOeR7XFc9F8NcDMZw71ofBQdrMnfNCxeJ4KYLzXml85Yvp1Yt3PjJmxZ30maCsrVniPA1eWVXD1tqBi3iLCXMO1qXIhQhd67YkYPhYt6Nw+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SN7PR11MB7705.namprd11.prod.outlook.com (2603:10b6:806:32f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.21; Tue, 19 Nov 2024 15:43:32 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8093.018; Tue, 19 Nov 2024 15:43:32 +0000 Date: Tue, 19 Nov 2024 15:43:26 +0000 From: Bruce Richardson To: Dmitry Kozlyuk CC: , Anatoly Burakov , Lewis Donzis Subject: Re: [PATCH v2 1/2] contigmem: support including mapped buffers in core dump Message-ID: References: <20241023231859.1323727-1-kozlyuk@bifit.com> <20241025202615.2581513-1-dmitry.kozliuk@gmail.com> <20241025202615.2581513-2-dmitry.kozliuk@gmail.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20241025202615.2581513-2-dmitry.kozliuk@gmail.com> X-ClientProxiedBy: DU7P189CA0014.EURP189.PROD.OUTLOOK.COM (2603:10a6:10:552::21) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SN7PR11MB7705:EE_ X-MS-Office365-Filtering-Correlation-Id: 29b1c647-a2fc-440d-0bde-08dd08b0ebb7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?D6nJ4w7g50ta/MHSyxNy17Z9MgkOPDl8WEh5JYvzAVBzeTDcRFGYNtctsaZ5?= =?us-ascii?Q?ciFz9JrAgI+ibIeHlSHdJUHU+Al0dRweFmnFerpn+LWBGm92EehHDjWTE0d/?= =?us-ascii?Q?6fIrjO14Ow6BhZYWvU8EsUA+1yfKxADos+dDkByrEWRKSKmzk1k4Id3fCgWi?= =?us-ascii?Q?wNwvjfXzKFEZVm5CgQydb3TFDZcWCec4zg992sNcYcl4HS/lwnaaa/7zaOY9?= =?us-ascii?Q?TGxA6Etq8zLnFvOl19sDJQKt4DMeolRO7U4ZC79MCoTKzGpVTJN1db5Jije5?= =?us-ascii?Q?RyR8zQxw3E8edst5LJyWqW/n+UuVdQH6ptL2n+lOvXwOaeoM+hati13dW3PF?= =?us-ascii?Q?hlBa+OdU+dhf/DB5/YxEWaudhnWFm8kcV6u+7FMOV6zMeylnJX7TZvaNYbv+?= =?us-ascii?Q?6OQdT0pjfiNaIC9xN6CQUPF0yBjt6xVivDjgT0ysT9HCvEGtAu0M8eHL4Jpl?= =?us-ascii?Q?FMD0FBknuLSD2aDG0/DGTzfaHRHG1TYjFKTjdSF5PodqiVzCKleZBXNsy9mp?= =?us-ascii?Q?pRsAiMJ1tOKSDfG4gfqU3Ck57+mgXxiyGjxKbbeJ/xbQamFJoD4V352V3su7?= =?us-ascii?Q?idn/QW9mwg9qBa8vKniK0E0DQE8q7tQ3q2pjUQw+3K8kk7Ff+CYryCd+Citq?= =?us-ascii?Q?w5Dhp88uCHtOmT1IQnzmF3uw3DmQVvEqic2ZXywbFmOrQ9dFw1ItuqoLgEGA?= =?us-ascii?Q?ixsSh7ixJvL3W87CnmWKh/TrkxIdsOYbfaW9YjZGsQqRkXHNq0qRq7/6plda?= =?us-ascii?Q?mdr1nkL7Jf5qE0d16BFO46rUbiRnndjhnnDBqfkbqT4+AFaVm7f1L9Hlw061?= =?us-ascii?Q?q2so2Wr230l+W9dy2DBN5SPkD8UFHUsWZeKa1wRKIqk5aAF8sh7CBvEVqWXS?= =?us-ascii?Q?G24T5pGuFRBMN43Y9NH/JA+9xz7N35VddgjY9sX3/7fQxtVEG2Tunh27ADlC?= =?us-ascii?Q?KC+FQKK4ZixWOroMDsJMKuulBaNrAtkegoZOs30hNJERMSjkofBDnf3uSet5?= =?us-ascii?Q?VY4g35umYtcV6C2tRReEShwBWuD4rEGc4QTPxnBqWJt3bXFe1H8T6kHXo9ca?= =?us-ascii?Q?w5+WphgOwgR5XlrNDYXrkWgujw/dU2afee1Laxn+2atBHUziRlYXz8bhKmOb?= =?us-ascii?Q?gt5t6DAl2WmmZ9sXSaB/g24CY49Ryb/+xb2BCrXzwa/iIa47i2RNWP2iY9Fj?= =?us-ascii?Q?7CtpuuS2lfvt9lDkxw/skA7+Qieqr6LmmRqXdUECTYy3vXV9KWJKX3cOvUVk?= =?us-ascii?Q?f+5EJq5OjNAqQsKN+cTbdESYQg6FoY0GVaqpqdBPzGhWoLvlGafXZx0LS7dA?= =?us-ascii?Q?y05B+6SlR44GMzyCVZF36IPI?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8sgsqja3+CBK+jqxZwtBQqoNJAVd467LyN/vgtFWiZJ+qy/48g+HYXGXXy6U?= =?us-ascii?Q?Qpo9etunUmAyHRzlzqFWEBImTFIpqQ6YZ0orB/ThoQjBK68PzklErAJILpCU?= =?us-ascii?Q?4Cbr4hWHBnXQQoQl4EiY+7AGNnbvA5E9oBcXT0eIOlFv14bgSLF2Lx6lxODw?= =?us-ascii?Q?FWbBs6ge7kkg4k+xv/D8knhSvp5oDFoYT4uxByPsVmfkHmDno1QczHN/NnJf?= =?us-ascii?Q?zi+bxS7PH1UO+dZl27E52LstkYxmTbm+dB2FLHbwHP/tIgNy//9RKCXRsinE?= =?us-ascii?Q?/b3aGgI8nY/iLw/p/zbiUwvsuOEdp/BkC6KXtPSXGKb8mGV3vp13eTlTwTTV?= =?us-ascii?Q?T6pkFLon7IkJhSCIqKX5eQZfTi6WoRHXx4VkAxXqHpxhOCbZjYl+rKd9AgO3?= =?us-ascii?Q?xqv8VJx8d6lGnp8TXqG5D0uEAwMD9aVnlGkChlePL8fRrYO7I0DzqypoLPj0?= =?us-ascii?Q?QzhFiF39dR5jWrlSqEab5QklJUIRh0i4iIWtJessBIeVXxynxsRXhU8Gw1u/?= =?us-ascii?Q?61MiqeO4bjdCQX/WSiKsOt+sqzk6TGC1yEtXMWlD7ruBzYULJOwJmGLINsyX?= =?us-ascii?Q?MmKgGsYmsd0sY3VXIEF0ZcdpbMvJ6XjaiRqSdJH3hl5e1G9/34HIUzbg95q1?= =?us-ascii?Q?KTgllWOFazatWYhVETrjANZpycmjMGlJhrrREFGQahHZit/xon5M4V46QO8J?= =?us-ascii?Q?0V6kt/1q359lxEFT/XtTJXRHV+xkIYe1qDpGEIqVPaD6qQBnbb3nwXOctayy?= =?us-ascii?Q?sQVdq8yNdFZfbxjUbZYZnC87v0e7JpOq6gyioY2W/lF7A5N0ajsDDPzj66yz?= =?us-ascii?Q?57LVFQ0gTANU47GuAeAqC/9QHeGWokETaxb97ks9DGZfDoiGWO+hvPxMUAAT?= =?us-ascii?Q?X8bQmOSqu1oCt+3uBrXGE0tvPB1bamhv7QmuZbrXjPu/ZyfA+ThQhv+F15QF?= =?us-ascii?Q?SH7R+Sa6JGchI1eghmu7rN0sWWrJEe//M0X5lW+ofhdrI8cO4A4wBqdzDuoP?= =?us-ascii?Q?iMh3y83ecmw0QY0xeC/t2e5eElU/sbAClJUXazDwUDDrEFj/SDPqyZZCSdww?= =?us-ascii?Q?Ib5qtDTKoDnCe/Vr94Kai1Umb0/kXjRGUQUu5/cCEOIRUkAbHrmrUpsgg+JB?= =?us-ascii?Q?nRMa3axgdwWUEuQfxiS5+zRlCfMNiN6IwAK25JTQY8WPxLLH/mWrrEHK/Zhf?= =?us-ascii?Q?5MNGugvIatb9Mcn4vatFxoe1TfqGr1Ya9BVdUc1YtaD6zpzLBXe6OUAyYRV9?= =?us-ascii?Q?TyaCLHVIpZpJ7ozM/Cnx5dHY7opcYWMh8RVkWvqePFAG87MKkxYpgS9kb5nY?= =?us-ascii?Q?oVd5IhO0PzZmeMkD8C4603BOSPS+63XU8GH89TMuNoPJYTc7TzyTGqgAChhN?= =?us-ascii?Q?mefMJjT8zDP7pdutCVNPo/7lMwWIbIGE3YuMfysLXQ6N0NghZDQZ7H8jdmzs?= =?us-ascii?Q?FNkzU1YVQZiX2bUZIbE/jrkc8fIZf3McEdp9M42iOfhFJhj7WX+DpJg02XcJ?= =?us-ascii?Q?HIm7XIxX/ewInPQvc41pE/gk00DVAHtiRnYPgJjj0G5OOGUTItSQB+dlgTea?= =?us-ascii?Q?DHxug/ZDn+VyUE0FuTV+sW1khWKmGxtrMUtAY8gMQI1w+RlttBu5eAQYunYQ?= =?us-ascii?Q?MQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 29b1c647-a2fc-440d-0bde-08dd08b0ebb7 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Nov 2024 15:43:32.0477 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SGdO/KMKTCMeXwh2NobKt1VzpOB6eQ31ACwVS88AryVT823fP3PJ7zpO+qRgWw0Mb8uM5xYKGM4qhCGBTilnrYhXmnxPDqTgXB4F8nGojWk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7705 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Oct 25, 2024 at 11:26:14PM +0300, Dmitry Kozlyuk wrote: > It was impossible to include mapped contigmem buffers in core dump. > Add hw.contigmem.coredump_enable tunable to control the inclusion. > > Mappings backed by OBJ_FICTITIOUS are excluded from core dump. > While contigmem is a device and its OBJT_DEVICE mappings get this flag, > they are actually backed by memory. > Clear OBJ_FICTITIOUS mapping bit to include them in core dump. > Do this only if hw.contigmem.coredump_enable=1. > > Signed-off-by: Dmitry Kozlyuk > --- Patch LGTM Acked-by: Bruce Richardson