From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 798D345D44; Tue, 19 Nov 2024 16:49:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 46D494029B; Tue, 19 Nov 2024 16:49:02 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by mails.dpdk.org (Postfix) with ESMTP id 24A054028A for ; Tue, 19 Nov 2024 16:48:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1732031341; x=1763567341; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=iOAzlcIBpTlWr5bztSSU1BZ9Bv3mT0BbVAG8XexoacQ=; b=JS7QwyOSfMPLgua+U1QV3V2jUTCwQLsHcirdcd5jiPTOVIOOEet3dT/j I9tf5sCINMTrzgy7w9phH+XbkdN/sN6c4QcpgSsQyU2toKoYlkwAFaQQJ KdoQlJekIOjTx0ymzTocK9+PgiuW6S7SjF+pwD2YXOPxHhz9X+bdJjIOk 9ovLcp3BIfr6WG6aXmDoFExEk2rSRYIhdNgtOXJat5DudcuaaqedoRuDv 7aXgU3kGDOl/f1wcrG4X29RoHiZh2xS14fVBmBhrVGyfypx0MkqfK+Gpq NF9xZaTDEZEWZvDp/J2tDAuzkiqFyrBQXVI/YEeEthZwIt0eectM/Wpwe w==; X-CSE-ConnectionGUID: 8aYqElGMTjqwBTFMsilpqA== X-CSE-MsgGUID: HFeCYmXBSbKdQAvIzrGzrw== X-IronPort-AV: E=McAfee;i="6700,10204,11261"; a="32191234" X-IronPort-AV: E=Sophos;i="6.12,166,1728975600"; d="scan'208";a="32191234" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Nov 2024 07:48:59 -0800 X-CSE-ConnectionGUID: 58iYRBgXQ9Syhf0CH6+SoQ== X-CSE-MsgGUID: lIqM9soDRvqqVgiGEJWOwA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,166,1728975600"; d="scan'208";a="89758013" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmviesa008.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 19 Nov 2024 07:48:59 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 19 Nov 2024 07:48:58 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 19 Nov 2024 07:48:58 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.176) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 19 Nov 2024 07:48:58 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fKfkJ2wnMGhbGygtdzkPKO0Mh097XTa/PWuzGTQY1xUS2uJed5ruzB+ZosjBiWYbwS8ooJ/ADHsTG9afd/sbg+EuzGQsY4mmRMnw3XTAuScdmwCpytjVUzLM/meYlo6lkFXxr32vN8gciJ8AkLfppSwZN/qiLUnWTudYB/F08Oc8ywJSI06kg3ZpN4mHVpaLS7osa2J0IX1CvRnr8DTAuYN4+cS67ZpvU2pX+SqOrwc/BCEr3RVmlBxbkiknBDwEzZdfQ7dbR75/vO89tVfS1FQ7ceczKQKUIGOd9OZF8hc53cxAEK0/TsJ+ErUOkLn2sqUVYwJU+QWe61r6MjuBKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f3d/uvg+41NusoDBTj7xUWM6fmN2vTsM4f/OBoZJwj8=; b=AfshSGltDDVjMHgrue0n1p2cofv4xyC3w+6FCZaUn62RARbxLBC0LhQAUEFi5+cf4ASLHZlDPoou/PdzrDz4sTBzYg0xm6Jz012s6a8wHaW3xiGoOEM/y2SBcbCkzeLVZ4en+Kd56VqW90eGSF+pDG6ERoixCXRoZniUCuca91HqiUD3BAVH2ZfuDjRI2Hyg2Fxb3mVi+OmyyfhLSjZ+qP98RGZLawsDXn4jPkoUF4wlGgiRcLfUFOvDHUzrc8uVxzUSpsdwn3+UM87L3fXgcrmPU1oy2vkV3I2odt1XLBZTtPVwWyVnBDJi93glI3as1YRNmsbiRalGY1cWe6Wnqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH7PR11MB6555.namprd11.prod.outlook.com (2603:10b6:510:1a9::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.22; Tue, 19 Nov 2024 15:48:55 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8093.018; Tue, 19 Nov 2024 15:48:55 +0000 Date: Tue, 19 Nov 2024 15:48:49 +0000 From: Bruce Richardson To: Dmitry Kozlyuk CC: Lewis Donzis , dev , Anatoly Burakov , Stephen Hemminger , Morten =?iso-8859-1?Q?Br=F8rup?= Subject: Re: [PATCH v2 1/2] contigmem: support including mapped buffers in core dump Message-ID: References: <20241023231859.1323727-1-kozlyuk@bifit.com> <20241025202615.2581513-1-dmitry.kozliuk@gmail.com> <20241025202615.2581513-2-dmitry.kozliuk@gmail.com> <1865717992.9940628.1729942988633.JavaMail.zimbra@donzis.com> <20241028162606.48381738@sovereign> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20241028162606.48381738@sovereign> X-ClientProxiedBy: DU2PR04CA0247.eurprd04.prod.outlook.com (2603:10a6:10:28e::12) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH7PR11MB6555:EE_ X-MS-Office365-Filtering-Correlation-Id: 2c74c158-ea4b-4447-c797-08dd08b1ac5b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?mF5IS0GllM7iMeC01bWw5J+vC7CiwEn1sNBmEjdIljD3kpiet48IRdgcZS38?= =?us-ascii?Q?5fY22EPfsOYcEvOJ1+NqjVldEwxKeSqkbSBQT12yMBTzsiQfft5OAxJSU86y?= =?us-ascii?Q?jA7dwdldjkTygA/CjR3HpR59YOi4FNM//laF6m8LftyryJmgz4SEm4JbWZ1l?= =?us-ascii?Q?up9ok+Tc0VflRUu/cpdHoZ/8pJEb+C/YPf7GBMRf1xTvptQ838cdr0Sr0yBi?= =?us-ascii?Q?rwAPIbCle1NO/XHPKY1zJ4rLr9FcE0vtLh/RrzAqbsWi2ijvSfADm/Jrh5MY?= =?us-ascii?Q?S7ckdOPmlczkTaX6KJh8J1saebKq0Qoxi2++81kTkuTEateN+0W5GDJeDXr2?= =?us-ascii?Q?/jaLkAysrBqXpyRuScWAxVKDAu9hcZWlI5UluYx9nDJzOxMKfbohgIWqTZqV?= =?us-ascii?Q?mXfbdRFByC5C0ZyQ3uyAHyq18hLgwpvrVjSbbtaNJnd0kGs5j8oPRM15Dr/L?= =?us-ascii?Q?xoOinef+EegHBDPTapQ5Zk4c6U9hWNp9Vw3Owev3XjDUOveica2pnL5ZQqqU?= =?us-ascii?Q?1aFodXqwoI8kzPs5UBY5aHTytqiOz2JZrdOrcx6EDg+ac4dW2jz2HG5i1Zfo?= =?us-ascii?Q?Bn5r1ABxdQzdYse5/aEdFXwRzvgNSDAw/yuiM+fzFnmCAMda3CcDcd8PV+bN?= =?us-ascii?Q?tdavaPQdywPOGRRbz486dtj7e+31Nflut5Ajl2i0fpii4jTE9bpbi/vjSMZn?= =?us-ascii?Q?x/YNC8F0k/YArjDYhotyH06LW1otDQ49XGPIzUDW5SYU/DkOAcHV8an49dzk?= =?us-ascii?Q?QG0WHX90siiIwG6uKQi0/cW6FwODg+1QtUVTf2Z08lVXEDMFrQkNTBUPJJNv?= =?us-ascii?Q?xKoDpT5I0ZA187Z/FxH8NQe7RdK72CNPI0YdJp37UN3ZqJaK5ZZ2LRP3HYLy?= =?us-ascii?Q?XVX/FsxNpKzllls9oVm31WKE+gET/qP8FxpNbRGNPUVLYm7q9NCtrpotI5sf?= =?us-ascii?Q?lapxdPzPDRsAzkFYID+ULJ3SQfnEvoJwAJ7jpFNH+IVyZgjEO1u5Rs+4XVQF?= =?us-ascii?Q?KSB7yTsjk4MZ7Z5NAmTJSZUhogrFqob9a/V4hvOYD7kEnLrxBm5NQPJTV+L3?= =?us-ascii?Q?lT3s2bRKD51yosvePBWwyMMKdrUaAAQQC1B9+4hV1j9kFbrXCXll0u1fVHcB?= =?us-ascii?Q?XXpBb6dkw3TwJ14pmXXpqK0JEMpsFGAs4ASd08kqAtkWEeQ9mqqSynOtbeje?= =?us-ascii?Q?Y6guUvHTwt8EY4v881hVyKpvasjozhjPlFA77Q6t5Ehhps75uPzYlV2xQCBq?= =?us-ascii?Q?LvLvMjOyc9bz4tPoDYRB8QoTP1KORqIlYwN+HhbeInqznom2a+InOQvBOBzj?= =?us-ascii?Q?8a0HQnNWGN1Zn+fIulKLI//Q?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nIKl87I224nmLDIlgd/18hOPSwKYFmN3zBg8yr3Cntd8kyyMS1TAXnMBoPwi?= =?us-ascii?Q?ia3HIsfIaqM1eYK6xM1GtCDZGSigrlDhiOqAXHx1PkIVskQKls7ZWSZYjetd?= =?us-ascii?Q?U6LvOq/vmJqh3hCIcakfyPFuF6ttAeLiC1MypVS4+SFW+MbCLuNnd59SycwB?= =?us-ascii?Q?WXyewjTfqa6Ad70rOQg6pchcRGlbuDSwEVGWzNrBycFd8uvcS+g+zIacvpNB?= =?us-ascii?Q?24jgofB6k+qk2mbysbUhiZBV5UDJcPct4tUsr9zfvvHZLsp5SB6nF5CAr0yK?= =?us-ascii?Q?tzifTZqUW0CtR435CzLVE023wEcxWpSGw4AYmPeecKbQBJfnsdpBsBzgNF5A?= =?us-ascii?Q?Jh0uEXcDgAesCM+/9jtBe1IAYVdVs1p7t0fK1D1mwgYA5tTXrAx3c6dxDRKE?= =?us-ascii?Q?aGvUEQ87x67DFYMQHLhXYYHAGJ1ToLmbQKtT5DixAvMcm+Pz7BDhuafcDmGz?= =?us-ascii?Q?v8kN2NSBUxHQeqtcJT+PjT/V3fU4uErhyR+pAykDbbjRTuPVADNsxV61Tyfp?= =?us-ascii?Q?7ds4l3IlDehboTPBN6TPsVNUFT/BuY9IzgVxoH21w21nLFu610Y3oaJiyVjv?= =?us-ascii?Q?n/RglI9+oeKfW0IXC/WbARz0B6tf05cNikGv8XX0cYS8ECTB25nJAeCAHcJh?= =?us-ascii?Q?Q10iwoWv33++B/DxrvG1KGUjPPZJmhh4KBWf8jo5G2T0pEcaNnMOfjsQm6Um?= =?us-ascii?Q?yd/cVkw/34fx9Mq3T7GpNwcGUM9Vdp+4wSmV0pPAFu5CDIVZNCNt5pkp6/Qe?= =?us-ascii?Q?4s/1nADn4Xo3qCN0bJBcX46Vj2hYPPhShlGJp+XNDWTGmC+iIBW3jvI3Qx7Q?= =?us-ascii?Q?Vz5FwTZnulhAlRHdIJswgX7z99uXwvSVQpbd8J3NT+eraBDm6QByv4wdm7m9?= =?us-ascii?Q?A56/hgAxR7HEf134N3U3mG1qhPSbcKmsSl63asLm2rBgK2fpfUKTznv+3ETH?= =?us-ascii?Q?OGLch2vQzb8dUiYk+rBYwY4IbTsrFJUNny2Fkf/Zb0FcdTSbU17+NCwgfYm5?= =?us-ascii?Q?tjU2blic4yWLZcKDkjaJcs9/cTB9ftkWzmyfZXaeDLtt/mW/RQ69D1ct/bmA?= =?us-ascii?Q?MPJBO6kGKp4Nnw8IOX/QwsckjFPB82/vXlJW3dn8A4/5LvZT8DVCELYKAqUx?= =?us-ascii?Q?trKEod6NGfQtO7KGZvL67dPzvHBQtyPXtq30nrMdrIXN4SEq8iGFJkz6uejQ?= =?us-ascii?Q?rYjd4L5RPsmYfv1fKJ016qVgv++TGmy7cZp9+p/1rFg7IS8privIz6OkK6gE?= =?us-ascii?Q?qg72yXbpHbbhuJXeejZkn8aC2886/8nQqbQLVbmrfmIrOClVLP1UN69FBi/v?= =?us-ascii?Q?wlzdIZTjoTdR2bRgLdFhrGWtrpcmBCW0E8J87v/YRAOpUW3t8zVdjR0Cw3FM?= =?us-ascii?Q?JsiZpqXfXGRbFHhX61ZIGRMtIKQQrN/Sll+/D6qFZ7luwTlPX2shkkzbogqF?= =?us-ascii?Q?Gy0UmQy3KREtuYeFLlSMBipb7FAYaYD391qpiS/90z5k+Kd7ty+6hYHPorca?= =?us-ascii?Q?xQ5rBCAR16PDuI48ue6Uq6/Q3kftBZmtukrYmPgcc+VeRRquIUVgsPeWjNT1?= =?us-ascii?Q?Y4zibxqR2IYlN5k4rUDhGxa4ipyqDZNaIeO6otftb+cUTO0Hi84JvQScTybf?= =?us-ascii?Q?2w=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2c74c158-ea4b-4447-c797-08dd08b1ac5b X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Nov 2024 15:48:55.1542 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: H0yAVuee/wWkmlcvGxEDWbnITQKp2xm00yDNzNKlsyTUnZNNUqmOdw2sQ5nMrZrXm1SNLkhQMk7OKd1oQBcOOKqGnRWaw177iIigVvhixXw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6555 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Oct 28, 2024 at 04:26:06PM +0300, Dmitry Kozlyuk wrote: > 2024-10-26 06:43 (UTC-0500), Lewis Donzis: > > Is the extra control necessary, i.e., why not just always do this and let > > the EAL option control whether the pages get dumped? > > I've been evaluating your suggestion and see no downsides, > except contigmem default behavior change, but does it have non-DPDK users? > If no one objects, I'll prepare v3 doing the following: > 1) everything from v2, > 2) except always mark contigmem buffers as dumpable, > 3) add --dump-mapped back and make DPDK disable dumping by default. > As a result, in order to include mapped memory in coredump: > * FreeBSD will require only "--dump-mapped"; > * Linux will require both "coredump_filter" setup and "--dump-mapped". That all seems very reasonable, but it is late in the release cycle at this point. Do you think it would be good to just take the v2 as is for 24.11, and then change things thereafter to have more dynamic/runtime control of the dump-setting in 25.03? >From compatibility viewpoint, I don't think there are any non-DPDK users, so if behaviour with EAL doesn't change, I don't think having the kernel module default be different matters as we go from one release to the next. /Bruce