From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 629F2A034F; Wed, 28 Jul 2021 10:05:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DB0C940E64; Wed, 28 Jul 2021 10:05:34 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 2B26D40142 for ; Wed, 28 Jul 2021 10:05:33 +0200 (CEST) Received: from [192.168.100.116] (unknown [37.139.99.76]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 793977F510; Wed, 28 Jul 2021 11:05:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 793977F510 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1627459532; bh=xuL2dSfZKW1BXQJq8oaLxQNWgcSU3KcAfGe0/Ly7Zns=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=xQ1FMP/gI+zIC8t1u+8IeugFTOvSXPAX/SU5qlsZ1v6NxurDga72FCAO97xw2vQAf YT/VGi6eP76BeCl9sqvUW86dffyfC3oWGtdwhMnT9yWBBO+HFunRc6TH4jqNP/5bVc D93M0C7LLJArlkpo9CL0Vwnj4CHSmfhtnBPw8434= To: Dmitry Kozlyuk , dev@dpdk.org Cc: David Marchand References: <20210727073121.895620-1-dkozlyuk@nvidia.com> From: Andrew Rybchenko Message-ID: Date: Wed, 28 Jul 2021 11:05:31 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210727073121.895620-1-dkozlyuk@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 0/4] net/mlx5: keep indirect actions across port restart X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/27/21 10:31 AM, Dmitry Kozlyuk wrote: > It was unspecified what happens to indirect actions when a port > is stopped, possibly reconfigured, and started again. MLX5 PMD, > the first one to use indirect actions, intended to keep them across > such a sequence, but the implementation was buggy. Patches 1-3 fix > the PMD behavior, patch 4 adds common specification with rationale. I'm sorry, but it looks very inconsistent. If flow rules are not preserved across restart, indirect actions should not be preserved as well. We need very strong reasons to introduce the inconsistency. If we finally accept it, I think it would be very useful to care about PMDs which cannot preserve it in HW across restart from the very beginning and save it in ethdev layer and restore on start automatically (i.e. do not force all such PMDs to care about the restore internally and basically duplicate the code).