From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D010A0548; Sun, 25 Apr 2021 19:07:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 12FF74113E; Sun, 25 Apr 2021 19:07:49 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id C0EE74113C; Sun, 25 Apr 2021 19:07:47 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 1D2E05C006D; Sun, 25 Apr 2021 13:07:46 -0400 (EDT) Received: from imap4 ([10.202.2.54]) by compute2.internal (MEProxy); Sun, 25 Apr 2021 13:07:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type:content-transfer-encoding; s=fm1; bh=LYGZL tjINpDY5SiHafS0s+jnTGfYU+ASOUQW+wOpW5E=; b=PCVjpOqWmJLLJJLS2/V6o 6EoAaeRqQYhz7qC1KVLrxugiE7ehuOhUmt/yOJ5DGCjRuB6gxfja+rb9jfjN9atc KE9m1I6x+S+iAHB1zjaHDJOQVku+OEniuKUm7Gd4m9eBZLQxP6OFoJHFDAQRy879 pmmfr/SPnCCNdpRCfYIBBCKROyAGG3z06DZPHk8jE+MrtwWFTrzcZS3sQLB701nY hE6bdW/eR6EvmHCd72kCatsL6ws8llxsvtO15fExFGsbnqiQn0uTXjwj+872s3ms rZ+5vGG9AMAqouliYuVkFzUxwPh8/r3uKlMyR7l8Th0C03Z78U1OOOYTuw6tT/tj Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=LYGZLtjINpDY5SiHafS0s+jnTGfYU+ASOUQW+wOpW 5E=; b=UkSbQm93UcXMqEvtCtlw39gDXsuhpbSXdwsnLauK4aszJlqYhmQFpVgug IFMyufFOWEYB1p//05Cu4VDxO1JsVmn6KwW1tfXqRVF1QCWqXplW1xPPDR9eGLWz xJ1izfpJHbc2x3nnJSNAjofCGpxUNw+Y3galtUh+CbbpYYX6Q0DGf82PFv7YvOm/ 7W8EN8motRTT1bfQFbu5bn3JDE0ccMYedpNMJj2Sz75bA3wUl/EW1EuFO0pLLmjF Ju62SpWNw72WrOOahIOsZpTF/pPhdmh6oqGuQC0q3Yt3GdWLdatio35PZvG1sLl+ lWICJWoDtzdLojxAKen6B2C/jWsZA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdduiedgudduudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvufgtgfesthhqredtreerjeenucfhrhhomhepfdfv hhhomhgrshcuofhonhhjrghlohhnfdcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvg htqeenucggtffrrghtthgvrhhnpeevhfegkedutdekvddvudejueefudduleetheekhfdv heegteelffetkeejleeiteenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 87654160648; Sun, 25 Apr 2021 13:07:45 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-403-gbc3c488b23-fm-20210419.005-gbc3c488b Mime-Version: 1.0 Message-Id: In-Reply-To: References: <20210419130204.24348-1-getelson@nvidia.com> <20210425155722.32477-1-getelson@nvidia.com> <43215430-8e29-4869-8d69-6c385e612153@www.fastmail.com> Date: Sun, 25 Apr 2021 19:07:22 +0200 From: "Thomas Monjalon" To: "Gregory Etelson" , "dev@dpdk.org" Cc: "Matan Azrad" , "Raslan Darawsheh" , "Ferruh Yigit" , "stable@dpdk.org" , "Viacheslav Ovsiienko" , "Shahaf Shuler" , "Asaf Penso" Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] =?utf-8?q?=5BPATCH_v2_1/2=5D_net/mlx5=3A_fix_tunnel_o?= =?utf-8?q?ffload_private_items_location?= X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Dim 25 avr 2021, =C3=A0 19:01, Gregory Etelson a =C3=A9crit=E2=80=AF: > Hello Thomas, > =20 > > Dim 25 avr 2021, =C3=A0 17:57, Gregory Etelson a =C3=A9crit=E2=80=AF= : > > > Tunnel offload API requires application to query PMD for specific = flow > > > items and actions. Application uses these PMD specific elements to= > > > build flow rules according to the tunnel offload model. > > > The model does not restrict private elements location in a flow ru= le, > > > but the current MLX5 PMD implementation expects that tunnel offloa= d > > > rule will begin with PMD specific elements. > > > The patch removes that placement limitation in MLX5 PMD. > > > > > > Cc: stable@dpdk.org > > > > > > Fixes: 4ec6360de37d ("net/mlx5: implement tunnel offload") > >=20 > > Cc: stable must be just after the Fixes line. > >=20 > > There is a testpmd patch in the same series, is it OK to be merged i= n mlx > > tree? >=20 > The tunnel offload model can be complicated.=20 > The testpmd patch that comes with this one emphasizes how application > can construct a flow rule without placement restrictions. > I think that both patches should be merged. That's not the question. One patch should be merged in mlx tree, while the other one should targe= t next-net. In such a situation, quite often we split in different series. For this case, it's up to Raslan and Ferruh to agree on how to proceed.