DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)" <jgrajcia@cisco.com>
To: Anand Sunkad <anand.sunkad@benisontech.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	Vivek Gupta <vivekg@benisontech.com>,
	Thomas Mulamangalath <thomas.mulamangalath@benisontech.com>
Subject: Re: [dpdk-dev] [PATCH] net/memif: add multiple memif data transmission support
Date: Thu, 17 Oct 2019 11:28:51 +0000	[thread overview]
Message-ID: <a03dce70c9a146ce9a4d9c0fcedbe8de@XCH-ALN-004.cisco.com> (raw)
In-Reply-To: <1571232181-5874-1-git-send-email-anand.sunkad@benisontech.com>



> -----Original Message-----
> From: Anand Sunkad <anand.sunkad@benisontech.com>
> Sent: Wednesday, October 16, 2019 3:22 PM
> To: Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)
> <jgrajcia@cisco.com>
> Cc: dev@dpdk.org; Vivek Gupta <vivekg@benisontech.com>; Thomas
> Mulamangalath <thomas.mulamangalath@benisontech.com>; Anand Sunkad
> <anand.sunkad@benisontech.com>
> Subject: [PATCH] net/memif: add multiple memif data transmission support
> 
> When Multiple slave/master Memif interfaces are created in single process
> data transmission over second connection is not successful.
> 
> Issue is because of "mq->in_port" is not initialized with "dev->data->port_id"
> in memif_msg_enq_add_ring() and
> memif_msg_receive_add_ring() functions, and while transmitting packets
> over second connection in eth_memif_tx function it refer "mq->in_port"
> which is always zero, and leads to data transmission always in 0th port.
> 
> To mitigate the issue,"mq->in_port" is initialized with "dev->data->port_id" in
> memif_msg_enq_add_ring() and
> memif_msg_receive_add_ring() functions.
> 
> Signed-off-by: Anand Sunkad <anand.sunkad@benisontech.com>

Good catch, however you want to initialize mq->in_port in memif_tx_queue_setup().

Thanks,
Jakub

  reply	other threads:[~2019-10-17 11:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-16 13:22 Anand Sunkad
2019-10-17 11:28 ` Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco) [this message]
2019-10-17 13:20 ` Anand Sunkad
2019-10-23  8:45   ` Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)
2019-10-23 18:11     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a03dce70c9a146ce9a4d9c0fcedbe8de@XCH-ALN-004.cisco.com \
    --to=jgrajcia@cisco.com \
    --cc=anand.sunkad@benisontech.com \
    --cc=dev@dpdk.org \
    --cc=thomas.mulamangalath@benisontech.com \
    --cc=vivekg@benisontech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).