From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1D19F43388; Tue, 21 Nov 2023 04:32:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 90AA540298; Tue, 21 Nov 2023 04:32:12 +0100 (CET) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id B42284025F for ; Tue, 21 Nov 2023 04:32:10 +0100 (CET) Received: from kwepemm000004.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4SZ8wk6zcXzsR4J; Tue, 21 Nov 2023 11:28:38 +0800 (CST) Received: from [10.67.121.59] (10.67.121.59) by kwepemm000004.china.huawei.com (7.193.23.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 21 Nov 2023 11:32:06 +0800 Message-ID: Date: Tue, 21 Nov 2023 11:32:05 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v2 14/16] app/testpmd: verify strdup return value To: Chengwen Feng , , , Aman Singh , Yuying Zhang , Wenxuan Wu , Yuan Wang , Andrew Rybchenko , Xuan Ding CC: References: <20231110100117.8350-1-fengchengwen@huawei.com> <20231110100117.8350-15-fengchengwen@huawei.com> From: "lihuisong (C)" In-Reply-To: <20231110100117.8350-15-fengchengwen@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.121.59] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemm000004.china.huawei.com (7.193.23.18) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Acked-by: Huisong Li 在 2023/11/10 18:01, Chengwen Feng 写道: > Add verify strdup return value logic. > > Fixes: 52e2e7edcf48 ("app/testpmd: add protocol-based buffer split") > Cc: stable@dpdk.org > > Signed-off-by: Chengwen Feng > --- > app/test-pmd/cmdline.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index 912bf3355c..904c04d466 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -3528,6 +3528,8 @@ parse_hdrs_list(const char *str, const char *item_name, unsigned int max_items, > > nb_item = 0; > char *str2 = strdup(str); > + if (str2 == NULL) > + return nb_item; > cur = strtok_r(str2, ",", &tmp); > while (cur != NULL) { > parsed_items[nb_item] = get_ptype(cur);