From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F73BA0C43; Thu, 23 Sep 2021 12:09:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3B90E41260; Thu, 23 Sep 2021 12:09:51 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id EEBC441250 for ; Thu, 23 Sep 2021 12:09:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632391789; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8HE7Vyf2LD2nXrNnKeWNnwPDL8EGS1a3n+Xwz37MIHE=; b=Mvms10FmsoSD6lYCRv4Ha40JnlffU4Lk5eNgREcJOBlES2KLL6as28uLVzMuAK3Yzi+NuL NTzDmCWeK9B9oHaXloRtletlQnX4u6tESamL1OpwcBgQvqKDdKT3O4rVmz8Ns4u7qeTMNC 3/ZRC1i4+zCHrVxyFpJ/DENjLJNqfRY= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-568-geRkIFa9NwKZlLs98nP85A-1; Thu, 23 Sep 2021 06:09:48 -0400 X-MC-Unique: geRkIFa9NwKZlLs98nP85A-1 Received: by mail-wr1-f72.google.com with SMTP id j16-20020adfa550000000b0016012acc443so4695751wrb.14 for ; Thu, 23 Sep 2021 03:09:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:references:from:subject:in-reply-to :content-transfer-encoding; bh=8HE7Vyf2LD2nXrNnKeWNnwPDL8EGS1a3n+Xwz37MIHE=; b=vq6yQftJewui4/gufzquhPLrkAkzRAkTMm+6EiLzQaksnyZgWshtS0X06M6UhlIrPS LJloZyIrIESRKb058kwDxg8zvFJtehnuwOgsp9hcGyCw9JYxnLtdIOp4iNNprP2kZ99i Czyv7m4ktFFCZci3wZa4p8DeO9o29n64+/9K4IkHcnMq5QjwV+pYixy9kAiGOEfs8DhZ Muw2SlyCQ3TU+H626z8axBK4+Ppdk0TqTneZmEQL/VRS7Dfn6KdFKOWdPREA+D1Yzeze nKhIUW1hwC/50fXQ2mjltwe2wbaoFOq2gMMfKVhmBdCv2HApmSQhzs7se8Q6ZOTZvLpK J3ZQ== X-Gm-Message-State: AOAM530spO5kicdzNP/4EEor8K1sAX6Z+ZmNK3aGPwcYkpxI5ojIjgb4 50jWebE3kuuDykpSoivDfL227H00if+LFeNYcJx3djUs8z1mIuHOcBs5bqXmtWibYls68+DLmzI VXH8= X-Received: by 2002:a5d:598f:: with SMTP id n15mr4113935wri.74.1632391779803; Thu, 23 Sep 2021 03:09:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxqB+xbkZM/fR3DzkQZQk1jIrJJe6J2CLtm8fjr3wSmv1ki/nY2NE2GD/aFPxkuNon0t26CUQ== X-Received: by 2002:a5d:598f:: with SMTP id n15mr4113908wri.74.1632391779618; Thu, 23 Sep 2021 03:09:39 -0700 (PDT) Received: from [192.168.0.36] ([78.18.26.217]) by smtp.gmail.com with ESMTPSA id g131sm4585379wme.22.2021.09.23.03.09.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Sep 2021 03:09:39 -0700 (PDT) Message-ID: Date: Thu, 23 Sep 2021 11:09:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 To: Bernard Iremonger , ray.kinsella@intel.com, dev@dpdk.org References: <1631718995-25427-1-git-send-email-bernard.iremonger@intel.com> <1632329295-22822-1-git-send-email-bernard.iremonger@intel.com> From: Kevin Traynor In-Reply-To: <1632329295-22822-1-git-send-email-bernard.iremonger@intel.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] flow_classify: remove eperimental tag from the API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Bernard, On 22/09/2021 17:48, Bernard Iremonger wrote: > This API was introduced in 17.11, removing experimental tag > to promote to stable state. > > Signed-off-by: Bernard Iremonger > --- > examples/flow_classify/meson.build | 2 +- > lib/flow_classify/rte_flow_classify.h | 7 ------- > lib/flow_classify/version.map | 2 +- > 3 files changed, 2 insertions(+), 9 deletions(-) > > diff --git a/examples/flow_classify/meson.build b/examples/flow_classify/meson.build > index 1be1bf0374..bffceb9465 100644 > --- a/examples/flow_classify/meson.build > +++ b/examples/flow_classify/meson.build > @@ -7,7 +7,7 @@ > # DPDK instance, use 'make' > > deps += 'flow_classify' > -allow_experimental_apis = true > + > sources = files( > 'flow_classify.c', > ) > diff --git a/lib/flow_classify/rte_flow_classify.h b/lib/flow_classify/rte_flow_classify.h > index 82ea92b6a6..3759cd32af 100644 > --- a/lib/flow_classify/rte_flow_classify.h > +++ b/lib/flow_classify/rte_flow_classify.h The library is still marked as experimental, but I don't think this is valid anymore as it now contains stable APIs. So needs some removals: Text below in rte_flow_classify.h, * @warning * @b EXPERIMENTAL: * All functions in this file may be changed or removed without prior notice. Also in MAINTAINERS file, Flow Classify - EXPERIMENTAL and as it is lib moving into stable ABI, then probably something should go in the release notes for this. thanks, Kevin. > @@ -157,7 +157,6 @@ struct rte_flow_classify_ipv4_5tuple_stats { > * @return > * Handle to flow classifier instance on success or NULL otherwise > */ > -__rte_experimental > struct rte_flow_classifier * > rte_flow_classifier_create(struct rte_flow_classifier_params *params); > > @@ -169,7 +168,6 @@ rte_flow_classifier_create(struct rte_flow_classifier_params *params); > * @return > * 0 on success, error code otherwise > */ > -__rte_experimental > int > rte_flow_classifier_free(struct rte_flow_classifier *cls); > > @@ -183,7 +181,6 @@ rte_flow_classifier_free(struct rte_flow_classifier *cls); > * @return > * 0 on success, error code otherwise > */ > -__rte_experimental > int > rte_flow_classify_table_create(struct rte_flow_classifier *cls, > struct rte_flow_classify_table_params *params); > @@ -205,7 +202,6 @@ rte_flow_classify_table_create(struct rte_flow_classifier *cls, > * @return > * 0 on success, error code otherwise > */ > -__rte_experimental > int > rte_flow_classify_validate(struct rte_flow_classifier *cls, > const struct rte_flow_attr *attr, > @@ -232,7 +228,6 @@ rte_flow_classify_validate(struct rte_flow_classifier *cls, > * @return > * A valid handle in case of success, NULL otherwise. > */ > -__rte_experimental > struct rte_flow_classify_rule * > rte_flow_classify_table_entry_add(struct rte_flow_classifier *cls, > const struct rte_flow_attr *attr, > @@ -251,7 +246,6 @@ rte_flow_classify_table_entry_add(struct rte_flow_classifier *cls, > * @return > * 0 on success, error code otherwise. > */ > -__rte_experimental > int > rte_flow_classify_table_entry_delete(struct rte_flow_classifier *cls, > struct rte_flow_classify_rule *rule); > @@ -273,7 +267,6 @@ rte_flow_classify_table_entry_delete(struct rte_flow_classifier *cls, > * @return > * 0 on success, error code otherwise. > */ > -__rte_experimental > int > rte_flow_classifier_query(struct rte_flow_classifier *cls, > struct rte_mbuf **pkts, > diff --git a/lib/flow_classify/version.map b/lib/flow_classify/version.map > index 49bc25c6a0..b7a888053b 100644 > --- a/lib/flow_classify/version.map > +++ b/lib/flow_classify/version.map > @@ -1,4 +1,4 @@ > -EXPERIMENTAL { > +DPDK_22 { > global: > > rte_flow_classifier_create; >