From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id A37D61B5BA for ; Tue, 18 Dec 2018 15:01:45 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DB04EDC917; Tue, 18 Dec 2018 14:01:44 +0000 (UTC) Received: from [10.36.112.55] (ovpn-112-55.ams2.redhat.com [10.36.112.55]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 373B4608C5; Tue, 18 Dec 2018 14:01:42 +0000 (UTC) To: Matthias Gatto , dev@dpdk.org Cc: tiwei.bie@intel.com, zhihong.wang@intel.com References: <1544112007-23177-1-git-send-email-matthias.gatto@outscale.com> From: Maxime Coquelin Message-ID: Date: Tue, 18 Dec 2018 15:01:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: <1544112007-23177-1-git-send-email-matthias.gatto@outscale.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 18 Dec 2018 14:01:45 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] vhost: fix race condition in fdset_add X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Dec 2018 14:01:45 -0000 On 12/6/18 5:00 PM, Matthias Gatto wrote: > fdset_add can call fdset_shrink_nolock which call fdset_move > concurrently to poll that is call in fdset_event_dispatch. > > This patch add a mutex to protect poll from been call at the same time > fdset_add call fdset_shrink_nolock. > > Signed-off-by: Matthias Gatto > --- > lib/librte_vhost/fd_man.c | 4 ++++ > lib/librte_vhost/fd_man.h | 1 + > lib/librte_vhost/socket.c | 1 + > 3 files changed, 6 insertions(+) Applied to dpdk-next-virtio Thanks, Maxime