From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EEAFEA04C8; Fri, 18 Sep 2020 14:13:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D6E0F1DA23; Fri, 18 Sep 2020 14:13:47 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 423501DA0A for ; Fri, 18 Sep 2020 14:13:46 +0200 (CEST) IronPort-SDR: VOipBgm6j+bmqYCJmeu3PLhg24iouzIr0VHXFRvsjImJx46oGa5icYdayHkIvQV6iwZ74OIsnC 9qtooai9g2iw== X-IronPort-AV: E=McAfee;i="6000,8403,9747"; a="221480871" X-IronPort-AV: E=Sophos;i="5.77,274,1596524400"; d="scan'208";a="221480871" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2020 05:13:44 -0700 IronPort-SDR: 2yPk5nL/YYNBlGH4GOodEl8hTtkEU1iWIDrYCaV+4G9CL0X7xxmyRS81LSR8JdKpEpBaeKyfNS aY2qvWYGMjnQ== X-IronPort-AV: E=Sophos;i="5.77,274,1596524400"; d="scan'208";a="484180990" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.227.248]) ([10.213.227.248]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2020 05:13:41 -0700 To: Bruce Richardson , Stephen Hemminger Cc: Olivier Matz , Dmitry Kozlyuk , dev@dpdk.org, Dmitry Malloy , Narcisa Ana Maria Vasile , Fady Bader , Tal Shnaiderman , "Kadam, Pallavi" , Ray Kinsella , Neil Horman References: <20200620210511.13134-1-dmitry.kozliuk@gmail.com> <20200730210652.14568-1-dmitry.kozliuk@gmail.com> <20200730210652.14568-2-dmitry.kozliuk@gmail.com> <20200917133443.GR21395@platinum> <20200917100548.37f7cfb0@hermes.lan> <20200918083319.GA1583@bricha3-MOBL.ger.corp.intel.com> From: Ferruh Yigit Message-ID: Date: Fri, 18 Sep 2020 13:13:38 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: <20200918083319.GA1583@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 1/7] cmdline: make implementation opaque X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Archived-At: List-Archive: On 9/18/2020 9:33 AM, Bruce Richardson wrote: > On Thu, Sep 17, 2020 at 10:05:48AM -0700, Stephen Hemminger wrote: >> On Thu, 17 Sep 2020 15:34:43 +0200 >> Olivier Matz wrote: >> >>> Hi Dmitry, >>> >>> On Fri, Jul 31, 2020 at 12:06:45AM +0300, Dmitry Kozlyuk wrote: >>>> struct cmdline exposes platform-specific members it contains, most >>>> notably struct termios that is only available on Unix. Make the >>>> structure opaque. >>>> >>>> Remove tests checking struct cmdline content as meaningless. >>>> >>>> Add cmdline_get_rdline() to access history buffer. >>>> The new function is currently used only in tests. >>>> >>>> Signed-off-by: Dmitry Kozlyuk >>> >>> First, please forgive me for the very late feedback. It is all the more >>> problematic because I think this patch introduces an ABI breakage, that >>> should have been announced. >> >> Since 20.11 is a API/ABI breaking release, I think breaking ABI >> is okay without announcement. What matters more is if that API would >> need to be impacted. API changes need some announcement. > > This is something that we need to get a clear decision from technical board > on, I think, since there are some other proposed ABI changes in patches > that were not pre-announced, e.g. changing the lpm structure. > And we accepted another in ethdev one, but that library already has bunch of deprecation notices on it and one more change won't has much affect. Overall looks OK to me to accept minor changes without deprecation notices, big ones can be investigated case by case, and +1 to have some guidance from the techboard.