From: Ferruh Yigit <ferruh.yigit@amd.com>
To: "Guo, Junfeng" <junfeng.guo@intel.com>,
Rushil Gupta <rushilg@google.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH] net/gve: fix bug in verify driver compatibility
Date: Thu, 1 Jun 2023 09:35:01 +0100 [thread overview]
Message-ID: <a0acc50b-82b4-320f-0693-b3e2ac833eda@amd.com> (raw)
In-Reply-To: <DM6PR11MB3723DA3AF8F6B048FB4F976FE7499@DM6PR11MB3723.namprd11.prod.outlook.com>
On 6/1/2023 7:44 AM, Guo, Junfeng wrote:
>
>
>> -----Original Message-----
>> From: Rushil Gupta <rushilg@google.com>
>> Sent: Thursday, June 1, 2023 12:50
>> To: Zhang, Qi Z <qi.z.zhang@intel.com>; ferruh.yigit@amd.com
>> Cc: Guo, Junfeng <junfeng.guo@intel.com>; dev@dpdk.org; Rushil Gupta
>> <rushilg@google.com>
>> Subject: [PATCH] net/gve: fix bug in verify driver compatibility
>>
>> gVNIC requires physical address to be passed in the adminq command.
>> This was initially rightly pointed by ferruh.yigit@.
>> Fixed by passing 'driver_info_mem->iova'.
>
> For bug fixing, it is required to reference the id of the commit which introduced the bug.
> You can generate the required lines using the following git alias:
> ''' git config alias.fixline "log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %ae'" '''
> and then put the output of ''' git fixline <SHA> ''' into the commit message.
>
> And also be CCed to the stable@dpdk.org mailing list. Thanks!
>
> Regards,
> Junfeng
>
Hi Junfeng,
You are right, but for this case patch is not pulled to main repo yet,
and change is trivial, so I will fix it in next-net.
next prev parent reply other threads:[~2023-06-01 8:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 3:15 Rushil Gupta
2023-06-01 4:49 ` Rushil Gupta
2023-06-01 6:44 ` Guo, Junfeng
2023-06-01 8:35 ` Ferruh Yigit [this message]
2023-06-01 8:58 ` Guo, Junfeng
2023-06-01 8:26 ` Ferruh Yigit
2023-06-01 10:24 ` Ferruh Yigit
2023-06-01 16:32 ` Rushil Gupta
2023-06-02 14:49 ` Ferruh Yigit
2023-06-02 21:44 ` Rushil Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0acc50b-82b4-320f-0693-b3e2ac833eda@amd.com \
--to=ferruh.yigit@amd.com \
--cc=dev@dpdk.org \
--cc=junfeng.guo@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=rushilg@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).