From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DBA7E42C01; Thu, 1 Jun 2023 10:35:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6560040EF0; Thu, 1 Jun 2023 10:35:12 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2052.outbound.protection.outlook.com [40.107.220.52]) by mails.dpdk.org (Postfix) with ESMTP id 94AC8406B3 for ; Thu, 1 Jun 2023 10:35:10 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HGD/cR9Ikk8svpPWp6GGiKFVUjfs0a3s3Udn1r2aHjmT/mK4GGH/4rSVrLfKhkqeMR0/MeREIbV04kEklTP1rnaM/JYzKAXvQ8un9XuAD+vIDhvkeS3Tn57bqJCCVk/1/nEfvMOQFlImmI0PxoMhN5FdECxLprLTp+SN7JKQA5B395ZDm+hQeEqkyjB3FWq6aX0fLoBnQHwVrRj+P6PmDcm0pC006jVY68OUf1fwMUhDP6VqcsrXIJJtv7VFCF5IRMbOjUprXlQVRkW5JzQV8RxkahzbNNSJoPMiNfI+H8hIr1+YQvaxrLKiFDh/CWUJaZtPIUX751XkuQ1DDy0SDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zulBFLH2U3P0c6BjXt2hs4RyfipOBjskmjpdlIOXgs4=; b=Ytm8wU/wIZDcQKe7jlSMOp1R9VZ3YeniF9ZXr69iG73LZrxfFhlB9m4Gii27wIkz/abcPqrrc4PBu9T9f87Xgvpp3n78HbEaFHg1Rdq96G5oMLl6fOcu8OTKoqn8gb5UV4skcIujRJdFE3FUgpgARgyu1iCWo/Va6kR3ld+wOKXIwTZLFK2XNgy969dJ2EKpX/YKM55/ftMbXjkfUMG3Ub8B6e8/QFkRsQ5ZcCcGZj/rJYydhVXLUXdKxRXR+/x/gvigIBokI4skCAMjtbg2clnNCGbA/kN2y3i+tMCIzNHbwLaDVLoyqEUGUNleHglclK031MxZCOfSnERvgh8MFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zulBFLH2U3P0c6BjXt2hs4RyfipOBjskmjpdlIOXgs4=; b=Mipss6wf1lqWJMHwCmAJDQwgo9RtMq8fbFrEQw3qbDOAByEBAtaiMmo3a3j/HB2q6M04HH0WHhy2wUGYs26gOSFe/sOnTi3hbRSwVEpeBIo/SrODtdeMIEZI02VZZ2pvzZ0xc9H5RHfc8qEHxDr+AbvgwWBWf8vi9+POyrxiQv4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SJ0PR12MB5488.namprd12.prod.outlook.com (2603:10b6:a03:3ad::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.23; Thu, 1 Jun 2023 08:35:07 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a%4]) with mapi id 15.20.6433.022; Thu, 1 Jun 2023 08:35:07 +0000 Message-ID: Date: Thu, 1 Jun 2023 09:35:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH] net/gve: fix bug in verify driver compatibility Content-Language: en-US To: "Guo, Junfeng" , Rushil Gupta , "Zhang, Qi Z" Cc: "dev@dpdk.org" References: <20230601031513.453016-1-rushilg@google.com> <20230601044950.465926-1-rushilg@google.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0343.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::19) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SJ0PR12MB5488:EE_ X-MS-Office365-Filtering-Correlation-Id: e4169896-a4f5-49d6-e946-08db627b1a76 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nB7+fDeebWcFSM4sA0MNrJKTUDjxs9uflMPGnGdgvtc+61I5jdsS1HOkWHsjUZ8vtw/uIgTTlCGkxF4OSOXAi1iu8qhfNsibSm2kxpePc58bz0Uq6lDaQtd9f5G2AJ/mZQVqVzkY3/sNIzyOqm4PFU4Co7JqlKpErU14kTeLEp+zgpI6CB+DJ8rFerMqOxe8hOCi/wqDIAQaW+/HAFqf//OhoMSVG2jZc4rUO3jwuEpYzxu+ZMm7d6S90nvxmVSypnleqVfYUmwQtBJgotQbmU4/NwMJ3K4SMcZuWkuv8hAHul/TaWJ7tJykyQT5rylrzpvHIpyEm6pQoFfoYnelt0kzsTvJ0bH8jB81rhd8alYtj5NjP4BsmQhRSdS3FKdnaDZsPUd5GUrHDXvl3tkJnJdmCY/VAWk9HNrKCm+bJ6RdsRO4fyhl5s8cDefEnbgCqZt55/R3i9bZ6te4CoHORNwIIWZJmGsdE6LVHPROpYCosr6lKfv4qFNC0+CSuPQpduK+fRSnH4rJDyRoOsIaU6blwWGYVBRfHXJ/CuumN6kv30+dlLmzeA8ZA5hK/ojxs/gt8kRMQ3HO3qmSC3gfn+wSoJ9WLu9zqo594GT39yuqy3LOt1iZVnDUdfWx1EDDFGJ0CM+v/ETbGVsl6vcL9Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(366004)(396003)(346002)(376002)(39860400002)(136003)(451199021)(31686004)(83380400001)(26005)(6506007)(6512007)(53546011)(38100700002)(41300700001)(6666004)(186003)(6486002)(2616005)(478600001)(110136005)(4326008)(66946007)(66556008)(66476007)(316002)(5660300002)(8676002)(8936002)(44832011)(2906002)(31696002)(86362001)(15650500001)(36756003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TzVKU3JTdU5NSlVDNlBZbHFMMm96cTdteFV3NExwakpTZDA5aHI0YmpNWXQ5?= =?utf-8?B?VUh6OW9rV0gzajJsUkRucXhPUFN6dktzWlNNTTk0R1dJK0dMNkYwL0ZDYyt1?= =?utf-8?B?dlMwTThUMXl0eFN4YmJreGNST3BETlkwcHpyU0gySlFZU05VajRubDU5ejNs?= =?utf-8?B?cHI4SERkVXd4amJZcFdKdEhMa0VUNEVnNm1Yb3ZQL21yYnJtV2UvbXhtS0tl?= =?utf-8?B?THpCYmFkOW5ldEYwNzhyajVYMnBod1AvaHkxS2lodGZTTE9Icjd2TzJUakZx?= =?utf-8?B?K3liSHdkN083YXQ1ZnFqRC9CWVl6RHNZdkVBdTRzMitFRGMwWXB0RnFUREJl?= =?utf-8?B?US9yS3RJRUorTHppakJ3MU92dlhFREpNeHEwd1RiWW8vQVB5Q1JhV09ZVzZq?= =?utf-8?B?QVRUZHV6VStJcHhBY1ROeGhydHBGR3IwK2ZGYnphQ0tabkZBVUdaU0NJK1ds?= =?utf-8?B?WDg5REIwRjUwbWU2QlZUVEE0NXNmR1FkZmlMaEgzQ3lrZUhteXVpSFRqbjA4?= =?utf-8?B?R242T0VOOUpELzB6di9rV09QUWQ3UTBaN00yNWxzWnMyQlVBZEFhSXVUSXRm?= =?utf-8?B?OEtEN2wrd3ZYbHZiUi84OUNLQ0lvVmN6Sjd2U2ttVHMvT21vTkZIOGhDMEFS?= =?utf-8?B?dVNDTlN2Z3JheDcrSmVFNTB3aDRSUkt4RHdlTk1ycWVzZ2txcHFPZVM3SWho?= =?utf-8?B?cDNkZEdlaUFUUS82T21ETU4vZExnRG5uRHRmR2lrZTZGNlBncWY0QTA3TXRG?= =?utf-8?B?ajlDNjh6Z3o2Q1BEZGdQY2swYVB2RHJqUGlBb3Y1dnpySUlabkpvc0VwTko2?= =?utf-8?B?a2JvRFZCZUtPbGlpR2hOSDhyUzBCY2ZlS2VxeEYzYWZSMVNXOVdPRFlCeUZR?= =?utf-8?B?QTRFaWNlMzZrOEtQSWo5Skh3NGxSTUZDdlV2WFdFT3JuWUY3WGtZTVN3WUhu?= =?utf-8?B?VEhwa29lTDl4VUw5cXpVK2ZuNk1lZnhQSU9ZRWZYU3JOOU5WenVPK29FRVg1?= =?utf-8?B?c1NYbEcvNjNMWEM2VUU5VTN2eUY2bWY4cklOVlM1SjdVKzZJSXhkT2w2VTdT?= =?utf-8?B?UHYxV2tsa21aTVBUdVpqNDNiZmVVdTNEaEE3ZkpPSTFqLzU0cmwyUDRra25N?= =?utf-8?B?VTdFVTZqNVZXMnd0bGhnSmx5bmNrOW1iZW5PSmo3U0hCWmlzUlRlcjMvcmM1?= =?utf-8?B?eTN6bnYxM29JejlhMzRpTkpLRzVYRkpPMXRhWDkxbWx6dUNXU3B2UWp6NVVZ?= =?utf-8?B?OXFZdzNOUGZjTW10aE9zblYvVkFkUVpZOFo0YURLeW41V1p3OUNHcDhnaW9x?= =?utf-8?B?ZmJ5cFV0RDA0QlA3TGFyRFkvK1E2QUVieVN4MHdKUDRKeTBhdVFzZkZLZmt4?= =?utf-8?B?eGNackJyRzJiUm8xRXAxN25ob1lkZjA2S3hSemtlMGxzUFZmVGRPWmZpY0NC?= =?utf-8?B?bFpwQ09rRHFGZVgvdE1IVG5mRXE3SDZKaU9pN1VZWjliY2NiK2JSNWtIOEhH?= =?utf-8?B?WTR6M1orY2hNNFRtTWtTVVM0bFhQdExoOEJhZWlqK1A1Q3ZtYllHYXh1QzBm?= =?utf-8?B?L3VzcjVwVy9lb1hvb3RMeHFlb2JibFpoUHJTaXU5a2NKMnYrallHMTFHRVlj?= =?utf-8?B?M3NCUnp3MytGanFvWHRLTUoxa1pPdmZxU0Y2clgzWVowSU9pZ2xOQmozUmll?= =?utf-8?B?aHV6RFFYaTcvOWp6MDRKTjI1MC9hTjFqQmJabi81Z1YzZ0wvN0ZZamxrbHNU?= =?utf-8?B?NW9rMFVRMldSMW10UTVzUUtqL1p6WmpBYkhLNWtXcjd6ckJLbTJRZ2w5dGxk?= =?utf-8?B?NzZnNnJBKzRBRjRaZHpjb0x1OGdPL0NBL3JYK0lKQ0VjYjJDWWg5WUVIbVJV?= =?utf-8?B?T3U1Qit6SC8xakhxVlFXQzRpYUpQdmNSeVZGR2RaOGVJYnhMRU5QOVRkTUJv?= =?utf-8?B?VGt5SHo5a0FFbnBmRkJSaXNUZnkwWG53dXNheUo0U0J5VkxjWVdiN21XVGNp?= =?utf-8?B?OTdyZHF0MU1HZG5ucXZMKzViR2NRd0ZtWG1FOHVWS2FVYlBlSzhpejlpOW83?= =?utf-8?B?cXh6LzZXWWV1d3B6YXdieWZDbDlrMjF5cmtlM2k1aVZ4NzVjNHFLQ0RGenJ2?= =?utf-8?Q?h+3dpu22TZhDoaN0bARSPVEM1?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: e4169896-a4f5-49d6-e946-08db627b1a76 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2023 08:35:06.9772 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /69QeLZXedfNzPzYrHfRrVjQGlu77SabzIBBEY0PtYIOwdSFY6iwz+coizdV9le+ X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5488 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/1/2023 7:44 AM, Guo, Junfeng wrote: > > >> -----Original Message----- >> From: Rushil Gupta >> Sent: Thursday, June 1, 2023 12:50 >> To: Zhang, Qi Z ; ferruh.yigit@amd.com >> Cc: Guo, Junfeng ; dev@dpdk.org; Rushil Gupta >> >> Subject: [PATCH] net/gve: fix bug in verify driver compatibility >> >> gVNIC requires physical address to be passed in the adminq command. >> This was initially rightly pointed by ferruh.yigit@. >> Fixed by passing 'driver_info_mem->iova'. > > For bug fixing, it is required to reference the id of the commit which introduced the bug. > You can generate the required lines using the following git alias: > ''' git config alias.fixline "log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %ae'" ''' > and then put the output of ''' git fixline ''' into the commit message. > > And also be CCed to the stable@dpdk.org mailing list. Thanks! > > Regards, > Junfeng > Hi Junfeng, You are right, but for this case patch is not pulled to main repo yet, and change is trivial, so I will fix it in next-net.