From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id 3A8431B39F for ; Fri, 19 Apr 2019 14:42:55 +0200 (CEST) Received: by mail-wr1-f68.google.com with SMTP id h4so6822567wre.7 for ; Fri, 19 Apr 2019 05:42:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=zMUkwY3HR2FK9+rJ0UvbISgus3z8DxPlKxrU+HcUisA=; b=sCaB+SI/BSXS/pcCop2iyAuoLdH/8NKiPkAJ0KcoPpd1NAHheljSzyx8bzH6f4N9PV +MT7rsIpSG+RHTG10XIg8tNkm8BZ5r89dVkGKs0HhZKelIkNVG1ecu4MmEht8SycTKrX El70pl/quoOpsirjzGXrxre5gftLUr7y7sStO7XHSGdokTA/I/s2wiXfhigimbgIacnn 014m3mLfd9CvIXvxubLegrN7kRJEeN1AyiFqEnsGDX28Q70OAL0bKF+XmM0uOVRVkNkN t43ZScfS4mo6dl9u2RjYrhDV/N62RrH0d7A/0hksd4m6JfMCZKVhF/AftjFGn9lxXRBl N+9g== X-Gm-Message-State: APjAAAUl8KriF37BcOyVa/rxnQRYTpEMnwpQ83gTWl2q5EnjTyN0iOE4 r5/HtXes3iKRmuYYjDV1p+g= X-Google-Smtp-Source: APXvYqzpYBTho8peVoCj0sQG7PHltjEBKiek7v8DoI49kQU5q7eaQnLXY9MijgaTdoG+8LdxrFWucg== X-Received: by 2002:adf:f1ce:: with SMTP id z14mr2973885wro.152.1555677774777; Fri, 19 Apr 2019 05:42:54 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id 67sm4568113wmz.41.2019.04.19.05.42.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 19 Apr 2019 05:42:53 -0700 (PDT) Message-ID: From: Luca Boccassi To: Bruce Richardson , thomas@monjalon.net Cc: dev@dpdk.org, David Marchand Date: Fri, 19 Apr 2019 13:42:52 +0100 In-Reply-To: <20190419120449.29883-1-bruce.richardson@intel.com> References: <20190419120449.29883-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] devtools/test-meson-builds: fix support for plain bourne shell X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Apr 2019 12:42:55 -0000 On Fri, 2019-04-19 at 13:04 +0100, Bruce Richardson wrote: > The pipefail option is not supported in /bin/sh, just in bash/ksh and > similar shells - which means it's there by default on most Linux > distros > but not on e.g. FreeBSD. Therefore we check for it's presence before > setting the option, and if it's missing, we upgrade verbosity level > if > needed to ensure we never hide any build failures. >=20 > Signed-off-by: Bruce Richardson < > bruce.richardson@intel.com > > > --- > This patch is a replacement for the previous patch: "fix support for > FreeBSD" [1], which was an incorrect/incomplete fix. >=20 > [1] > http://patches.dpdk.org/patch/52468/ >=20 > --- > devtools/test-meson-builds.sh | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) Acked-by: Luca Boccassi --=20 Kind regards, Luca Boccassi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 1FF30A00E6 for ; Fri, 19 Apr 2019 14:42:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D94BD1B5FD; Fri, 19 Apr 2019 14:42:55 +0200 (CEST) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id 3A8431B39F for ; Fri, 19 Apr 2019 14:42:55 +0200 (CEST) Received: by mail-wr1-f68.google.com with SMTP id h4so6822567wre.7 for ; Fri, 19 Apr 2019 05:42:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=zMUkwY3HR2FK9+rJ0UvbISgus3z8DxPlKxrU+HcUisA=; b=sCaB+SI/BSXS/pcCop2iyAuoLdH/8NKiPkAJ0KcoPpd1NAHheljSzyx8bzH6f4N9PV +MT7rsIpSG+RHTG10XIg8tNkm8BZ5r89dVkGKs0HhZKelIkNVG1ecu4MmEht8SycTKrX El70pl/quoOpsirjzGXrxre5gftLUr7y7sStO7XHSGdokTA/I/s2wiXfhigimbgIacnn 014m3mLfd9CvIXvxubLegrN7kRJEeN1AyiFqEnsGDX28Q70OAL0bKF+XmM0uOVRVkNkN t43ZScfS4mo6dl9u2RjYrhDV/N62RrH0d7A/0hksd4m6JfMCZKVhF/AftjFGn9lxXRBl N+9g== X-Gm-Message-State: APjAAAUl8KriF37BcOyVa/rxnQRYTpEMnwpQ83gTWl2q5EnjTyN0iOE4 r5/HtXes3iKRmuYYjDV1p+g= X-Google-Smtp-Source: APXvYqzpYBTho8peVoCj0sQG7PHltjEBKiek7v8DoI49kQU5q7eaQnLXY9MijgaTdoG+8LdxrFWucg== X-Received: by 2002:adf:f1ce:: with SMTP id z14mr2973885wro.152.1555677774777; Fri, 19 Apr 2019 05:42:54 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id 67sm4568113wmz.41.2019.04.19.05.42.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 19 Apr 2019 05:42:53 -0700 (PDT) Message-ID: From: Luca Boccassi To: Bruce Richardson , thomas@monjalon.net Cc: dev@dpdk.org, David Marchand Date: Fri, 19 Apr 2019 13:42:52 +0100 In-Reply-To: <20190419120449.29883-1-bruce.richardson@intel.com> References: <20190419120449.29883-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] devtools/test-meson-builds: fix support for plain bourne shell X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190419124252.RMk0fa1aJxQ-AO5kDER_HA0ZfrJjWTlBnR-AsQMb1uY@z> On Fri, 2019-04-19 at 13:04 +0100, Bruce Richardson wrote: > The pipefail option is not supported in /bin/sh, just in bash/ksh and > similar shells - which means it's there by default on most Linux > distros > but not on e.g. FreeBSD. Therefore we check for it's presence before > setting the option, and if it's missing, we upgrade verbosity level > if > needed to ensure we never hide any build failures. >=20 > Signed-off-by: Bruce Richardson < > bruce.richardson@intel.com > > > --- > This patch is a replacement for the previous patch: "fix support for > FreeBSD" [1], which was an incorrect/incomplete fix. >=20 > [1] > http://patches.dpdk.org/patch/52468/ >=20 > --- > devtools/test-meson-builds.sh | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) Acked-by: Luca Boccassi --=20 Kind regards, Luca Boccassi