From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DCE3FA04B6; Thu, 17 Sep 2020 10:17:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BB29D1D583; Thu, 17 Sep 2020 10:17:09 +0200 (CEST) Received: from baidu.com (mx24.baidu.com [111.206.215.185]) by dpdk.org (Postfix) with ESMTP id 0A9AE1D581 for ; Thu, 17 Sep 2020 10:17:08 +0200 (CEST) Received: from BJHW-Mail-Ex16.internal.baidu.com (unknown [10.127.64.39]) by Forcepoint Email with ESMTPS id 3FE8854E87FAF41727A2; Thu, 17 Sep 2020 16:17:02 +0800 (CST) Received: from BJHW-Mail-Ex13.internal.baidu.com (10.127.64.36) by BJHW-Mail-Ex16.internal.baidu.com (10.127.64.39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Thu, 17 Sep 2020 16:17:02 +0800 Received: from BJHW-Mail-Ex13.internal.baidu.com ([100.100.100.36]) by BJHW-Mail-Ex13.internal.baidu.com ([100.100.100.36]) with mapi id 15.01.1979.006; Thu, 17 Sep 2020 16:17:02 +0800 From: "Li,Rongqing" To: "Loftus, Ciara" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 1/2] af_xdp: not return a negative value in af_xdp_rx_zc Thread-Index: AQHWjLDPzjL2VXvukkW2iQDXsdp3X6lsbviwgAANXUA= Date: Thu, 17 Sep 2020 08:17:01 +0000 Message-ID: References: <1600319386-24559-1-git-send-email-lirongqing@baidu.com> <8f957ea1b71346419be4f2a36bf9cbad@intel.com> In-Reply-To: <8f957ea1b71346419be4f2a36bf9cbad@intel.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.22.198.16] x-baidu-bdmsfe-datecheck: 1_BJHW-Mail-Ex16_2020-09-17 16:17:02:191 Content-Type: text/plain; charset="utf-7" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/2] af_xdp: not return a negative value in af_xdp_rx_zc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" +AD4- -----Original Message----- +AD4- From: Loftus, Ciara +AFs-mailto:ciara.loftus+AEA-intel.com+AF0- +AD4- Sent: Thursday, September 17, 2020 3:33 PM +AD4- To: Li,Rongqing +ADw-lirongqing+AEA-baidu.com+AD4- +AD4- Cc: dev+AEA-dpdk.org +AD4- Subject: RE: +AFs-dpdk-dev+AF0- +AFs-PATCH 1/2+AF0- af+AF8-xdp: not r= eturn a negative value in +AD4- af+AF8-xdp+AF8-rx+AF8-zc +AD4-=20 +AD4- +AD4- +AD4- +AD4- af+AF8-xdp+AF8-rx+AF8-zc should always return the number of rec= eived packets, and +AD4- +AD4- negative value will be as number of received packets, and confu= se the +AD4- +AD4- caller +AD4- +AD4- +AD4- +AD4- Fixes: d8a210774e1d (+ACI-net/af+AF8-xdp: support unaligned ume= m chunks+ACI-) +AD4- +AD4- Cc: stable+AEA-dpdk.org +AD4- +AD4- Signed-off-by: Li RongQing +ADw-lirongqing+AEA-baidu.com+AD4- +AD4- +AD4- --- +AD4- +AD4- drivers/net/af+AF8-xdp/rte+AF8-eth+AF8-af+AF8-xdp.c +AHw- 2 +-= - +AD4- +AD4- 1 file changed, 1 insertion(+-), 1 deletion(-) +AD4-=20 +AD4- Hi, +AD4-=20 +AD4- Thank you for the patch. The same fix was submitted and accepted into= the +AD4- next-net tree a few weeks ago: +AD4- http://git.dpdk.org/next/dpdk-next-net/commit/?id+AD0-e85f60b4e282695= ca0e457 +AD4- dc1ad21479b4bd7479 +AD4- It should hopefully hit the main tree soon. +AD4-=20 Thanks ,sorry for noise -Li