From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F3C6243C0D; Tue, 27 Feb 2024 18:26:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CA09E40279; Tue, 27 Feb 2024 18:26:20 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by mails.dpdk.org (Postfix) with ESMTP id 869CD40150 for ; Tue, 27 Feb 2024 18:26:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709054780; x=1740590780; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=zpTgUP2ntHLjSHLs99sCM+nnFJCTXMDe0neKFt9XnHY=; b=OoQ5IrP86Um965urUMEI5Vs8iVWCrwA8xXKG6pxWQ7UGSOz3DocKuutn tAhfxUmtmHpcyH8rwN6HdBjBNFe24y+JAfci/RV6FsddD8X2HZTwg2wSi hBCx9owyHRzMz0T7y6hVXvBcmSdmUlGSjvwyh/cgSQU/xMEpR06P5jrxp QCZXoC3P7ewG7hDIR0KptURIOCUXx2jI/piltTs6Mm2Asymajf9Xb0iYx zOTeX41RycOSuIPOZKa5C+weqm87xQsKJmFC7EgkauHA7/f3r58vdS6xx nxDijTgAfIUGmERA0SxS7DdBxW38Ij7jB6n+WkjU6f1lMiJpUETpgsJeJ w==; X-IronPort-AV: E=McAfee;i="6600,9927,10996"; a="14850054" X-IronPort-AV: E=Sophos;i="6.06,188,1705392000"; d="scan'208";a="14850054" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2024 09:26:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,188,1705392000"; d="scan'208";a="7162115" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orviesa009.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 27 Feb 2024 09:26:13 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 27 Feb 2024 09:26:12 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 27 Feb 2024 09:26:12 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 27 Feb 2024 09:26:12 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 27 Feb 2024 09:26:12 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LIN6FGkhYzabICw0Fhr2znNfi2Rw3ig5+JbFO2HXNIgUX1bHhYlbJtj7fSfIgg0nwZWswz2XhNc+0/vveBV2R5Yyd+8M27QiUtKpOsVQdRu16L4oQyUBZY1yY5rdLmy93nPgUWWIOX8MSpQtIvA9Xc3pFFkLnvTN8/qvwcrfWhQ2xJ/3R9zQb0kmNz0A/4PrfXNCYKYR8xgUMFvxGvwqVBW3u5l++SzTMLl/leMN+LUB4llHHtGAimQ1RFTgbT8xOGsWxnpvSrVg7ZImUI14dVl9T6hL0nuhyAbceRiV1r9XQunoxpox5F57+EUfJSS2sr0tjw0VbFhveUVllGUkhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cU+Oo8TKGY055DUdyG1shZs0JuCrfQYUjFjpnDBtoJM=; b=bWRKfGT/FOkjhCThWQxrHWOaAFCn2xnIUUMfT1yq3LiyHnwZoMsYXIktAfY2ntLV/rBFPMr4ZyNnkGAuVXx9qHlUVx17HiYTa1UkZxkW/kd96cYER8y3aZAJYrpISjfDQGNvS/+QkxVbY/B6QGyI3zNbxHOWL2GI3PiDbiQKnzdgHPOOwoRniGI20Sa8vMVBkSvIdCUX3o3e8+Um0SccqEReJzoKhaK61q5eVkbtfw4gLwHKM9KTAPMNE8TeSorPJJxjNA9LOdwhPyhLuenQtBNEiLzNRx7B0LPHxl5nYJSFjRebwx3/q6RdI5s+b8l85mJonx+B7ByKkdR86XCjtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SJ0PR11MB5772.namprd11.prod.outlook.com (2603:10b6:a03:422::8) by BN9PR11MB5292.namprd11.prod.outlook.com (2603:10b6:408:119::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.23; Tue, 27 Feb 2024 17:26:09 +0000 Received: from SJ0PR11MB5772.namprd11.prod.outlook.com ([fe80::fc4:cc9e:c910:f4b9]) by SJ0PR11MB5772.namprd11.prod.outlook.com ([fe80::fc4:cc9e:c910:f4b9%2]) with mapi id 15.20.7339.024; Tue, 27 Feb 2024 17:26:09 +0000 Message-ID: Date: Tue, 27 Feb 2024 17:26:06 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net/ixgbevf: fix RSS init for x550 nics Content-Language: en-US To: , CC: References: <20240215133145.181302-1-edwin.brossette@6wind.com> From: "Medvedkin, Vladimir" In-Reply-To: <20240215133145.181302-1-edwin.brossette@6wind.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DUZPR01CA0170.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b3::28) To SJ0PR11MB5772.namprd11.prod.outlook.com (2603:10b6:a03:422::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR11MB5772:EE_|BN9PR11MB5292:EE_ X-MS-Office365-Filtering-Correlation-Id: d5072ca0-7004-45a3-19b8-08dc37b93015 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wrS8QnHyXCTG0Pva1lAorA0TpGrQ36h0EUwKLZq25BoVjeW2PsYgcF21ubLCxO/7//046M1kSCek/IpF8c45T/soHlg+H+3ewsLaJSwrV3Snc9zGpClZ7dmO542qzM5SKX9p8PBcN7HR6+VZtUGMKRJWnG44keR+VFQs8zYUdzOYcOlxPK3PwIHT/l/fZhR+YfDOmR/hIBWXVkcGHgSOmEW+QQttup439TmE8N870PL5WzFjHc4E6thbdadexCFRrW1m61BtLEHFZ7nEuKF2PnRJkhL0b1lVG05DpMMQH5RergduPRIl8Ao38ajcVA668+lY/9tUeXi5qamocwnqbwnCi6hnwewdjl9VVlxZ0S4qDrEbueU/lM9UayE7Bt7tNvbncmrAe3reDavajdiFNLq4JidssM3eetVmIx9t394N0CttulBcahlBhWyw6yQbFTsz7Up+UR5EfZCCK56oR0VOYcTBATqJrtURFFJy1BvPmdEFwreWi/+mEjri1Es9ZSJDBkpZ41zil+FZWOtypb2xT6qvRcnGHYu4tWYXzo/qt6fgDXHrnoXoOW2rvIjb+dxynwVtpysvLpVRjoeC5c6XbSu+ca8fnpTl/6VEEEP6kcSn/TbxOegUPeWeHJfKKnfb9GEm1f/0oEmC1pZcPg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB5772.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OE1MTG9JeTVUTjMvL3ZXdkpuenRRMXdpbm5wYXpXa1JtT2ZPNGN0bkdENDdT?= =?utf-8?B?ZjBxb25MSTI1QXd4VFl4TjZiUTJVMjl3MDM5blZFUTdRcVRiQ2prN2NBZE15?= =?utf-8?B?ZlIveU1BWTFLZ0p6SHRMQ2tPQkd2WnVGSENuWHo3L0YzMGs0S3B5SE1oc3RX?= =?utf-8?B?UEdkcTVWYTdPWVRqdjVLcDBVWXFPTlpnWXIwR256WHd6NWFjSndYY1pLdHpU?= =?utf-8?B?WG9JbHd6bFlZM3NnUmJnaktITGF6YTk1SXo3NVhHaXJnRVA4WHdIQU1UTmNl?= =?utf-8?B?WndLcTdVMmN0cHBrdWJvNXJ2bjFMK05Gb0QyejNQOVZnZFNEVmhFNFQwUkNh?= =?utf-8?B?OWJlRFplNjNENWJKZjhQc2ZZOTlDcmtmRHo4bGo2TEEvVEhUazNvK1ZlUVlL?= =?utf-8?B?SWVPNmdlWjQ2M3JreFJ1U2hvcHo4RlJwTDNIVDlib1lScDErOXl1NWlTWWJp?= =?utf-8?B?WlFzU25raVF5TGtCRDBSTld4SnE4bEFVN0x0V0RTcHZ4SFozZ1BsWkRYenRn?= =?utf-8?B?dFpzV0VYdVpDcFQ2V3FKSUx5RS9qczNiMWxwcTkrSjFDTS9oNmhYb0hPZkk1?= =?utf-8?B?bHhoZkNIQW5SZ2NCY2M3MGVIeFhDb1JucHRGcUNrSzhlT0dkSnhjVVFHNHR5?= =?utf-8?B?aXAwWmxaZjBmZEhIOFpWUzEzUmRwbnNmUytJaWFTRWhMeTZ6UHVGVFNEY0tl?= =?utf-8?B?OU1XdFVhRGtUN01CZ3lIV0NpSVBsSGQ5ZUNvUk53b3UvMHRyU0I1Wll5RWli?= =?utf-8?B?dVNzeG9WSGV5dWJacjc2TlNJdWVkN3MrUlAvN254T1drTkFZRjF0eE5wOEZ0?= =?utf-8?B?d01NUU91ZXZEa1Nka3Z3MCsybEtMYzdBb3BRS0psajNmdDdySUQyTGVnS2tu?= =?utf-8?B?TlkrcTMzRjRvOHRjRjM1dnh4bldVVURDR00zdWFVR1oydVEzRWk1YkVVSytP?= =?utf-8?B?SkNkb2lWald3QUZqMDF4WENIVDQvTFZIZGhQVVQyOVQzKzhYa0plLythRGo4?= =?utf-8?B?Nk1kZkNVdkxqZUZGWmI1SkRUTUlHdnJ4Zk1qeUlpVWljb0htSWViR1VNUUZD?= =?utf-8?B?bnJ1WEI3QWNaaG1RbHphUys4bnFtbnNNcjlmb21zWFluVmlMd1pwVk9TZVdF?= =?utf-8?B?L0x5MklrWG5JVUJqTEozR01scTdpSHlqUWNIcmQwcmx1Q2FFWDhYcUx2cTd6?= =?utf-8?B?ZmtGN2VxRkxKNytacjc1QzVwKzJ3bGpHTFBiQ25SWXdPTUJWLzNPdXVNbnp0?= =?utf-8?B?eXc0Ny90cnFHc1hqejY3RTdmUzVZTU9lUG5Dd1M5NlA3Znd3WFZGdEVma1Jz?= =?utf-8?B?Mi9HMFR0akZLR0dEREd3dzlwdkZFUVg5SjdPSldPdm1NcUhNODAwWEp6aUNn?= =?utf-8?B?Rk5RWWVXdjVFWEJXRDV0OXhXcWVuMHlzNE5TbFNXOEV5OWQ4MzgyaGpyZUdZ?= =?utf-8?B?dWNoQ1h3TjdpK0EwVUFRSjh4Zng4M01SVEZkRFZkOFltVEwwWmtieGNPYk9M?= =?utf-8?B?Mld5OGptVk5JSzB4b0h2SDd2Z1A2K25zNi9wdkFOYnMzOEx1WFFYMkQzVEl0?= =?utf-8?B?ZTBnTnNsT2tTZjhwUFo4SVJnV1ZXQXBPKzg1dzJQaGpwaVdTN1R4SWYwZWsy?= =?utf-8?B?RzZXdVRlMVlUK3JrYXJyK3B5bE5lak12c1VMRnc4S0p3Q3J1MjNGMGtnY3lO?= =?utf-8?B?eit4TTI5RzFOcGhma0dBbVRKTVp2MzQ2Szh4WFA4T29Ed1J0R1NZTWxSSWRO?= =?utf-8?B?WGNiRW85ZmhwMEJEYmZPSlZUMXFJbDJZT1BEWjFkd1dIUjdvTUFKdW4yRUZ6?= =?utf-8?B?dkVXcjFvV0NlUGUzdTAyejlrM2VDVTUxT1FGakxNNHBPWlpIOXhKWVhoVktE?= =?utf-8?B?Q0NnV1RJQ3pzd0JtcUNtRUtkd1VSTHJmQit1OG9SNkwyNkY4OU9nTitPVmZO?= =?utf-8?B?a0NMODFsNkxqTVdLellhZTBnME9xYlhNNnowbDFKNjFiUFlITGh3MTJJM1FL?= =?utf-8?B?ZFV0WEdTd3ByaFlNd1hmRTdKdW4vaU1ZTUpZSEk5MUdiSUp6NmFwMmZNVDYx?= =?utf-8?B?UHhOcUs1a3ZUR0NOTnZyZFRKTDFKcUEwTWpNem1KeEZiVVFsbjJ0NVhyTlpN?= =?utf-8?B?SGRhdVJvVHh1MFFOODlubkR1aW1TQXBlelc4SXY5MkVTamlBcFd4V0ZrY2ZG?= =?utf-8?B?eHc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: d5072ca0-7004-45a3-19b8-08dc37b93015 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5772.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2024 17:26:09.6979 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CK4VLse3uCdsGRibjNX03/n4nEmHcUkZ8uEDNimFsAFuPD9ZM5PDLarAnm+BAXqUfB0mNHbFD/VXO/teNBliZHa2Yr+3DBLbo5zItX70yv4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5292 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 15/02/2024 13:31, edwin.brossette@6wind.com wrote: > From: Edwin Brossette > > Different Intel nics with the igxbe pmd do not handle RSS in the same > way when working with virtualization. While some nics like Intel 82599ES > only have a single RSS table in the device and leave all rss features to > be handled by the pf, some other nics like x550 let the vf handle RSS > features. This can lead to different behavior when rss is enabled > depending on the model of nic used. > > In particular, it occurred that ixgbevf_dev_rx_init() do not initiate > rss parameters at device init, even if the multi-queue mode option is > set in the device configuration (ie: RTE_ETH_MQ_RX_RSS is set). Note > that this issue went unnoticed until now, probably because some nics do > not really have support for RSS in virtualization mode. > > Thus, depending on the nic used, we can we find ourselves in a situation > where RSS is not configured despite being enabled. This will cause > serious performance issues because the RSS reta will be fully zeroed, > causing all packets to go only in the first queue and leaving all the > others empty. > > By looking at ixgbe_reta_size_get(), we can see that only X550 nic > models have a non zero reta size set in vf mode. Thus add a call to > ixgbe_rss_configure() for these cards in ixgbevf_dev_rx_init() if the > option to enable RSS is set. > > Fixes: f4d1598ee14f ("ixgbevf: support RSS config on x550") > Signed-off-by: Edwin Brossette > --- > drivers/net/ixgbe/ixgbe_rxtx.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c > index 537aa2f68de8..0aa968f7e258 100644 > --- a/drivers/net/ixgbe/ixgbe_rxtx.c > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > @@ -5873,6 +5873,25 @@ ixgbevf_dev_rx_init(struct rte_eth_dev *dev) > IXGBE_PSRTYPE_RQPL_SHIFT; > IXGBE_WRITE_REG(hw, IXGBE_VFPSRTYPE, psrtype); > > + /* Initialize the rss for x550_vf cards if enabled */ > + switch (hw->mac.type) { > + case ixgbe_mac_X550_vf: > + case ixgbe_mac_X550EM_x_vf: > + case ixgbe_mac_X550EM_a_vf: > + switch (dev->data->dev_conf.rxmode.mq_mode) { > + case RTE_ETH_MQ_RX_RSS: > + case RTE_ETH_MQ_RX_DCB_RSS: > + case RTE_ETH_MQ_RX_VMDQ_RSS: > + ixgbe_rss_configure(dev); > + break; > + default: > + break; > + } > + break; > + default: > + break; > + } > + > ixgbe_set_rx_function(dev); > > return 0; Acked-by: Vladimir Medvedkin -- Regards, Vladimir