From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C972A0A0F; Wed, 3 Feb 2021 10:51:59 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F25752404A7; Wed, 3 Feb 2021 10:51:57 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id 4BA4A2404A5 for ; Wed, 3 Feb 2021 10:51:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612345916; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JoHHA2VpDAc0dYUgAb20e6gebo1/UKtJumPb0y+QbxE=; b=HEgKMTtRR6hwTdmNfIkbU1pwx1Cb2YWptdd1s2/6cOuyVD+pv4pLKbOBK3FamubYImebQ5 /t1UabdZyyBOcVErBBPsQeKNRFSgY9ruoiju9OcIBn//Yr5Q4PAw8SVT0sZXQ9Yeu+Z7sf V+CK/Ee62rqhHB2Y/1QEgnbi4Empy2w= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-512-mTwbdsLnOnOK3Z1ZK5ELgw-1; Wed, 03 Feb 2021 04:51:54 -0500 X-MC-Unique: mTwbdsLnOnOK3Z1ZK5ELgw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6D89A107ACE4; Wed, 3 Feb 2021 09:51:53 +0000 (UTC) Received: from [10.36.110.4] (unknown [10.36.110.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 23F1A62679; Wed, 3 Feb 2021 09:51:51 +0000 (UTC) To: Cheng Jiang , chenbo.xia@intel.com Cc: dev@dpdk.org, jiayu.hu@intel.com, yvonnex.yang@intel.com, yinan.wang@intel.com References: <20210131125617.53078-1-Cheng1.jiang@intel.com> <20210202061751.1614-1-Cheng1.jiang@intel.com> From: Maxime Coquelin Message-ID: Date: Wed, 3 Feb 2021 10:51:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210202061751.1614-1-Cheng1.jiang@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3] examples/vhost: remove async inflight packet counter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/2/21 7:17 AM, Cheng Jiang wrote: > Remove async inflight packet counter since there is no need to keep > tracking it. Increase MAX_ENQUEUED_SIZE to prevent packet segment number > tracking ring from being exhausted. Is that an optimization or a fix? If the former, let's move it to v21.05. > > Fixes: a68ba8e0a6b6 ("examples/vhost: refactor vhost data path") > > Signed-off-by: Cheng Jiang > --- > v3: fixed fixes commit id in git log > > v2: fixed a typo > > examples/vhost/ioat.h | 2 +- > examples/vhost/main.c | 10 +--------- > examples/vhost/main.h | 1 - > 3 files changed, 2 insertions(+), 11 deletions(-) > > diff --git a/examples/vhost/ioat.h b/examples/vhost/ioat.h > index 0a1dbb811..1aa28ed6a 100644 > --- a/examples/vhost/ioat.h > +++ b/examples/vhost/ioat.h > @@ -11,7 +11,7 @@ > > #define MAX_VHOST_DEVICE 1024 > #define IOAT_RING_SIZE 4096 > -#define MAX_ENQUEUED_SIZE 512 > +#define MAX_ENQUEUED_SIZE 4096 Basically, this the size of the ring size, correct? It might be further simplified then. > > struct dma_info { > struct rte_pci_addr addr; > diff --git a/examples/vhost/main.c b/examples/vhost/main.c > index e74fc8750..ca73e7086 100644 > --- a/examples/vhost/main.c > +++ b/examples/vhost/main.c > @@ -831,11 +831,8 @@ complete_async_pkts(struct vhost_dev *vdev) > > complete_count = rte_vhost_poll_enqueue_completed(vdev->vid, > VIRTIO_RXQ, p_cpl, MAX_PKT_BURST); > - if (complete_count) { > - __atomic_sub_fetch(&vdev->nr_async_pkts, complete_count, > - __ATOMIC_SEQ_CST); > + if (complete_count) > free_pkts(p_cpl, complete_count); > - } > } > > static __rte_always_inline void > @@ -878,8 +875,6 @@ drain_vhost(struct vhost_dev *vdev) > complete_async_pkts(vdev); > ret = rte_vhost_submit_enqueue_burst(vdev->vid, VIRTIO_RXQ, > m, nr_xmit, m_cpu_cpl, &cpu_cpl_nr); > - __atomic_add_fetch(&vdev->nr_async_pkts, ret - cpu_cpl_nr, > - __ATOMIC_SEQ_CST); > > if (cpu_cpl_nr) > free_pkts(m_cpu_cpl, cpu_cpl_nr); > @@ -1210,9 +1205,6 @@ drain_eth_rx(struct vhost_dev *vdev) > enqueue_count = rte_vhost_submit_enqueue_burst(vdev->vid, > VIRTIO_RXQ, pkts, rx_count, > m_cpu_cpl, &cpu_cpl_nr); > - __atomic_add_fetch(&vdev->nr_async_pkts, > - enqueue_count - cpu_cpl_nr, > - __ATOMIC_SEQ_CST); > if (cpu_cpl_nr) > free_pkts(m_cpu_cpl, cpu_cpl_nr); > > diff --git a/examples/vhost/main.h b/examples/vhost/main.h > index 2d6c05fd7..0ccdce4b4 100644 > --- a/examples/vhost/main.h > +++ b/examples/vhost/main.h > @@ -51,7 +51,6 @@ struct vhost_dev { > uint64_t features; > size_t hdr_len; > uint16_t nr_vrings; > - uint64_t nr_async_pkts; > struct rte_vhost_memory *mem; > struct device_statistics stats; > TAILQ_ENTRY(vhost_dev) global_vdev_entry; > -- > 2.29.2 >