From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2940C4236B; Thu, 12 Oct 2023 04:35:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 15DC7402E6; Thu, 12 Oct 2023 04:35:19 +0200 (CEST) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mails.dpdk.org (Postfix) with ESMTP id A30A340279 for ; Thu, 12 Oct 2023 04:35:17 +0200 (CEST) Received: from kwepemi500020.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4S5YZd56kRz1M9Cc; Thu, 12 Oct 2023 10:32:41 +0800 (CST) Received: from [10.67.121.175] (10.67.121.175) by kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Thu, 12 Oct 2023 10:35:15 +0800 Message-ID: Date: Thu, 12 Oct 2023 10:35:15 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v5 13/40] net/ena: check RSS hash algorithms To: Ferruh Yigit , , Michal Krawczyk , Shai Brandes , Evgeny Schemeilin , Igor Chauskin , Ron Beider CC: , , References: <20230908080030.3837515-1-haijie1@huawei.com> <20231011092805.693171-1-haijie1@huawei.com> <20231011092805.693171-14-haijie1@huawei.com> <911441a4-d94f-434b-8663-bb8e9d574392@amd.com> From: Jie Hai In-Reply-To: <911441a4-d94f-434b-8663-bb8e9d574392@amd.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.175] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemi500020.china.huawei.com (7.221.188.8) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2023/10/12 1:27, Ferruh Yigit wrote: > On 10/11/2023 10:27 AM, Jie Hai wrote: >> A new field 'algorithm' has been added to rss_conf, check it >> in case of ignoring unsupported values. >> >> Signed-off-by: Jie Hai >> --- >> drivers/net/ena/ena_rss.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/net/ena/ena_rss.c b/drivers/net/ena/ena_rss.c >> index d0ba9d5c0a14..06aff9f3bd49 100644 >> --- a/drivers/net/ena/ena_rss.c >> +++ b/drivers/net/ena/ena_rss.c >> @@ -398,6 +398,9 @@ static int ena_rss_hash_set(struct ena_com_dev *ena_dev, >> uint8_t *rss_key; >> int rc; >> >> + if (rss_conf->algorithm != RTE_ETH_HASH_FUNCTION_DEFAULT) >> + return -EINVAL; >> + >> if (rss_conf->rss_key != NULL) { >> /* Reorder the RSS key bytes for the hardware requirements. */ >> ena_reorder_rss_hash_key(hw_rss_key, rss_conf->rss_key, > > I can see in some drivers configure() ops is not updated, I assume these > are the ones don't have any RSS related config in it, it is not clear > still to add check, but I guess what you are doing is reasonable, I am > OK with this approach. > . It's true that these drivers support RSS configuration and check it in their own setup function instead of in dev_configure ops. Some drivers calls the setup function in dev_configure, and some in dev_start. It's better to check the configuration in these setup function for the latter case.