From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 15F154292F; Thu, 13 Apr 2023 08:30:10 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E01F740A84; Thu, 13 Apr 2023 08:30:09 +0200 (CEST) Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by mails.dpdk.org (Postfix) with ESMTP id B98434021F for ; Thu, 13 Apr 2023 08:30:07 +0200 (CEST) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4PxqRf5jzqzDt0J; Thu, 13 Apr 2023 14:29:18 +0800 (CST) Received: from [10.67.100.224] (10.67.100.224) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 13 Apr 2023 14:30:03 +0800 Subject: Re: [PATCH] dmadev: add tracepoints To: =?UTF-8?Q?Morten_Br=c3=b8rup?= , Kevin Laatz , Bruce Richardson CC: , References: <20230412024808.41339-1-fengchengwen@huawei.com> <98CBD80474FA8B44BF855DF32C47DC35D87864@smartserver.smartshare.dk> From: fengchengwen Message-ID: Date: Thu, 13 Apr 2023 14:30:03 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D87864@smartserver.smartshare.dk> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.100.224] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2023/4/12 19:00, Morten Brørup wrote: >> From: Chengwen Feng [mailto:fengchengwen@huawei.com] >> Sent: Wednesday, 12 April 2023 04.48 >> >> Add tracepoints at important APIs for tracing support. >> >> Signed-off-by: Chengwen Feng >> --- > ... >> +) >> + >> +RTE_TRACE_POINT( >> + rte_dma_trace_stats_get, > > This should be a fast path trace point. > For reference, ethdev considers rte_eth_stats_get() a fast path function. Emm, I think it should discuss more, and make it clear. The cryptodev and dmadev trace-points both make 'rte_xxx_trace_stats_get' as a slow path function. And it mainly refer to the fast path API (means if a API is fast path then make it as a fast-path trace-points). But the ethdev trace-points treats 'calls in loop function(such as rte_eth_trace_stats_get/rte_eth_trace_link_get/...)' as fast path trace-points. > >> + RTE_TRACE_POINT_ARGS(int16_t dev_id, uint16_t vchan, >> + struct rte_dma_stats *stats, int ret), >> + rte_trace_point_emit_i16(dev_id); >> + rte_trace_point_emit_u16(vchan); >> + rte_trace_point_emit_u64(stats->submitted); >> + rte_trace_point_emit_u64(stats->completed); >> + rte_trace_point_emit_u64(stats->errors); >> + rte_trace_point_emit_int(ret); >> +) >> + ... >> diff --git a/lib/dmadev/version.map b/lib/dmadev/version.map >> index 7031d6b335..4ee1b3f74a 100644 >> --- a/lib/dmadev/version.map >> +++ b/lib/dmadev/version.map >> @@ -1,6 +1,16 @@ >> EXPERIMENTAL { >> global: >> >> + # added in 23.07 >> + __rte_dma_trace_burst_capacity; >> + __rte_dma_trace_completed; >> + __rte_dma_trace_completed_status; >> + __rte_dma_trace_copy; >> + __rte_dma_trace_copy_sg; >> + __rte_dma_trace_fill; >> + __rte_dma_trace_submit; >> + > > Intuitively, I would suppose that the 23.07 functions should be listed after the 21.11 functions, not before. +1, will fix in v2 > >> + # added in 21.11 > > Good catch. > >> rte_dma_close; >> rte_dma_configure; >> rte_dma_count_avail; >> -- >> 2.17.1 > > > . >