From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7457E4339B; Wed, 22 Nov 2023 10:38:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 49572402CB; Wed, 22 Nov 2023 10:38:06 +0100 (CET) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id D6D334028C for ; Wed, 22 Nov 2023 10:38:02 +0100 (CET) Received: from dggpeml100024.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4SZx0Q5DK8zmXBt; Wed, 22 Nov 2023 17:34:30 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by dggpeml100024.china.huawei.com (7.185.36.115) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 22 Nov 2023 17:38:00 +0800 Subject: Re: [PATCH 1/2] usertools/rss: add driver abstractions To: Robin Jarry , Stephen Hemminger , Jerin Jacob CC: , , References: <20231023080710.240402-3-rjarry@redhat.com> <20231121083855.6ae8e362@hermes.local> <20231121090423.639655f4@hermes.local> <20231121092743.43f5a6e8@hermes.local> From: fengchengwen Message-ID: Date: Wed, 22 Nov 2023 17:37:59 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.161] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpeml100024.china.huawei.com (7.185.36.115) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2023/11/22 16:28, Robin Jarry wrote: > Stephen Hemminger, Nov 21, 2023 at 18:27: >> On Tue, 21 Nov 2023 22:51:19 +0530 >> Jerin Jacob wrote: >> > IMO, That may be too much of non-productive work to save a couple of >> > lines(seed array) of duplicate code between c and python. >> >> But the tool is incomplete right now, it doesn't cover all the drivers. > > I agree that having a standard API or mechanism for drivers to expose their default redirection table size and hash seed key would be nice. The script could have a dynamically generated section that is populated during the build based on selected drivers. > > However, it would make the python script dependant on it and it would not be a standalone tool anymore. This is not a blocking issue but something to keep in mind. The usertools/dpdk-pmdinfo.py will parse dpdk elf to get some information, We could do same thing in here. > > .