Re: [dpdk-dev] [PATCH] bbdev: add missing experimental tags

[Akhil Goyal <akhil.goyal@nxp.com>]

Hi David,

On 12/5/2018 2:27 AM, David Marchand wrote:
> Those two symbols are missing the experimental tag in the library
> header.
> Because of this, a user can try to call this symbol without being aware
> this is an experimental api (neither compilation nor link warning).
>
> Fixes: 4935e1e9f76e ("bbdev: introduce wireless base band device lib")
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>   lib/librte_bbdev/rte_bbdev_op.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_bbdev/rte_bbdev_op.h b/lib/librte_bbdev/rte_bbdev_op.h
> index 83f62c2..c9200b5 100644
> --- a/lib/librte_bbdev/rte_bbdev_op.h
> +++ b/lib/librte_bbdev/rte_bbdev_op.h
> @@ -459,7 +459,7 @@ struct rte_bbdev_op_pool_private {
>    *   Operation type as string or NULL if op_type is invalid
>    *
>    */
> -const char*
> +__rte_experimental const char *
>   rte_bbdev_op_type_str(enum rte_bbdev_op_type op_type);
>   
>   /**
> @@ -482,7 +482,7 @@ struct rte_bbdev_op_pool_private {
>    *   - Pointer to a mempool on success,
>    *   - NULL pointer on failure.
>    */
> -struct rte_mempool *
> +__rte_experimental struct rte_mempool *
>   rte_bbdev_op_pool_create(const char *name, enum rte_bbdev_op_type type,
>   		unsigned int num_elements, unsigned int cache_size,
>   		int socket_id);
I can see that there are other APIs as well which are not marked as 
experimental like rte_bbdev_dec_op_alloc_bulk
rte_bbdev_dec_op_free_bulk, rte_bbdev_enqueue_enc_ops etc.

-Akhil