From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D83D3A0501; Thu, 5 May 2022 22:01:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 891824068A; Thu, 5 May 2022 22:01:15 +0200 (CEST) Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [170.10.129.74]) by mails.dpdk.org (Postfix) with ESMTP id 5D93D4014F for ; Thu, 5 May 2022 22:01:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651780873; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XcxgfdSGbkC9X9HK3CNPfBzoh1fl9bQySK3cBzqNcxU=; b=exz+QBOi75Sadd5Y0wld7NSjsIdvNJcCi32dYoFyATrIsE5nvMO2lAMpazV/EuUFkWoRhC 1Cma6HdTUn7tAnutEKwQ2LyXzORddGUeV1Ty9Eq7wAWQrmFxnsKO5eMYh+T5LMFWkbHAkr T5PgHeb8WVsU+mj8o4xHbyHqa3rIRS8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-193-p5QesdA8PP-k5g_YhUjSMw-1; Thu, 05 May 2022 16:01:12 -0400 X-MC-Unique: p5QesdA8PP-k5g_YhUjSMw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6F24D811E75; Thu, 5 May 2022 20:01:12 +0000 (UTC) Received: from [10.39.208.18] (unknown [10.39.208.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AC0A9416171; Thu, 5 May 2022 20:01:11 +0000 (UTC) Message-ID: Date: Thu, 5 May 2022 22:01:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH v2 5/7] vdpa/mlx5: cache and reuse hardware resources To: "Xueming(Steven) Li" , "dev@dpdk.org" Cc: Matan Azrad , Slava Ovsiienko References: <20220224132820.1939650-1-xuemingl@nvidia.com> <20220224155101.1991626-1-xuemingl@nvidia.com> <20220224155101.1991626-6-xuemingl@nvidia.com> From: Maxime Coquelin In-Reply-To: X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Xueming, On 4/25/22 15:28, Xueming(Steven) Li wrote: > Hi Maxime, > > Thanks for the suggestion, I'll send out a new version. Ok, if you sent it early next week, it could be part of next week's PR. Thanks, Maxime > Regards, > Xueming Li > >> -----Original Message----- >> From: Maxime Coquelin >> Sent: Wednesday, April 20, 2022 11:03 PM >> To: Xueming(Steven) Li ; dev@dpdk.org >> Cc: Matan Azrad ; Slava Ovsiienko >> Subject: Re: [PATCH v2 5/7] vdpa/mlx5: cache and reuse hardware resources >> >> >> >> On 2/24/22 16:50, Xueming Li wrote: >>> During device suspend and resume, resources are not changed normally. >>> When huge resources allocated to VM, like huge memory size or lots of >> >> "When huge resources were allocated" >> >>> queues, time spent on release and recreate became significant. >>> >>> To speed up, this patch reuse resoruces like VM MR and VirtQ memory if >> >> "reuses resources" >> >>> not changed. >>> >>> Signed-off-by: Xueming Li >>> --- >>> drivers/vdpa/mlx5/mlx5_vdpa.c | 11 ++++- >>> drivers/vdpa/mlx5/mlx5_vdpa.h | 12 ++++- >>> drivers/vdpa/mlx5/mlx5_vdpa_mem.c | 27 ++++++++++- >>> drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 73 +++++++++++++++++++++-------- >>> 4 files changed, 99 insertions(+), 24 deletions(-) >>> >> >> Reviewed-by: Maxime Coquelin >> >> Thanks, >> Maxime >