From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 8C18E108F for ; Tue, 17 Jan 2017 20:25:06 +0100 (CET) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP; 17 Jan 2017 11:25:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,245,1477983600"; d="scan'208";a="49788844" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38]) ([10.237.220.38]) by orsmga004.jf.intel.com with ESMTP; 17 Jan 2017 11:25:04 -0800 To: Jay Rolette References: <20170117180147.11247-1-ferruh.yigit@intel.com> <20170117180147.11247-2-ferruh.yigit@intel.com> Cc: DPDK From: Ferruh Yigit Message-ID: Date: Tue, 17 Jan 2017 19:25:03 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/2] config: disable KNI ethtool by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jan 2017 19:25:07 -0000 On 1/17/2017 7:00 PM, Ferruh Yigit wrote: > On 1/17/2017 6:44 PM, Jay Rolette wrote: >> >> On Tue, Jan 17, 2017 at 12:01 PM, Ferruh Yigit > > wrote: >> >> KNI ethtool support (KNI control path) is not commonly used, >> and it tends to break the build with new version of the Linux kernel. >> >> KNI ethtool feature is disabled by default. KNI datapath is not effected >> from this update. >> >> It is possible to enable feature explicitly with config option: >> "CONFIG_RTE_KNI_KMOD_ETHTOOL=y" >> >> Signed-off-by: Ferruh Yigit > > >> >> >> Is there a test case somewhere to detect when it gets broken or is the >> intent to let it bit-rot unless someone enables that option and >> subsequently discovers it broken? >> >> I know we don't do this for every config option, but given the fact that >> this tends to get broken frequently, it seems riskier. > > Agree this has risk to be forgotten/badly broken, I am sharing same concern. > > But what happening was, even we fix DPDK for latest kernel, after DPDK > released, DPDK compilation sometimes broken with new coming kernels. > Since DPDK already released there is way to fix this, and this sometimes correction: ... there is _no_ way to fix this ... > hit people who won't use KNI ethtool at all. > > KNI ethtool needs to be taken care by its users. > >> >> Jay >> >> >> --- >> config/common_linuxapp | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/config/common_linuxapp b/config/common_linuxapp >> index d4c4f0c..2483dfa 100644 >> --- a/config/common_linuxapp >> +++ b/config/common_linuxapp >> @@ -38,7 +38,6 @@ CONFIG_RTE_EXEC_ENV_LINUXAPP=y >> CONFIG_RTE_EAL_IGB_UIO=y >> CONFIG_RTE_EAL_VFIO=y >> CONFIG_RTE_KNI_KMOD=y >> -CONFIG_RTE_KNI_KMOD_ETHTOOL=y >> CONFIG_RTE_LIBRTE_KNI=y >> CONFIG_RTE_LIBRTE_VHOST=y >> CONFIG_RTE_LIBRTE_PMD_VHOST=y >> -- >> 2.9.3 >> >> >