From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B8978A0C41; Fri, 29 Oct 2021 19:40:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 61D28410FA; Fri, 29 Oct 2021 19:40:27 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 58AD440395 for ; Fri, 29 Oct 2021 19:40:25 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10152"; a="294176060" X-IronPort-AV: E=Sophos;i="5.87,193,1631602800"; d="scan'208";a="294176060" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Oct 2021 10:40:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,193,1631602800"; d="scan'208";a="495797717" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga007.fm.intel.com with ESMTP; 29 Oct 2021 10:40:23 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 29 Oct 2021 10:40:23 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 29 Oct 2021 10:40:23 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.49) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 29 Oct 2021 10:40:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ms5BW5RAy/1V1dSlTyz/tylPTn56Sd7QERARUbLdSxxxQAZIToneMnLHyzjEVra0ghFF3gqUZUJyCoguZXXpuTE8+9ticFwxLrFoQqvIYFc0xEY6p2GANy3SFXXPgyUcFPXr4uKN7SgCsy4lDPfIkh7/zNgQ3i9f9rw10l2tu2e530gXmtr87MwLtG4wqnOjfuh9skj0+cS8g4OCxgsC4Jx5Um0T8KyfraCRk2uxk9gIB2WlFBdmuiMYeNh1s1ti+qUAGFpl7vVGVvqpD3pjfW6MU7u/zlUXdcmnBINE9RhiN0GyASukdQAlknyqv0p5jJ21Tcj0wXCqK5KYggh0qQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R5eX0Ndhv1fO2am2eB49/l2Y99h8Je5lwf3OxwHjGWI=; b=Ma9P9GhBVOPTvJMclD/kjIn2V1Q4yZPWGnpltmzr3R2OpxPXe0jpGzJmbr93si5BCpPQOnNiLR1+NEHHftlTOsxyvdCAa48Mgq/u1s+t4CSngMiy6i/037ZTN2Q5lUucgwctrJmHmbrW13dJuFBs2gh74p/DJwCDNoDSp34H2HMPPdxVoy408tAszi9kUd9SNvnpfyQtFS3QE7N8PCARalhyoJeVd02kLsY3wudXHyDmm8J80ybrXJsmA623qBu5bi1xygA8kjamEQbXkjpAvVqHsJ4m6ER1Z1telgN5vf7FZz+oEOct768vc7hluLUV5s9XFv5ycRGfKrcjYwPSUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R5eX0Ndhv1fO2am2eB49/l2Y99h8Je5lwf3OxwHjGWI=; b=ns2OpM3RFVEj1gUYlGZqeJrXZU/U5zOwQ+D/cl+EJwuev6++kQO1YseRU+GIAeC1vuGAmncqgvzpuKi0/kRa4Yn+UP775MueE3Z/tyQxLiQSpBQfdyoiHX8+3a7Yzv5bl18voB1MgiQ0jvOeJ7nxUzfyRZopB68sN1SDSPQaXxs= Authentication-Results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4885.namprd11.prod.outlook.com (2603:10b6:510:35::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Fri, 29 Oct 2021 17:40:21 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4649.015; Fri, 29 Oct 2021 17:40:21 +0000 Message-ID: Date: Fri, 29 Oct 2021 18:40:14 +0100 Content-Language: en-US To: Maxime Coquelin , , , , , , , , CC: , , References: <20211027142213.556166-1-maxime.coquelin@redhat.com> <20211027142213.556166-2-maxime.coquelin@redhat.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211027142213.556166-2-maxime.coquelin@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR0802CA0030.eurprd08.prod.outlook.com (2603:10a6:4:a3::16) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR0802CA0030.eurprd08.prod.outlook.com (2603:10a6:4:a3::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14 via Frontend Transport; Fri, 29 Oct 2021 17:40:18 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 910d8b67-e671-49aa-5baf-08d99b032e20 X-MS-TrafficTypeDiagnostic: PH0PR11MB4885: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bJwY3A+1k5JJDWc1lY/nPDT0vj5gFXGVLa6OcxkaS/SUweJPddUAu7wYC7Yq0jmFFk23IRM/S4xZpgQuy+CO75UY73JhCyWENuyJaeLXuE3Znyq3RFxOm3V+ezk7cvS2bLqTupeV+sOTiNQYZb+0lMfgbP+4J2Do4zsRKB7LHrtd+vhabDgVqVZXY3rghUZPbZAugtq1W7ppBzsi3zwh4UssW1dTASLOhwzOAk+kgwo37FGxkHSKJWt/eZA85AEXhtpvhkgiRkY3992PX9sVtCy74W51RyQzIEtS4asE42RFFfNcbE39tqlLHxjiYl/I+zXwro23xEarxdWgEgK8pipC/JUYXYrN4BvVeznndewHKIU1xBsLtff9Q3bzzsw+Shi2b43M/B4l2Se6lhj7a5jI6DN3n4nd5G4YL9jbciwFYu1CGrixSAugjEn8N2BBM6kX90nKB0W7j1xCbzUuJSpHgrKFX8IhwP3r/0jxRrBHVTuqwLer+Tl2c/iAO5gx8oJldZkyVlQgzP6Xqztikjhor7xpoCRjmn/sZuweklismMsbUFhFZ9WZJ4XUWsh427n8lh25RWA0V+v/8pxHEhjCyIsHPsl5KuQ6nZQEoEMWDa6Bo1qIzEFkgdCclIE2W1dTCYeN2vAWka2FDIx5xns0HOxeEJGMn1IqZGO5Me+1KAOlIS0EE22HvR3RY2njMqh38yv4yTj0RZCepaliCA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(8676002)(4326008)(38100700002)(186003)(83380400001)(2906002)(7416002)(316002)(66476007)(508600001)(16576012)(36756003)(66556008)(5660300002)(6666004)(956004)(53546011)(2616005)(8936002)(82960400001)(26005)(66946007)(31686004)(6636002)(6486002)(86362001)(31696002)(44832011)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RHBEa1pjZzQzOUJtZGJWcFFsdnV4VU5FbHZpak50TUw2bG5BUlNJK0h3Q2l6?= =?utf-8?B?bUMrcmJqalJ0Z3p6blB3YmdOb2ZCWXBCYlU1VHMyTDBtcGtYeVdUaHBkSmhZ?= =?utf-8?B?bks2VHNpLzFONkZzK3cwN210KzNhMmVaYk1hK2dnem41SmNCZXpseFFGN1Qx?= =?utf-8?B?NW81am83aWJqZk8rbkpLSTZDZmlrT3VwMGpJNWJJRytxM3ZhMHR5OW9IQSs1?= =?utf-8?B?ZWUyY1R1R0VHZm1tMEd1dmpIbnJ6MzllTkZHUzAwelloSDR2ZEp6djcyOUZu?= =?utf-8?B?dmVuTzdQcDBXUDZDRm9xSk9vc2lrUkhhckdMNWR6R3lXV0RzUEhKWmZqUjRC?= =?utf-8?B?UUFpMGFUYmpmMHlJQU1tZzhwWHBPL1dQdDlkU3NkK0UxRXZMVjFNc0pLUzZm?= =?utf-8?B?SnlnaExSMTNxb2ZwK0w3eWUxV05zMERyeTh5SkQxQ1RHMGp1MjkrMXFOVWVw?= =?utf-8?B?Y2s0UlIycUcvWlVBNWpaR3lYTXVkZ2pHU0ZwSmJ6K1dZcnRlNS9CRXpnWmpD?= =?utf-8?B?c1dnUVhpTThESG9STVhxbzYrUzhaZXhuR1J4SmtWcFcvaEpIb2tFY2M1WVlj?= =?utf-8?B?aC9GYnRNcnlEbWVDdmIrSFZsQ0R0UnFaNnA1elNUTXd0MWlCQUd4bGl4blI1?= =?utf-8?B?Vlg3bDBrenJQbjlBN2lDVExwU291T1RMbHJvZWN1QTVSblF5dW94ZyttZU9S?= =?utf-8?B?RVFyZ1lTcUlKYWtGbXM3WEZmTG5Tc3djY0ZGSzZrQWY5UElmQ2tQZTU3Umhi?= =?utf-8?B?WUt2UERneEkzbms5Q0puakdzaHVWb2paQ1BrMTQwNDFZNktEdFFZaDFCalF2?= =?utf-8?B?M2tRbXFzYlcvblVRKytDMGt4Q3l1UExDMXI4YlRjT21CcWNMU0ZXc2R4Zkg0?= =?utf-8?B?TDlIZStFT1BZNTBaMzJVSHFLZmtjU1V6WVNTdFJxR0I2ZzlvZWsrTmJxUjRK?= =?utf-8?B?U3VvU2oxak43c1hKTEsyWGFvY05obUdnWlUrY2U1akdKV253VGluaU9rS2N4?= =?utf-8?B?aGVpZ042YlJLQ1EyL1p1VUFpYUl1RkpXdE16RjJXQk8rSWZtQlJ3WG1rTTd5?= =?utf-8?B?dHArbUVpZit0dDZxL3IyUm8xbzJSRjdZQ00vTi9hWGxNM3hlUFdiWjNLeWth?= =?utf-8?B?VnUzRE9yWjhYSWRqN1VySHBJRlZUOSs0aGdNZDVkekpKR0JNTmp2M2RQaHpJ?= =?utf-8?B?Yzc4c0d6bXR6R0RhQVY4SmxUQktVN0Q4YlZyVlA3dGdXZmwzc0M3RE1UeXJY?= =?utf-8?B?aUk0VHhRdDFQRUdZNFZjQjVWYjQwRklYL1EyQmgvVFE2a3hZbnZlWmVpYnB5?= =?utf-8?B?S3hMdlh1VzNSWDRJOVNNL0gxUzVTODBjbUQ3Ykx5ZVZGL2N1aVIxb2gyeVBk?= =?utf-8?B?YWpKRmNmckp1QWNxd2pSRmVMdWRPMkVXankxZk41QjVoNlJueklGdEo4RVV0?= =?utf-8?B?WFMvQ0xZVC9UZFRHVVJaNVZnVFh0MG1EUi9QVXl5MDU1YlJGNGdXSFFGaUFU?= =?utf-8?B?NGZybWFQZG13WHEramNsK0RhRlBtTEpObldMelFyVnA1Q0I0VjlIbUhJa1U0?= =?utf-8?B?V2w3ZFJYb1dUek5GK0g5QWZ0THV2MnV1cy9rRU1VeG5OZElWTEgyMWwxNzU0?= =?utf-8?B?aTk5TitVNHhsREF3cTZ0ZlV4VUpsWmJORzh0V2tBZkxuTzUycWliSnBmWkcx?= =?utf-8?B?NGp1OFhsSDVuOVZ6YWttbTdMMDRTOE9xVStwNXdPK3Jwc0ZSQTlxZzFBMktB?= =?utf-8?B?eWxkeXd1MlhadFBQTHJwbjJtK1JPaWNPa2J3RTJQQSsyU3dpRW9LSjNiWDNK?= =?utf-8?B?ME1aMEpHS2VJZHB6S1pZQlAyRFcyOEVDaUh1dzNjWkNCek12UDBrb090b1VH?= =?utf-8?B?SDloaTBFNStsS0R1YzM4MnQ4dnlNS1cwK1ZydHhvbmN5SW41NmVab05KUjlY?= =?utf-8?B?S0Fkb2RMNzdVc21GNWhhbGFFQitveHlaYW9pbWcwU2RPd0JGdG4veDkwTFVP?= =?utf-8?B?K0NaV2ZyK3ZtOWdqTWx5UERvNUh6TzBCMjRwSTJoM2d5TFZOYkZlTC9pZFBC?= =?utf-8?B?NnFKL0wvOXowdWZ5U3I5bUdCRHorSGV1ajdSQzhmNnR3M0g2RXpieHBrSkZp?= =?utf-8?B?U3I3WGJncWNDLzVkU2xKVXBweFdDQlV6cFJBL2pFaXRQSHVKWWFNN3RjNHRK?= =?utf-8?Q?MmlxXa0TRnNrcJxdz4+AVxA=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 910d8b67-e671-49aa-5baf-08d99b032e20 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2021 17:40:21.4080 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: h+X/C+Tc/27sjgKXezKgzrUMMLrCS8ToQaFcXQ7WIFC4qYa1dWtAQgxJ4adf97pSYueSISHMEaMhWBIW/shERw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4885 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v6 1/5] net/virtio: add initial RSS support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/27/2021 3:22 PM, Maxime Coquelin wrote: > Provide the capability to update the hash key, hash types > and RETA table on the fly (without needing to stop/start > the device). However, the key length and the number of RETA > entries are fixed to 40B and 128 entries respectively. This > is done in order to simplify the design, but may be > revisited later as the Virtio spec provides this > flexibility. > > Note that only VIRTIO_NET_F_RSS support is implemented, > VIRTIO_NET_F_HASH_REPORT, which would enable reporting the > packet RSS hash calculated by the device into mbuf.rss, is > not yet supported. > > Regarding the default RSS configuration, it has been > chosen to use the default Intel ixgbe key as default key, > and default RETA is a simple modulo between the hash and > the number of Rx queues. > > Signed-off-by: Maxime Coquelin <...> > +static uint64_t > +ethdev_to_virtio_rss_offloads(uint64_t ethdev_hash_types) > +{ > + uint64_t virtio_hash_types = 0; > + > + if (ethdev_hash_types & (ETH_RSS_IPV4 | ETH_RSS_FRAG_IPV4 | ETH_RSS_NONFRAG_IPV4_OTHER)) > + virtio_hash_types |= VIRTIO_NET_HASH_TYPE_IPV4; > + > + if (ethdev_hash_types & ETH_RSS_NONFRAG_IPV4_TCP) > + virtio_hash_types |= VIRTIO_NET_HASH_TYPE_TCPV4; > + > + if (ethdev_hash_types & ETH_RSS_NONFRAG_IPV4_UDP) > + virtio_hash_types |= VIRTIO_NET_HASH_TYPE_UDPV4; > + > + if (ethdev_hash_types & (ETH_RSS_IPV6 | ETH_RSS_FRAG_IPV6 | ETH_RSS_NONFRAG_IPV6_OTHER)) > + virtio_hash_types |= VIRTIO_NET_HASH_TYPE_IPV6; > + > + if (ethdev_hash_types & ETH_RSS_NONFRAG_IPV6_TCP) > + virtio_hash_types |= VIRTIO_NET_HASH_TYPE_TCPV6; > + > + if (ethdev_hash_types & ETH_RSS_NONFRAG_IPV6_UDP) > + virtio_hash_types |= VIRTIO_NET_HASH_TYPE_UDPV6; > + > + if (ethdev_hash_types & ETH_RSS_IPV6_EX) > + virtio_hash_types |= VIRTIO_NET_HASH_TYPE_IP_EX; > + > + if (ethdev_hash_types & ETH_RSS_IPV6_TCP_EX) > + virtio_hash_types |= VIRTIO_NET_HASH_TYPE_TCP_EX; > + > + if (ethdev_hash_types & ETH_RSS_IPV6_UDP_EX) > + virtio_hash_types |= VIRTIO_NET_HASH_TYPE_UDP_EX; Should use RTE_ETH_RSS macros with RTE_ prefix versions, updating in next-net. Same for below virtio_to_ethdev_rss_offloads().