From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4A3B8A04BC; Fri, 9 Oct 2020 19:07:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D7EF61BCA9; Fri, 9 Oct 2020 19:06:57 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 082601BCA9 for ; Fri, 9 Oct 2020 19:06:54 +0200 (CEST) IronPort-SDR: +cTEGeNxXViHf46F8h6w0mHDZ+640tbdv+Bh6wmQfDBDkDl5Fv6MzY9Y9SEJwWKxf5yqLIu5vl ROHhTXu8yDog== X-IronPort-AV: E=McAfee;i="6000,8403,9769"; a="164724853" X-IronPort-AV: E=Sophos;i="5.77,355,1596524400"; d="scan'208";a="164724853" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2020 10:06:53 -0700 IronPort-SDR: XeofRXLr2VC3Ajn95O1ZlYNJPQtoIPUrqfy/xMXdlY6SaO3SZeu3uENCudgdV3e7I+IDOdyEj9 oF4+Uj/LEOWg== X-IronPort-AV: E=Sophos;i="5.77,355,1596524400"; d="scan'208";a="462258416" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.3.170]) ([10.213.3.170]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2020 10:06:49 -0700 From: "Burakov, Anatoly" To: dev@dpdk.org Cc: Liang Ma , Bruce Richardson , Konstantin Ananyev , david.hunt@intel.com, jerinjacobk@gmail.com, thomas@monjalon.net, timothy.mcdaniel@intel.com, gage.eads@intel.com, chris.macnamara@intel.com References: <1601647919-25312-1-git-send-email-liang.j.ma@intel.com> <532f45c5d79b4c30a919553d322bb66e91534466.1602258833.git.anatoly.burakov@intel.com> Message-ID: Date: Fri, 9 Oct 2020 18:06:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <532f45c5d79b4c30a919553d322bb66e91534466.1602258833.git.anatoly.burakov@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 01/10] eal: add new x86 cpuid support for WAITPKG X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 09-Oct-20 5:02 PM, Anatoly Burakov wrote: > From: Liang Ma > > Add new x86 cpuid support for WAITPKG. > This flag indicate processor support umwait/umonitor/tpause > instruction. > > Signed-off-by: Liang Ma > Signed-off-by: Anatoly Burakov > Acked-by: Konstantin Ananyev The work on this patchset is clearly going to take a few more days, but this particular patch is high priority as there are other dependencies on this patch for DLB drivers. Would it be possible to accept this particular patch now... > --- > lib/librte_eal/x86/include/rte_cpuflags.h | 2 ++ > lib/librte_eal/x86/rte_cpuflags.c | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/lib/librte_eal/x86/include/rte_cpuflags.h b/lib/librte_eal/x86/include/rte_cpuflags.h > index c1d20364d1..5041a830a7 100644 > --- a/lib/librte_eal/x86/include/rte_cpuflags.h > +++ b/lib/librte_eal/x86/include/rte_cpuflags.h > @@ -132,6 +132,8 @@ enum rte_cpu_flag_t { > RTE_CPUFLAG_MOVDIR64B, /**< Direct Store Instructions 64B */ > RTE_CPUFLAG_AVX512VP2INTERSECT, /**< AVX512 Two Register Intersection */ > > + /**< UMWAIT/TPAUSE Instructions */ > + RTE_CPUFLAG_WAITPKG, /**< UMINITOR/UMWAIT/TPAUSE */ ...with typo fix (UMONITOR rather than UMINITOR)? -- Thanks, Anatoly