From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f177.google.com (mail-wr0-f177.google.com [209.85.128.177]) by dpdk.org (Postfix) with ESMTP id BC0417CAE for ; Mon, 10 Jul 2017 09:10:09 +0200 (CEST) Received: by mail-wr0-f177.google.com with SMTP id 77so125402837wrb.1 for ; Mon, 10 Jul 2017 00:10:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=c2BMFCH6uWPjy6DX0ZZXhW3/cgeK0oWMDRKLyOc6ddI=; b=04G8ftaII/RXPcGvfI7XeeKT4EGQISPPvHcZtRdyMGoPRzD9JeU4vJKi0FGKA+aeIC KFOOaFV8ZiHn+3o1cNt8zYFqNcoYKw8i9p9CLb5R4zantGzO0p+HNoB5SFhGUbORYFQO zzyikTKmxo6TYavcMzQiU3JmFVtLgrvT2QhkunSR5FfXypnJM9ufldplnCxobro78Vk0 U10o91+8dor3yrPCw6irIBTMTy1uN40hveUzfO5rzfdGPv3J1tWbuB9566toJGLk4Bcs 0HtzKHbpkVRVzDkPQfavsMH0SW8ojITYIY0vI7Le7FcXcVu2xPOaRt7yO9HMowRAZYBh ttuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=c2BMFCH6uWPjy6DX0ZZXhW3/cgeK0oWMDRKLyOc6ddI=; b=R2Srm2PdeSJRfb9F0zNiZC/xr4rCoDPt2l2UqiUKtI0D4c0SCIu8v24uCFfMW9tSuq j8ePITpbINc5PmhdjZtpQHJQJkXbZXqwkYmBTLjRqCQ+Ov0hSnrL+wPzQ04rAxqAV7aG JwFOV3UYrCnoEid8lry2qv/R/+koYo2HeAUsKEETX5lIwioOhPXmwPObKijIxQT/0Y87 IxJGNjUvN9uKcuoJYzuPeaXHA5fHVKTaq+xsCtQxW9IlGLwYTCAkwZI0FDnW2GKZFISv RjNVRD7nDt90z9jAOJOpxbajOxol3tyImoBwFvv2tTWwPdEAq9aePkKcyk89n26H640J 5oiw== X-Gm-Message-State: AIVw112uRrPFtdlbzRBeJzgrfSfFJQ/iF48O/PaoZmXHzXJA83EoMr17 kp5H1Xff03sFOFwI+0k1Ng== X-Received: by 10.223.154.206 with SMTP id a72mr7133810wrc.47.1499670609115; Mon, 10 Jul 2017 00:10:09 -0700 (PDT) Received: from [10.16.0.184] (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id k75sm9745855wmh.10.2017.07.10.00.10.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 10 Jul 2017 00:10:08 -0700 (PDT) To: Thomas Monjalon Cc: dev@dpdk.org References: <20170706152848.26632-1-thomas@monjalon.net> From: Pascal Mazon Message-ID: Date: Mon, 10 Jul 2017 09:07:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170706152848.26632-1-thomas@monjalon.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH] net/tap: add missing newlines in logs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Jul 2017 07:10:10 -0000 Acked-by: Pascal Mazon On 07/06/2017 05:28 PM, Thomas Monjalon wrote: > Some logs are missing the newline character \n. > > The logs using only line can be checked with this command: > git grep 'RTE_LOG(.*".*[^n]"' drivers/net/tap/ > > Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD") > Fixes: 268483dc2086 ("net/tap: add preliminary support for flow API") > Fixes: 2bc06869cd94 ("net/tap: add remote netdevice traffic capture") > Fixes: bf7b7f437b49 ("net/tap: create netdevice during probing") > > Signed-off-by: Thomas Monjalon > --- > drivers/net/tap/rte_eth_tap.c | 22 +++++++++++----------- > drivers/net/tap/tap_flow.c | 6 +++--- > 2 files changed, 14 insertions(+), 14 deletions(-) > > diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c > index f82f08802..110670e15 100644 > --- a/drivers/net/tap/rte_eth_tap.c > +++ b/drivers/net/tap/rte_eth_tap.c > @@ -145,7 +145,7 @@ tun_alloc(struct pmd_internals *pmd) > > fd = open(TUN_TAP_DEV_PATH, O_RDWR); > if (fd < 0) { > - RTE_LOG(ERR, PMD, "Unable to create TAP interface"); > + RTE_LOG(ERR, PMD, "Unable to create TAP interface\n"); > goto error; > } > > @@ -1269,7 +1269,7 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, char *tap_name, > if (!pmd->flower_support) { > if (remote_iface[0]) { > RTE_LOG(ERR, PMD, > - "%s: kernel does not support TC rules, required for remote feature.", > + "%s: kernel does not support TC rules, required for remote feature.\n", > pmd->name); > goto error_exit; > } else { > @@ -1290,22 +1290,22 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, char *tap_name, > */ > pmd->nlsk_fd = nl_init(0); > if (pmd->nlsk_fd == -1) { > - RTE_LOG(WARNING, PMD, "%s: failed to create netlink socket.", > + RTE_LOG(WARNING, PMD, "%s: failed to create netlink socket.\n", > pmd->name); > goto disable_rte_flow; > } > pmd->if_index = if_nametoindex(pmd->name); > if (!pmd->if_index) { > - RTE_LOG(ERR, PMD, "%s: failed to get if_index.", pmd->name); > + RTE_LOG(ERR, PMD, "%s: failed to get if_index.\n", pmd->name); > goto disable_rte_flow; > } > if (qdisc_create_multiq(pmd->nlsk_fd, pmd->if_index) < 0) { > - RTE_LOG(ERR, PMD, "%s: failed to create multiq qdisc.", > + RTE_LOG(ERR, PMD, "%s: failed to create multiq qdisc.\n", > pmd->name); > goto disable_rte_flow; > } > if (qdisc_create_ingress(pmd->nlsk_fd, pmd->if_index) < 0) { > - RTE_LOG(ERR, PMD, "%s: failed to create ingress qdisc.", > + RTE_LOG(ERR, PMD, "%s: failed to create ingress qdisc.\n", > pmd->name); > goto disable_rte_flow; > } > @@ -1314,14 +1314,14 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, char *tap_name, > if (strlen(remote_iface)) { > pmd->remote_if_index = if_nametoindex(remote_iface); > if (!pmd->remote_if_index) { > - RTE_LOG(ERR, PMD, "%s: failed to get %s if_index.", > + RTE_LOG(ERR, PMD, "%s: failed to get %s if_index.\n", > pmd->name, remote_iface); > goto error_remote; > } > snprintf(pmd->remote_iface, RTE_ETH_NAME_MAX_LEN, > "%s", remote_iface); > if (tap_ioctl(pmd, SIOCGIFHWADDR, &ifr, 0, REMOTE_ONLY) < 0) { > - RTE_LOG(ERR, PMD, "%s: failed to get %s MAC address.", > + RTE_LOG(ERR, PMD, "%s: failed to get %s MAC address.\n", > pmd->name, pmd->remote_iface); > goto error_remote; > } > @@ -1329,7 +1329,7 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, char *tap_name, > ETHER_ADDR_LEN); > /* The desired MAC is already in ifreq after SIOCGIFHWADDR. */ > if (tap_ioctl(pmd, SIOCSIFHWADDR, &ifr, 0, LOCAL_ONLY) < 0) { > - RTE_LOG(ERR, PMD, "%s: failed to get %s MAC address.", > + RTE_LOG(ERR, PMD, "%s: failed to get %s MAC address.\n", > pmd->name, remote_iface); > goto error_remote; > } > @@ -1342,7 +1342,7 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, char *tap_name, > qdisc_flush(pmd->nlsk_fd, pmd->remote_if_index); > if (qdisc_create_ingress(pmd->nlsk_fd, > pmd->remote_if_index) < 0) { > - RTE_LOG(ERR, PMD, "%s: failed to create ingress qdisc.", > + RTE_LOG(ERR, PMD, "%s: failed to create ingress qdisc.\n", > pmd->remote_iface); > goto error_remote; > } > @@ -1352,7 +1352,7 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, char *tap_name, > tap_flow_implicit_create(pmd, TAP_REMOTE_BROADCAST) < 0 || > tap_flow_implicit_create(pmd, TAP_REMOTE_BROADCASTV6) < 0) { > RTE_LOG(ERR, PMD, > - "%s: failed to create implicit rules.", > + "%s: failed to create implicit rules.\n", > pmd->name); > goto error_remote; > } > diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c > index a0dd5048a..e6a24d4ea 100644 > --- a/drivers/net/tap/tap_flow.c > +++ b/drivers/net/tap/tap_flow.c > @@ -1371,7 +1371,7 @@ int tap_flow_implicit_create(struct pmd_internals *pmd, > > remote_flow = rte_malloc(__func__, sizeof(struct rte_flow), 0); > if (!remote_flow) { > - RTE_LOG(ERR, PMD, "Cannot allocate memory for rte_flow"); > + RTE_LOG(ERR, PMD, "Cannot allocate memory for rte_flow\n"); > goto fail; > } > msg = &remote_flow->msg; > @@ -1396,7 +1396,7 @@ int tap_flow_implicit_create(struct pmd_internals *pmd, > } > err = nl_send(pmd->nlsk_fd, &msg->nh); > if (err < 0) { > - RTE_LOG(ERR, PMD, "Failure sending nl request"); > + RTE_LOG(ERR, PMD, "Failure sending nl request\n"); > goto fail; > } > err = nl_recv_ack(pmd->nlsk_fd); > @@ -1492,7 +1492,7 @@ tap_dev_filter_ctrl(struct rte_eth_dev *dev, > *(const void **)arg = &tap_flow_ops; > return 0; > default: > - RTE_LOG(ERR, PMD, "%p: filter type (%d) not supported", > + RTE_LOG(ERR, PMD, "%p: filter type (%d) not supported\n", > (void *)dev, filter_type); > } > return -EINVAL;