From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nbfkord-smmo01.seg.att.com (nbfkord-smmo01.seg.att.com [209.65.160.76]) by dpdk.org (Postfix) with ESMTP id 88D263777 for ; Fri, 20 Jan 2017 15:37:17 +0100 (CET) Received: from unknown [193.34.186.16] (EHLO webmail.solarflare.com) by nbfkord-smmo01.seg.att.com(mxl_mta-7.2.4-7) with ESMTP id d9022885.2b390c853940.213442.00-2485.471218.nbfkord-smmo01.seg.att.com (envelope-from ); Fri, 20 Jan 2017 14:37:17 +0000 (UTC) X-MXL-Hash: 5882209d76e7c360-11f62162952f3309b42b8d5a8162f8ec0dacf55d Received: from unknown [193.34.186.16] (EHLO webmail.solarflare.com) by nbfkord-smmo01.seg.att.com(mxl_mta-7.2.4-7) over TLS secured channel with ESMTP id b9022885.0.213439.00-2310.471211.nbfkord-smmo01.seg.att.com (envelope-from ); Fri, 20 Jan 2017 14:37:16 +0000 (UTC) X-MXL-Hash: 5882209c4fba4eb9-b8cce1a200b31b88929e4541e1d32ee1fcab05f5 Received: from [192.168.38.17] (84.52.89.52) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Fri, 20 Jan 2017 14:37:11 +0000 To: Thomas Monjalon References: <1484841140-24117-1-git-send-email-arybchenko@solarflare.com> <18339814.hMek8iyv21@xps13> CC: , From: Andrew Rybchenko Message-ID: Date: Fri, 20 Jan 2017 17:37:07 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <18339814.hMek8iyv21@xps13> X-Originating-IP: [84.52.89.52] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.000.1202-22834.003 X-TM-AS-Result: No--4.992900-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-AnalysisOut: [v=2.1 cv=BNm12QkG c=1 sm=1 tr=0 a=8P+NB+fYZDP74ap4g4d9Kw==] X-AnalysisOut: [:17 a=RB3BGLmKESwA:10 a=IgFoBzBjUZAA:10 a=zRKbQ67AAAAA:8 a] X-AnalysisOut: [=c4Xhav_BQkmgSKs-yAYA:9 a=pILNOxqGKmIA:10 a=p6lC_-DiEjrjYz] X-AnalysisOut: [FtpFEA:9 a=-luwk2E7v_V_vEJ_:21 a=_W_S_7VecoQA:10 a=PA03WX8] X-AnalysisOut: [tBzeizutn5_OT:22] X-Spam: [F=0.2000000000; CM=0.500; S=0.200(2015072901)] X-MAIL-FROM: X-SOURCE-IP: [193.34.186.16] Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/sfc: enable TSO by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jan 2017 14:37:18 -0000 On 01/20/2017 05:29 PM, Thomas Monjalon wrote: > 2017-01-19 15:52, Andrew Rybchenko: >> Signed-off-by: Andrew Rybchenko >> --- >> It is a mistake that TSO support is compiled out by default. >> We would be happy to enable it by deafult, but strictly speaking >> it is not a bug fix. >> >> Arguments to enable are: >> - be more feature-rich (and user-friendly) in default config >> - the most of internal testing is done with TSO enabled >> >> config/common_base | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/config/common_base b/config/common_base >> index b9fb8e2..134e9b9 100644 >> --- a/config/common_base >> +++ b/config/common_base >> @@ -261,7 +261,7 @@ CONFIG_RTE_LIBRTE_BNXT_PMD=y >> # >> CONFIG_RTE_LIBRTE_SFC_EFX_PMD=y >> CONFIG_RTE_LIBRTE_SFC_EFX_DEBUG=n >> -CONFIG_RTE_LIBRTE_SFC_EFX_TSO=n >> +CONFIG_RTE_LIBRTE_SFC_EFX_TSO=y > There should not be such option in the build-time configuration. > Why keeping it (even enabled by default)? Initially it was introduced since packet rates with TSO compiled out were slightly but noticeable better. Finally we have changed approach and performance improvements planned in 17.05 do not require it. I'll be happy to remove it completely, if there is no problems to include it in 17.02 (it will be a bit bigger but functionally equal to this one).