From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 573CD2FDD; Mon, 17 Jul 2017 11:17:40 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jul 2017 02:17:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,374,1496127600"; d="scan'208";a="108840935" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.255.132.50]) ([10.255.132.50]) by orsmga004.jf.intel.com with ESMTP; 17 Jul 2017 02:17:33 -0700 To: Stephen Hemminger , Qi Zhang Cc: jingjing.wu@intel.com, beilei.xing@intel.com, dev@dpdk.org, helin.zhang@intel.com, stable@dpdk.org References: <1499543665-16166-1-git-send-email-qi.z.zhang@intel.com> <20170711125620.331fc19e@xeon-e3> From: Ferruh Yigit Message-ID: Date: Mon, 17 Jul 2017 10:17:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170711125620.331fc19e@xeon-e3> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix VF Tx bytes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Jul 2017 09:17:41 -0000 On 7/11/2017 8:56 PM, Stephen Hemminger wrote: > On Sat, 8 Jul 2017 15:54:25 -0400 > Qi Zhang wrote: > >> CRC size on Tx path is not necessary to be excluded. >> >> Fixes: 98abce237ba7 ("net/i40e: fix VF statistics") >> Cc: stable@dpdk.org >> >> Signed-off-by: Qi Zhang >> --- >> drivers/net/i40e/i40e_ethdev.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c >> index 71cb7d3..0585869 100644 >> --- a/drivers/net/i40e/i40e_ethdev.c >> +++ b/drivers/net/i40e/i40e_ethdev.c >> @@ -2353,9 +2353,6 @@ i40e_update_vsi_stats(struct i40e_vsi *vsi) >> i40e_stat_update_48(hw, I40E_GLV_BPTCH(idx), I40E_GLV_BPTCL(idx), >> vsi->offset_loaded, &oes->tx_broadcast, >> &nes->tx_broadcast); >> - /* exclude CRC bytes */ >> - nes->tx_bytes -= (nes->tx_unicast + nes->tx_multicast + >> - nes->tx_broadcast) * ETHER_CRC_LEN; >> /* GLV_TDPC not supported */ >> i40e_stat_update_32(hw, I40E_GLV_TEPC(idx), vsi->offset_loaded, >> &oes->tx_errors, &nes->tx_errors); > > Whether or not CRC is included in length statistics has been an ongoing > problem in DPDK. The Linux and BSD standard is to exclude CRC from number > of bytes; Cisco includes it, and Juniper does not. > > For application consistency across real and virtual devices, all > statistics for both transmit and receive in DPDK must NOT include CRC bytes. In case missed, Qi sent a new version of patch with more comment [1]. It seems CRC is not counted at first place, that is why it has been excluded. So CRC bytes are not counted, even after this patch. [1] http://dpdk.org/dev/patchwork/patch/26690/ > > Is this still an issue in DPDK drivers? Do I need to put it on the > TAB agenda? Is it not clear in the documentation? >