Re: [PATCH v1] event/dlb2: add port attribute for independent enqueue

["Mattias Rönnblom" <hofors@lysator.liu.se>]

On 2024-12-13 05:33, pravin.pathak@intel.com wrote:
> From: Pravin Pathak <pravin.pathak@intel.com>
> 
> Independent Enqueue support is added to DPDK 24.11

"."

> Adding the attribute rte_event_port_attr_get() was missing

There is something wrong with that sentence.

"Add the corresponding rte_event_port_attr_get() attribute, which was 
missing."

> This commit adds it to retrieve port attributes
> 
> Signed-off-by: Pravin Pathak <pravin.pathak@intel.com>
> ---
>   lib/eventdev/rte_eventdev.c | 8 ++++++++
>   lib/eventdev/rte_eventdev.h | 6 ++++++
>   2 files changed, 14 insertions(+)
> 
> diff --git a/lib/eventdev/rte_eventdev.c b/lib/eventdev/rte_eventdev.c
> index ca295c87c4..61cff87b63 100644
> --- a/lib/eventdev/rte_eventdev.c
> +++ b/lib/eventdev/rte_eventdev.c
> @@ -880,6 +880,14 @@ rte_event_port_attr_get(uint8_t dev_id, uint8_t port_id, uint32_t attr_id,
>   		*attr_value = !!(config & RTE_EVENT_PORT_CFG_DISABLE_IMPL_REL);
>   		break;
>   	}
> +	case RTE_EVENT_PORT_ATTR_INDEPENDENT_ENQ:
> +	{
> +		uint32_t config;
> +
> +		config = dev->data->ports_cfg[port_id].event_port_cfg;
> +		*attr_value = !!(config & RTE_EVENT_PORT_CFG_INDEPENDENT_ENQ);
> +		break;
> +	}
>   	default:
>   		return -EINVAL;
>   	};
> diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h
> index fabd1490db..4089c493a7 100644
> --- a/lib/eventdev/rte_eventdev.h
> +++ b/lib/eventdev/rte_eventdev.h
> @@ -1318,6 +1318,12 @@ rte_event_port_quiesce(uint8_t dev_id, uint8_t port_id,
>    * Port attribute id for the implicit release disable attribute of the port.
>    */
>   #define RTE_EVENT_PORT_ATTR_IMPLICIT_RELEASE_DISABLE 3
> +/**
> + * Port attribute indicating it supports independent enqueue. i.e. enqueue order
> + * is independent of dequeue order for all forwarded events.

Maybe it's better not to make any attempts to explain what independent 
enqueue is, here?

> + *
> + */
> +#define RTE_EVENT_PORT_ATTR_INDEPENDENT_ENQ 4
>   
>   /**
>    * Get an attribute from a port.