From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5A70445E8A; Fri, 13 Dec 2024 07:46:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EEE0040263; Fri, 13 Dec 2024 07:46:28 +0100 (CET) Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by mails.dpdk.org (Postfix) with ESMTP id 6DC884003C for ; Fri, 13 Dec 2024 07:46:28 +0100 (CET) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 13457146A5 for ; Fri, 13 Dec 2024 07:46:28 +0100 (CET) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id 063E4145D7; Fri, 13 Dec 2024 07:46:28 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on hermod.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,AWL, T_SCC_BODY_TEXT_LINE autolearn=disabled version=4.0.0 X-Spam-Score: -1.2 Received: from [192.168.1.85] (h-62-63-215-114.A163.priv.bahnhof.se [62.63.215.114]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 59155146A2; Fri, 13 Dec 2024 07:46:26 +0100 (CET) Message-ID: Date: Fri, 13 Dec 2024 07:46:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] event/dlb2: add port attribute for independent enqueue To: pravin.pathak@intel.com, dev@dpdk.org Cc: jerinj@marvell.com, mike.ximing.chen@intel.com, bruce.richardson@intel.com, thomas@monjalon.net, david.marchand@redhat.com, tirthendu.sarkar@intel.com References: <20241213043300.18015-1-pravin.pathak@intel.com> Content-Language: en-US From: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= In-Reply-To: <20241213043300.18015-1-pravin.pathak@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2024-12-13 05:33, pravin.pathak@intel.com wrote: > From: Pravin Pathak > > Independent Enqueue support is added to DPDK 24.11 "." > Adding the attribute rte_event_port_attr_get() was missing There is something wrong with that sentence. "Add the corresponding rte_event_port_attr_get() attribute, which was missing." > This commit adds it to retrieve port attributes > > Signed-off-by: Pravin Pathak > --- > lib/eventdev/rte_eventdev.c | 8 ++++++++ > lib/eventdev/rte_eventdev.h | 6 ++++++ > 2 files changed, 14 insertions(+) > > diff --git a/lib/eventdev/rte_eventdev.c b/lib/eventdev/rte_eventdev.c > index ca295c87c4..61cff87b63 100644 > --- a/lib/eventdev/rte_eventdev.c > +++ b/lib/eventdev/rte_eventdev.c > @@ -880,6 +880,14 @@ rte_event_port_attr_get(uint8_t dev_id, uint8_t port_id, uint32_t attr_id, > *attr_value = !!(config & RTE_EVENT_PORT_CFG_DISABLE_IMPL_REL); > break; > } > + case RTE_EVENT_PORT_ATTR_INDEPENDENT_ENQ: > + { > + uint32_t config; > + > + config = dev->data->ports_cfg[port_id].event_port_cfg; > + *attr_value = !!(config & RTE_EVENT_PORT_CFG_INDEPENDENT_ENQ); > + break; > + } > default: > return -EINVAL; > }; > diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h > index fabd1490db..4089c493a7 100644 > --- a/lib/eventdev/rte_eventdev.h > +++ b/lib/eventdev/rte_eventdev.h > @@ -1318,6 +1318,12 @@ rte_event_port_quiesce(uint8_t dev_id, uint8_t port_id, > * Port attribute id for the implicit release disable attribute of the port. > */ > #define RTE_EVENT_PORT_ATTR_IMPLICIT_RELEASE_DISABLE 3 > +/** > + * Port attribute indicating it supports independent enqueue. i.e. enqueue order > + * is independent of dequeue order for all forwarded events. Maybe it's better not to make any attempts to explain what independent enqueue is, here? > + * > + */ > +#define RTE_EVENT_PORT_ATTR_INDEPENDENT_ENQ 4 > > /** > * Get an attribute from a port.