From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ktraynor@redhat.com> Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 4B9993772; Wed, 8 May 2019 18:05:40 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 80F89A836; Wed, 8 May 2019 16:05:39 +0000 (UTC) Received: from [10.36.117.210] (ovpn-117-210.ams2.redhat.com [10.36.117.210]) by smtp.corp.redhat.com (Postfix) with ESMTP id 709F01717E; Wed, 8 May 2019 16:05:38 +0000 (UTC) To: Igor Russkikh <Igor.Russkikh@aquantia.com>, "dev@dpdk.org" <dev@dpdk.org>, Pavel Belous <Pavel.Belous@aquantia.com>, "stable@dpdk.org" <stable@dpdk.org> References: <cover.1556525874.git.igor.russkikh@aquantia.com> From: Kevin Traynor <ktraynor@redhat.com> Message-ID: <a1c72ce2-3def-f90f-cf79-6c84b713feb3@redhat.com> Date: Wed, 8 May 2019 17:05:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <cover.1556525874.git.igor.russkikh@aquantia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Wed, 08 May 2019 16:05:39 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 00/11] Aquantia atlantic bugfixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 08 May 2019 16:05:40 -0000 On 29/04/2019 09:20, Igor Russkikh wrote: > This patchset contains various bugfixes found during verification > and integration testing. > > Most notable is eeprom access cleanup, fix for broadcast filter, > flow control logic tracking, some code style cleanups. > > Igor Russkikh (7): > net/atlantic: enable broadcast traffic > net/atlantic: extra line at eof > net/atlantic: bad indentation > net/atlantic: fix max eeprom size > net/atlantic: validity check for eeprom dev address > net/atlantic: typo on args check > net/atlantic: extra err check > > Pavel Belous (4): > net/atlantic: eeprom get/set should consider offset > net/atlantic: bad logic with offsets talking with firmware > net/atlantic: flow control settings synchronization on rx > net/atlantic: use capability bits to detect eeprom access > > drivers/net/atlantic/atl_ethdev.c | 43 +++++-- > drivers/net/atlantic/atl_rxtx.c | 1 - > drivers/net/atlantic/atl_types.h | 3 +- > drivers/net/atlantic/hw_atl/hw_atl_b0.c | 8 ++ > drivers/net/atlantic/hw_atl/hw_atl_b0.h | 2 + > drivers/net/atlantic/hw_atl/hw_atl_utils.c | 17 +-- > drivers/net/atlantic/hw_atl/hw_atl_utils.h | 11 +- > .../net/atlantic/hw_atl/hw_atl_utils_fw2x.c | 111 ++++++++++++------ > 8 files changed, 128 insertions(+), 68 deletions(-) > Hi - some of these that are fixes will apply on 18.11 stable branch with a little of rebasing, some will not. It will be cleaner to take the fixes as a series. Can you send backports for the series for the 18.11 branch, or let me know if they are not needed. thanks, Kevin. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id EB581A0096 for <public@inbox.dpdk.org>; Wed, 8 May 2019 18:05:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7E10937A2; Wed, 8 May 2019 18:05:41 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 4B9993772; Wed, 8 May 2019 18:05:40 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 80F89A836; Wed, 8 May 2019 16:05:39 +0000 (UTC) Received: from [10.36.117.210] (ovpn-117-210.ams2.redhat.com [10.36.117.210]) by smtp.corp.redhat.com (Postfix) with ESMTP id 709F01717E; Wed, 8 May 2019 16:05:38 +0000 (UTC) To: Igor Russkikh <Igor.Russkikh@aquantia.com>, "dev@dpdk.org" <dev@dpdk.org>, Pavel Belous <Pavel.Belous@aquantia.com>, "stable@dpdk.org" <stable@dpdk.org> References: <cover.1556525874.git.igor.russkikh@aquantia.com> From: Kevin Traynor <ktraynor@redhat.com> Message-ID: <a1c72ce2-3def-f90f-cf79-6c84b713feb3@redhat.com> Date: Wed, 8 May 2019 17:05:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <cover.1556525874.git.igor.russkikh@aquantia.com> Content-Type: text/plain; charset="UTF-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Wed, 08 May 2019 16:05:39 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 00/11] Aquantia atlantic bugfixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Message-ID: <20190508160537.XYKGB7sr16GIhktQW_9rHKp_Ev15QxcKMUU_WUQh-NU@z> On 29/04/2019 09:20, Igor Russkikh wrote: > This patchset contains various bugfixes found during verification > and integration testing. > > Most notable is eeprom access cleanup, fix for broadcast filter, > flow control logic tracking, some code style cleanups. > > Igor Russkikh (7): > net/atlantic: enable broadcast traffic > net/atlantic: extra line at eof > net/atlantic: bad indentation > net/atlantic: fix max eeprom size > net/atlantic: validity check for eeprom dev address > net/atlantic: typo on args check > net/atlantic: extra err check > > Pavel Belous (4): > net/atlantic: eeprom get/set should consider offset > net/atlantic: bad logic with offsets talking with firmware > net/atlantic: flow control settings synchronization on rx > net/atlantic: use capability bits to detect eeprom access > > drivers/net/atlantic/atl_ethdev.c | 43 +++++-- > drivers/net/atlantic/atl_rxtx.c | 1 - > drivers/net/atlantic/atl_types.h | 3 +- > drivers/net/atlantic/hw_atl/hw_atl_b0.c | 8 ++ > drivers/net/atlantic/hw_atl/hw_atl_b0.h | 2 + > drivers/net/atlantic/hw_atl/hw_atl_utils.c | 17 +-- > drivers/net/atlantic/hw_atl/hw_atl_utils.h | 11 +- > .../net/atlantic/hw_atl/hw_atl_utils_fw2x.c | 111 ++++++++++++------ > 8 files changed, 128 insertions(+), 68 deletions(-) > Hi - some of these that are fixes will apply on 18.11 stable branch with a little of rebasing, some will not. It will be cleaner to take the fixes as a series. Can you send backports for the series for the 18.11 branch, or let me know if they are not needed. thanks, Kevin.