From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EBA74A0C41; Wed, 6 Oct 2021 13:06:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B4F4C40F35; Wed, 6 Oct 2021 13:06:45 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 9219A40140 for ; Wed, 6 Oct 2021 13:06:43 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10128"; a="286848177" X-IronPort-AV: E=Sophos;i="5.85,350,1624345200"; d="scan'208";a="286848177" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2021 04:06:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,350,1624345200"; d="scan'208";a="439080920" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga006.jf.intel.com with ESMTP; 06 Oct 2021 04:06:40 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 6 Oct 2021 04:06:40 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 6 Oct 2021 04:06:39 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 6 Oct 2021 04:06:39 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.176) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 6 Oct 2021 04:06:38 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mnv1CUFUH3jtEUXP8SnjVlLzhSEiUMLyWRRlnw1DoDotcCOTJ+aZRqG9ASvJK7IldtWd9AllrXflVSDTZsTm3ZgWcOqQjNOqlG0aCrnuBvVwDCKJ4KmeNR5WMYNsGC2n3s5Uj4UBRgRvAwBqo8u5fAibP82oxeTwtWc6o9cMkarse5jUXS8+2aMd0jABWwEpRzvirPSXqZeP80/y4Eavo2TtkCthGn71zKLCZdIFQI6nFq6C3Jy34vLjs0S72XvvxQUvKlBmYAaJc8KvNq+v7i/11kLQ09h6wT+THhwXUjywwHjv69xeqsYnPlBvOHKQtq2cTNb7AMCa7wiljsI7+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2zdMp70NgmRMBUqIuY1VLA0jjCZJQdJAphwQMUk5Fq4=; b=erDOuz35vJzHjrizDDF4JXb62ARYVyyiQp0MC8tnJT5SFiavFzVHH5cdcvCLlxUmGWzIA+qQhCmk4KTdawVlxAXSrNmHyHpSItZL2Xb1pTLVhKGur8RIu5UG8N/6BAVGzWtQKnBYMhzYncuc4IMfgbM0PUTCTPHV4m1ZmNxS3xUdNbUfTXOys2foXGNadGK4DvObQWqk6q2XlVjTgeQx2Sqj2Bgdi7Q9H5ket4wpeBnjSFNqfJX57fXHbAdTECG3OszG/wlQS6d2L1XdQhOWPEPf30xgTC7+wEJ0rkTLu9ZUQFHMxQP8pmT+0mwwo2w/O3bVIA8GLiUOj//oxECfNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2zdMp70NgmRMBUqIuY1VLA0jjCZJQdJAphwQMUk5Fq4=; b=T+uZOO67dmsLr1qANmOVNJDgxJYdC+CXd/ky52S3kzUgs8YE8Mt32TRRz/5ZasnomHgzugUx3JFp9U+3st0fgJaC8C20OdjsG32qnH4b33qM4ic1F1jZJbRVkeWF13KUGKndwuxke6ZYH9xT4mllicYJOdcCd51ZNMYBdHaLC3o= Authentication-Results: oktetlabs.ru; dkim=none (message not signed) header.d=none;oktetlabs.ru; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5015.namprd11.prod.outlook.com (2603:10b6:510:39::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Wed, 6 Oct 2021 11:06:29 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%4]) with mapi id 15.20.4566.023; Wed, 6 Oct 2021 11:06:29 +0000 Message-ID: Date: Wed, 6 Oct 2021 12:06:14 +0100 Content-Language: en-US To: Andrew Rybchenko , Igor Russkikh , Somalapuram Amaranath , "Rasesh Mody" , Shahed Shaikh , "Ajit Khaparde" , Somnath Kotur , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , Haiyue Wang , Marcin Wojtas , Michal Krawczyk , Shai Brandes , Evgeny Schemeilin , Igor Chauskin , Gaetan Rivet , Qi Zhang , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , "Min Hu (Connor)" , Yisen Zhuang , Lijun Ou , Beilei Xing , "Jingjing Wu" , Qiming Yang , Andrew Boyer , Rosen Xu , Shijith Thotton , Srisivasubramanian Srinivasan , Matan Azrad , "Viacheslav Ovsiienko" , Liron Himi , Stephen Hemminger , Long Li , Jerin Jacob , Devendra Singh Rawat , Jiawen Wu , Jian Wang , Maxime Coquelin , Chenbo Xia , Yong Wang , "Thomas Monjalon" CC: References: <20210604144225.287678-1-andrew.rybchenko@oktetlabs.ru> <20211001090723.1414911-1-andrew.rybchenko@oktetlabs.ru> <20211001090723.1414911-5-andrew.rybchenko@oktetlabs.ru> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211001090723.1414911-5-andrew.rybchenko@oktetlabs.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2PR04CA0045.eurprd04.prod.outlook.com (2603:10a6:10:234::20) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DU2PR04CA0045.eurprd04.prod.outlook.com (2603:10a6:10:234::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend Transport; Wed, 6 Oct 2021 11:06:19 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 10daba24-c5c0-424b-a3b9-08d988b9589f X-MS-TrafficTypeDiagnostic: PH0PR11MB5015: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3osyLBoA4MU2130tZELNKSq/FW417vED20txIb834fFKVda7+jIO7HrbXxK7PRzN1ktPpb+jD9KGq2p+fTSi5L2FnI5DYK4BkjB7EBRpXj+HvraNyKb/SMUBkzV/gxgioT+6Ykuba47LXSkMX5cqaE/pwgrD13M61WzoTGvqkwlWfesjD3pHycY489BV5+zBBxrVaFL4mTgd57ePnSh96uhfwikNY3wv7YWoH9bsssbMmPok5F20dH5i5FK1LTac23jpGW+my8lxpXkdyEYl55To1xZ31l9H5e4VmiXR+X7/mRkGu7vAL0LgmzQANe/weuETn4fmE+aGlnCo5vL7sUqEZxtbstyc/16NrmgwHOEaF0FQ16ORzh/1khiqSJIiJXo83ogLhgqZ+6xX8BZLNwJuak7S1kdLvlRtwm3MjWumvTl7gLyXxyZ3m6jA+aPkZpv2eWxGt/5g5PRtT5jss+GzPlnfqMwa4/ANCktK2q3o5nmxg19T964ocvnB1/zFwTcd1fWfHsAtmnNrVaZ89hyI1lBEV7fD25CPeIwGAWx9EswDsUDbUDvCN9E6KZCYmGfLwa0pjX5b7DFRYyfrF9K42PYaetaigFSLHdh1Xmj+EwXG7bPSuLDF/S2SC8CvNGuXLpH3F5Mhfb/wrb1/GWHztfLbKBSJ3PNQ35Wdf14UwTwp4dCSHEy+T5dHOk1aPmokBD1Hp6nbHyusEQGQeJKJrycdWclgByH+ehnZKdk= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(921005)(31686004)(38100700002)(86362001)(66556008)(66946007)(2906002)(6486002)(66476007)(110136005)(26005)(4326008)(8676002)(7416002)(6666004)(508600001)(7406005)(956004)(83380400001)(2616005)(186003)(316002)(36756003)(16576012)(31696002)(5660300002)(53546011)(44832011)(8936002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NEM0ZE1HeTI4MWJwUVRaUmx3VWs4bnNoVkZLNmJFVWs2Y1VHeVpOVk0vNUtE?= =?utf-8?B?bDZWWVVpMXQvZjAxQnkxTmtsS2QvamZpcWdoOUp0NDVVaHgrTXBoVFdDVUVo?= =?utf-8?B?aU1LdDZoQ2duSXRMbkJHNXRscjhNOXR6djJGcmtHc05vd1ExZ1Uvc3dMcDBF?= =?utf-8?B?V0l6ZW0zOWY4c1R6WS9FREhaZ0JENTNkWlR2Q2dkb0hPRTd6WUdld2R1ZEt6?= =?utf-8?B?VFdoOE1ORkVVc2I1bFZXbTM2UWhCQnJzM3RHNlR4TEtWRFlBKysreDhCblZK?= =?utf-8?B?SWM1Nm0rcGQ1bE5xcjdEVlkyNThYbk11VzRZM3JDME11YndVSlhMM2NXakdl?= =?utf-8?B?WVlnMW5PdW5LQzhWb05MWUl6OFhNemdkVGMrZ1VhdEFnb3diWm5uY0gwMkQv?= =?utf-8?B?RkRldGsxQWZHeUdaVmRIaGFtL2k1MlVLUVExdFhJa3JQZXk5K1ZBbFRzODIy?= =?utf-8?B?YndVNUZLZXYwcm5kb1ZuK1BRZnNNc1ZuY3lEYTkwRGhrbUQxZUpLWUFsZUdC?= =?utf-8?B?bmxjOU1tbUpFSVB1UExRbWdjZDE5eHZjTHRQTmk2OHNLUnY1OVRGOGhOR284?= =?utf-8?B?aFQzeG9FVVdJZVdxT2tWM3kveTB6Vm4wLzI0Nmk2YWpoYmNIWFJKa00vendX?= =?utf-8?B?ZGx4T1o1QytWN3crRXRvSzRXdjczRXB5ZjFISzFRaUNXKzRMY3NJUEphaDJj?= =?utf-8?B?VWplK0ZTaUhrdlZlSmRMSUtUZmxVNGZTdy9xYTByOVRRQ3E3RnNBK1N4NFVy?= =?utf-8?B?RHVNWEoweDRrbUc5VTY5MGlXTUwySVI2OGN4WW1ZQ0V0NUFFdjY2VThnUitC?= =?utf-8?B?emVqTjRQaG5hWmN5YitOOGZsRE1KV2Q3VmVESXd4OHp5eGRxK1dIdUg3UExy?= =?utf-8?B?ZnYwZmNON0lVdDZWMitxaElJN1dScUNVamZQTURpK2NFWjhxVTMvWXNORE04?= =?utf-8?B?clZBajNjQWNJbTlFOTJ5WEZGTjkyak8vZHZEWDA1V05uT3BLQmdINHJnVFpZ?= =?utf-8?B?RGVJclByMG5WNTRvVXJScVExYUhPci92RWhMUTJBVHh3RGozVUpHM2Y1Q1A3?= =?utf-8?B?L3FWbURJcWN5RGR2a0c0WndZa0p0WUFmckNxZ2lMZFY4SkdENm9KbzZWV0VT?= =?utf-8?B?RGpNd2lLNmEzeFZ1V1NHbXZrWGpiSDRIc3I5ck1LOUxKMFRWdnRncVZpWUxF?= =?utf-8?B?VzhrK3pMeFVoR0dvMVc1WldsdTF6ajd2RFV1VUE5NFVKUS96aVNCVEhadGhO?= =?utf-8?B?OTVOUHJjSE5BZG9EZGFUUVhUMXZzb0J0SEp0dXFIZGZOOHNXeFhXaEJDeWdM?= =?utf-8?B?Y1p1ZjJxbjNYb25MeWREMXp0QWtDVkNzYU1mbUZ4Mkl4Z2pESG9GL1l2TUVx?= =?utf-8?B?MDFIYXpITlJvT0h0VExHSFNLMmNvZ0N0RSs5ZXJwRHZGUjV6TjBVOUhoNC92?= =?utf-8?B?cmFidGs3bGNMeHNIR3MyRFBuOXlaYnNMT0Z1YURlSGZhSlJleEdNOGQ3Qy9S?= =?utf-8?B?c2dib3IyR0htaGdCbit5QTJ6dnREM2ZqUFBQdGV2M3JxeXlWaTNrdVh5WnZi?= =?utf-8?B?RzlXTzZKbGlTajhwWCtTS2wwMmdSTzJMU3hBaUhqdVpCbWtLMEF5Si9NeFg5?= =?utf-8?B?RS93MUFyZUdiZktxbVBPTlNtZVdrZEl6alVGV1BpZ1R1b1pCYy85TnBTWEpH?= =?utf-8?B?aDFhTnpTczRSQmtqOThSSERGaFpuVzJFZk12TFdoamdBWUh4V21JTTBnNzVD?= =?utf-8?Q?PW7HWIj3k4BlMhcHgIM1sUtxzvafnA3cqTulfD0?= X-MS-Exchange-CrossTenant-Network-Message-Id: 10daba24-c5c0-424b-a3b9-08d988b9589f X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2021 11:06:29.1210 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lS0fXXpKoiZ1eslca6N4Iskw80C7W7BEDVsmG2zyMQr58kuvRgl0aTCaW3IaCZU3meiIPsj9RY91tGOccfp6lA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5015 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v9 5/5] ethdev: merge driver ops to get all xstats names and by ID X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/1/2021 10:07 AM, Andrew Rybchenko wrote: > All xstats names may be retrieved passing NULL ids. > > If a driver does not support getting names by IDs, the callback should > return -ENOTSUP on attempt to use it. If so, the request is handled > on ethdev layer by getting all names and filtering out requested only. > > Signed-off-by: Andrew Rybchenko The intention is to simplify dev_ops for drivers and have one less dev_ops, but for xstat_by_id, it is already covered by ethdev layer if PMD doesn't implement one, so PMD needs to implement them only if it has a better way to provide _by_id values. So this merge is bringing an additional check for the ones that doesn't implement _by_id dev_ops, and for the ones that implement there isn't much difference, still PMD needs two functions, one for to get all values, and one for to get _by_id, now although there is single dev_ops, PMD implementation doesn't differ much. Because of above reasons I am not sure about this patch, let me proceed with rest of the series, we can discuss this patch more separately.