From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DE85DA04B5; Thu, 10 Sep 2020 13:22:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AC7A61BEB3; Thu, 10 Sep 2020 13:22:54 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id E611A2BA8 for ; Thu, 10 Sep 2020 13:22:52 +0200 (CEST) IronPort-SDR: GZ0gPRsmqbBdujMJeARXUyZe4V4gYwUY7047bApkjgjaPIGQiP/0I9BcplPbGy0zCyYocyh5Xr W6QF2x5iw5ZA== X-IronPort-AV: E=McAfee;i="6000,8403,9739"; a="155971167" X-IronPort-AV: E=Sophos;i="5.76,412,1592895600"; d="scan'208";a="155971167" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Sep 2020 04:22:52 -0700 IronPort-SDR: z/YoTkrsG3Juw7C4FXNXE/asAerKs2AXGOodGkiIwmyXZGX8Vb9Bycuz8/aUJR04ZNN9vfXwVz HRrzOcUTLbJA== X-IronPort-AV: E=Sophos;i="5.76,412,1592895600"; d="scan'208";a="480850981" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.213.214.48]) ([10.213.214.48]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Sep 2020 04:22:51 -0700 To: jiawenwu@trustnetic.com, dev@dpdk.org References: <20200820030231.1382984-1-jiawenwu@trustnetic.com> <006401d68056$5a761840$0f6248c0$@trustnetic.com> <9bf75003-2e08-43b6-dddc-89d75e054235@intel.com> <000101d68742$58a26f80$09e74e80$@trustnetic.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJsBBMBCgBWAhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEABQkKqZZ8FiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl6ha3sXGHZrczovL2tl eXMub3BlbnBncC5vcmcACgkQ+TPrQ98TYR8uLA//QwltuFliUWe60xwmu9sY38c1DXvX67wk UryQ1WijVdIoj4H8cf/s2KtyIBjc89R254KMEfJDao/LrXqJ69KyGKXFhFPlF3VmFLsN4XiT PSfxkx8s6kHVaB3O183p4xAqnnl/ql8nJ5ph9HuwdL8CyO5/7dC/MjZ/mc4NGq5O9zk3YRGO lvdZAp5HW9VKW4iynvy7rl3tKyEqaAE62MbGyfJDH3C/nV/4+mPc8Av5rRH2hV+DBQourwuC ci6noiDP6GCNQqTh1FHYvXaN4GPMHD9DX6LtT8Fc5mL/V9i9kEVikPohlI0WJqhE+vQHFzR2 1q5nznE+pweYsBi3LXIMYpmha9oJh03dJOdKAEhkfBr6n8BWkWQMMiwfdzg20JX0o7a/iF8H 4dshBs+dXdIKzPfJhMjHxLDFNPNH8zRQkB02JceY9ESEah3wAbzTwz+e/9qQ5OyDTQjKkVOo cxC2U7CqeNt0JZi0tmuzIWrfxjAUulVhBmnceqyMOzGpSCQIkvalb6+eXsC9V1DZ4zsHZ2Mx Hi+7pCksdraXUhKdg5bOVCt8XFmx1MX4AoV3GWy6mZ4eMMvJN2hjXcrreQgG25BdCdcxKgqp e9cMbCtF+RZax8U6LkAWueJJ1QXrav1Jk5SnG8/5xANQoBQKGz+yFiWcgEs9Tpxth15o2v59 gXK5Ag0EV9ZMvgEQAKc0Db17xNqtSwEvmfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ES YpV8QWj0xK4YM0dLxnDU2IYxjEshSB1TqAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4Ai bPtrHuIXWQOBECcVZTTOdZYGAzaYzxiAONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxD UQljeNvKYt1lZE/gAUUxNLWsYyTT+22/vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/ 3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35piVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVj sM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQI3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdc q9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYHfVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH7 1PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZqw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFB VOQOxCvwRG2QCgcJ/UTn5vlivul+cThi6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI 8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJlRr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYC GwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNhHwUCXqFrngUJCKxSYAAKCRD5M+tD3xNhH3YWD/9b cUiWaHJasX+OpiuZ1Li5GG3m9aw4lR/k2lET0UPRer2Jy1JsL+uqzdkxGvPqzFTBXgx/6Byz EMa2mt6R9BCyR286s3lxVS5Bgr5JGB3EkpPcoJT3A7QOYMV95jBiiJTy78Qdzi5LrIu4tW6H o0MWUjpjdbR01cnj6EagKrDx9kAsqQTfvz4ff5JIFyKSKEHQMaz1YGHyCWhsTwqONhs0G7V2 0taQS1bGiaWND0dIBJ/u0pU998XZhmMzn765H+/MqXsyDXwoHv1rcaX/kcZIcN3sLUVcbdxA WHXOktGTQemQfEpCNuf2jeeJlp8sHmAQmV3dLS1R49h0q7hH4qOPEIvXjQebJGs5W7s2vxbA 5u5nLujmMkkfg1XHsds0u7Zdp2n200VC4GQf8vsUp6CSMgjedHeF9zKv1W4lYXpHp576ZV7T GgsEsvveAE1xvHnpV9d7ZehPuZfYlP4qgo2iutA1c0AXZLn5LPcDBgZ+KQZTzm05RU1gkx7n gL9CdTzVrYFy7Y5R+TrE9HFUnsaXaGsJwOB/emByGPQEKrupz8CZFi9pkqPuAPwjN6Wonokv ChAewHXPUadcJmCTj78Oeg9uXR6yjpxyFjx3vdijQIYgi5TEGpeTQBymLANOYxYWYOjXk+ae dYuOYKR9nbPv+2zK9pwwQ2NXbUBystaGyQ== Message-ID: Date: Thu, 10 Sep 2020 12:22:47 +0100 MIME-Version: 1.0 In-Reply-To: <000101d68742$58a26f80$09e74e80$@trustnetic.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] net: add a new network PMD named txgbe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/10/2020 8:16 AM, jiawenwu@trustnetic.com wrote: > Hi Ferruh, > > I am sorry that the patch work plan was disrupted due to other work inserted. > But I have created another nearly 40 patches as the 2nd set. > Should I send this set as a supplement to the previous one(as version v1 or v2?), or fix and verify the previous one firstly? I think better to fix the first set, this may cause changes in the second one. > > -----Original Message----- > From: Ferruh Yigit > Sent: Thursday, September 10, 2020 1:45 AM > To: jiawenwu@trustnetic.com; dev@dpdk.org > Subject: Re: [PATCH] net: add a new network PMD named txgbe > > On 9/1/2020 12:52 PM, jiawenwu@trustnetic.com wrote: >> Hi Ferruh, >> >> Since this patch is too large, it needs to be split into so many small patches, which takes a lot of time. > > Thanks Jiawen for the work, I am aware it is not easy to arrange the patches and it takes time. > Mostly looks good, I am putting some comments on new set. > >> Therefore, I first created a part of patches to contribute. And if there is a review problem with these patches, please let me know as soon. >> And I will complete the remaining patches in the next 3~4 days. > > Even it can go in multiple sets, first we can merge the initial set, you can verify and fix whatever exists, later can add more feature as separate sets. > >> >> Thanks. >> >> -----Original Message----- >> From: jiawenwu@trustnetic.com >> Sent: Friday, August 21, 2020 10:22 AM >> To: 'Ferruh Yigit' ; 'dev@dpdk.org' >> >> Cc: 'jianwang@trustnetic.com' ; >> 'yuhongzhang@trustnetic.com' >> Subject: RE: [PATCH] net: add a new network PMD named txgbe >> >> Hi Ferruh, >> >> Thanks for your suggestion. I'll split the patch into a patchset as soon as possible. >> >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Thursday, August 20, 2020 7:49 PM >> To: Jiawen Wu ; dev@dpdk.org >> Cc: jianwang@trustnetic.com; yuhongzhang@trustnetic.com >> Subject: Re: [PATCH] net: add a new network PMD named txgbe >> >> On 8/20/2020 4:02 AM, Jiawen Wu wrote: >>> This is a new network PMD named txgbe provides poll mode driver support for Wangxun 10Gb Ethernet NICs. >>> >>> Beijing WangXun Technology Co., Ltd. is a high-tech company specializing in the design of high-end integrated circuit chips and providing independent innovation solutions for enterprise network and storage products. Founded in May 2014, the company is headquartered in Beijing YuQuanHuiGu Science and Technology Park, with branches in Hangzhou City. Welcome to reach us on website https://www.net-swift.com. >>> >>> This patch is created base on the main branch in main repository. Our goal is to validate and commit txgbe driver into the 20.11 official release, and then continue the development and maintenance in community. >>> >>> Waiting for your reviews sincerely. >>> >>> Signed-off-by: Jiawen Wu >> >> Hi Jiawen, >> >> Thanks for the patch. >> >> Without looking into any detail, a very high level comment is, it is very hard to review a new PMD (40K+ loc) as a single patch. >> >> Can you please split the patch into multiple patches, which gradually build the PMD by adding a feature with each patch, starting from an empty skeleton. >> >> Last as few upstreamed PMDs as example: >> ionic: >> https://patches.dpdk.org/project/dpdk/list/?series=8206&state=%2A&arch >> ive=both >> >> pfe: >> https://patches.dpdk.org/project/dpdk/list/?series=6777&state=%2A&arch >> ive=both >> >> octeontx2 (one of the good samples I suggest checking): >> https://patches.dpdk.org/project/dpdk/list/?series=5302&state=%2A&arch >> ive=both >> >> >> Also you can skip all Makefile build system related changes, since it will be removed in this release, no need to spend time for it. >> >> Thanks, >> ferruh >> >> >> > > > >