DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: <dev@dpdk.org>, <anatoly.burakov@intel.com>
Subject: Re: [PATCH] doc: update documentation for ICE DCB and PFC features
Date: Mon, 3 Nov 2025 15:50:59 +0000	[thread overview]
Message-ID: <a208388a-4db1-44d3-8184-f2c3ea355a65@intel.com> (raw)
In-Reply-To: <aQjF_6Gne1Wpk1OM@bricha3-mobl1.ger.corp.intel.com>

Hi Bruce, thanks for reviewing, will send v2 addressing your comments

On 11/3/2025 3:10 PM, Bruce Richardson wrote:
> On Mon, Nov 03, 2025 at 03:02:37PM +0000, Vladimir Medvedkin wrote:
>> Add DCB and PFC documentation. Update feature matrix
>> and release notes.
>>
>> Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
>> ---
>>   doc/guides/nics/features/ice.ini       |  1 +
>>   doc/guides/nics/ice.rst                | 74 ++++++++++++++++++++++++++
>>   doc/guides/rel_notes/release_25_11.rst |  4 ++
>>   3 files changed, 79 insertions(+)
>>
> I should have noticed that this was all missing from the original patchset
> and flagged it before merge! Sorry.
>
> Anyway, thanks for doing this now - better late than never, as the saying
> goes! Review comments inline below.
>
> Thanks,
> /Bruce
>
<snip>
>> +
>> +PFC operates in VLAN-based mode and requires DCB to be configured first.
>> +
> So this means you need to call APIs in a specific order?

Yes, first we need to enable DCB with rte_eth_dev_configure(), then PFC 
can be configured on each individual TC. Generally speaking, PFC is a 
part of DCB standard so it should be obvious to configure DCB first.

>
<snip>
>> -- 
>> 2.43.0
>>
-- 
Regards,
Vladimir


  reply	other threads:[~2025-11-03 15:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-03 15:02 Vladimir Medvedkin
2025-11-03 15:10 ` Bruce Richardson
2025-11-03 15:50   ` Medvedkin, Vladimir [this message]
2025-11-03 15:53     ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a208388a-4db1-44d3-8184-f2c3ea355a65@intel.com \
    --to=vladimir.medvedkin@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).