From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0073.outbound.protection.outlook.com [104.47.42.73]) by dpdk.org (Postfix) with ESMTP id 876525681 for ; Thu, 15 Sep 2016 09:28:04 +0200 (CEST) Received: from DM5PR03CA0012.namprd03.prod.outlook.com (10.175.104.22) by CY1PR0301MB2012.namprd03.prod.outlook.com (10.164.2.18) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.619.10; Thu, 15 Sep 2016 07:28:02 +0000 Received: from BY2FFO11FD018.protection.gbl (2a01:111:f400:7c0c::151) by DM5PR03CA0012.outlook.office365.com (2603:10b6:3:118::22) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.609.9 via Frontend Transport; Thu, 15 Sep 2016 07:28:02 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BY2FFO11FD018.mail.protection.outlook.com (10.1.14.106) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.619.6 via Frontend Transport; Thu, 15 Sep 2016 07:28:02 +0000 Received: from [10.232.14.87] ([10.232.14.87]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u8F7RxhM015719; Thu, 15 Sep 2016 00:28:00 -0700 To: David Marchand References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <1473257297-7221-1-git-send-email-shreyansh.jain@nxp.com> <1473257297-7221-7-git-send-email-shreyansh.jain@nxp.com> CC: "dev@dpdk.org" , From: Shreyansh Jain Message-ID: Date: Thu, 15 Sep 2016 12:58:28 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131183980824520303; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1110001)(1109001)(339900001)(24454002)(189002)(199003)(377454003)(8676002)(2950100001)(65826007)(19580405001)(5660300001)(19580395003)(2906002)(626004)(86362001)(81166006)(36756003)(68736007)(356003)(83506001)(7846002)(87936001)(189998001)(85426001)(305945005)(110136003)(8666005)(31696002)(8936002)(77096005)(97736004)(4001350100001)(104016004)(11100500001)(92566002)(64126003)(23676002)(230700001)(50986999)(76176999)(586003)(81156014)(93886004)(105606002)(4326007)(54356999)(33646002)(31686004)(106466001)(50466002)(65806001)(47776003)(65956001)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0301MB2012; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD018; 1:8u9lazShNhzGFbs56E1PdZUAVHJCImJYCbHdxTbtVUeIPKQnlNRANFqNBDr4a/W9uPAcErJJVTcEAxTqkAyWfFA16kJteTdccXwSCxaZjX46LI6VFlXUnzxAe3k3r55qK/31yYQ4QlBGU/XxaA0BGPOMJsU/y1c8mmSDqoRLMGLRg65MW5URjuiBVk1uN90TcXtH8mbGNvYo++DrLaEtexTK+GzAdMGLeMvhergTmBmcooL0fF4DEjbNZuTBkOCdCfajmsvmYb0T7AnHhK3TizkangQFqTVq4YoS+TsSBWCcSMkRhhJJ3AQJimHHfnyTvhBu8ooG8mDgsSI8u78pYsfCN1vUMNjLcdojSZeIDhUZObfV37YslhGGDQH94ing5WlWxUSPeqNSDYcLoXvvNcCSKw/f5KftD2YhIN90bJIyBRquHzslZ8l5UlmPFvvuWLpe7ixC57lCphoKftkt9pJyDPB9fuoLzi9dbzVtxkGEwMt6o3u/WMuBr8PsepFv4cu1MAem6Oxj/21myBrrwpma0ojfCyuyqtzSErq45x6LQF35LdgasR0msMB8Cl10Bx41SdgcjE2B361G9cRAdw== X-MS-Office365-Filtering-Correlation-Id: 0f7fefd8-1e5b-4f69-666f-08d3dd39d3bb X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB2012; 2:FIA7ockzHuLgvmTasYsdnWkPtI5OYxNfteGF69Fupq7zP5gV2YQQLEC3D+ymHShymYN8h2/mF7AIqyh7ad+/KpcUs4EEsXyGVXe0jylGeerrXHf4N3vJbWwS32SRdKrv82rj0hFopl0MDCXWpwztHnVGOkQRz7MNQ9UYXjapnN0a+MAP+Vdgx0m1DMdeQ0b1; 3:JP1bN/70gLGTLVkkoWb4RK4qCFdwDWGyKT3miH/6fP51tP+AB3eCsNIEXfdnrWjdfDnPdxHRsWB6SZTUz/VHhmQoa12VR9dWlcWqDVzZTgYDjKJHux0MCURIBDhB5b6HD5EqTqn4PEKPdoEsvIXKla+rr55d8rWiuRnFZnzexnSL2ea8edtsS6n6N/C+P1nxVraXPlbtayTezVQD1Jr7UseWnrFyK2FcVkZZdsdWxlE=; 25:zQqjDGK+5wChdzkWsvP+UNZ05FW9cLaDronULDhIRRfJKHndtmQFQ3QarDnpbZxQkJjd1JSZ7aFQ8RmiPaNjdfagxQTvyeDd0VYmAyCzk6s+Yy2YEDSb9eDgDAlhG/VMDZ0sbEgeZX9DBjxrk45pr7VjkPj9/rUoUv4bzq9fotFFr8rSWjIhf2Hiqd1IqbUoSeKAQQQe399wBD+4Ux2bgubfbDLxjgbQfQJWnBpPI0vjS8krNt7vhZYr1173i+8PDhWjbh33XIzZ5NtuUOFQ4IP+KgjkH6i3hLH5NUOY+hQZ54xMD2I4/i7Pgm2CfuLHcrMOkZ+UdbWoAw6cXwq35NUiCSZJeJ8k1jDM5f9e/ljH2/4cDAHAXxIJa/jJK8qq8l8a/550dgbqKLNaq12BHUtVUt5QK0CB8Bqmy17mLyg= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB2012; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB2012; 31:9Yp8hBVet1il6iw5a8sPnVtpGd2VdJ9X4YCViwJg1j1vN6q+hYiZvIMfzfXtwzNrrcRSnBrmuFBZ62y36yPlwZUERto16PRPHIly7j46O2JU6E76YBL5aBsOpqXbRcS/l4lUZziFEPzqq5rLWAV5pSlVZdQnbVTR4k98RKXltAS9p1jhDL+1BzJYo8j0GMR9xisicLGafXkDbSUkQ9PQLym+UL5mSMMhkFCB8of6s98=; 4:NDbdfZ7rsc44MNiyBHC+cetxli1iLtbkswaL4Wnzhb2TBmbBo6Rfw9Dr50k7ElncTOfmA8iJDpPet++XiuBTn9Hr7KJJDqSRo69up4yoVaD1FV3h0WXaySMS0gVP3Sz5DrA/pm+BvqbkcX5vnSYTnLO1yt4QtgE4Q3yQsDJwaVnCs4le4G+KkIobmA80AhH1fNLo9WE9GvLxIXkAm5TVCDH0tg7/U+ViaPyrOlgMMYuVPzLio8a/qjD0a/G6ndjlwA8h4nDbvMgUC4zJLCqD3p1USOLqVoNkdmLSEkSGBom1GHiDF8OlmVwj+5fsP0d8K102+gYUY6iOM4QgPzTa1Vf5+/UilHLvK1deq0IqS4CEDLEC+DijiLcXqH1KLINKvBD7Hh1Zk6/5AFX9W6bZoMNpqCzMwxuWBQ5CTV7DrTMnAUto0oDEB3UQJ9tw1bNu2whRP4xdnkGbeXVksBBLMvFEtdv0T7d78V3xjBS5awgw5+2jJAUq5NkV1u97Xsvnb5xMug+phbN/KEa1FTaVg6X73Mm0z1qp4jaQfw+93pc= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(13015025)(13017025)(13023025)(13024025)(13018025)(5005006)(8121501046)(10201501046)(3002001)(6055026); SRVR:CY1PR0301MB2012; BCL:0; PCL:0; RULEID:(400006); SRVR:CY1PR0301MB2012; X-Forefront-PRVS: 0066D63CE6 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjAzMDFNQjIwMTI7MjM6RFZzaG5OM2VUR1BFR3JNcnlrMm5BREhS?= =?utf-8?B?NGlrcXg3bUlKakNEUmhGMW9YM1lWK21RRk1qWjZPMXo1Zk5Yb2NTZEJZSzdC?= =?utf-8?B?SUxuUnNmcVUwRUduckN2eFFMS3g2Mzh1ZysvYWsyamhWb2lzUXhLU1lZUm9E?= =?utf-8?B?b2ZVa0E4K3RESHY2WTBBUTNPWlgyd2VyRUFlK2pQOE9aYkhXS0JiYVhlamJV?= =?utf-8?B?Q2lQeTFEa2hWL3JkWndRMXdzNEI0ZzBJSEtoK2kxM3dVYTRub0FKZ3c4T2Zt?= =?utf-8?B?enFvOU9vdE1ESExFbkplMVZMRURVWkVSeno3YjE4Tk8wL2QzaGpOU2NqRmhq?= =?utf-8?B?ODNzSUo1bjJUbFBoQVJNVHIydEg4UVRzTDY5ZnZRSlZ1VDUvOUZPN1dRWm9W?= =?utf-8?B?NVBrQjY4M3ZwaUwrT01pOGprd2FLTXJIUkRRMnVMeWtYT29jbTczVFVGWFRk?= =?utf-8?B?OG1YdGp6ZlRkUEVuTG5FeXd3akdVdnVzdlJFRHFtTWZGTG5nRENTdXNLWU9j?= =?utf-8?B?OFJLdXA0WVkrd1lIZlRTQ3lTakNxdDNsaGZNVnNyMWJZblJmQmJxRHJkSEc0?= =?utf-8?B?cVBtb3h3SmpLVWQveXFGZTlDTmtITHdtaWtVWWQ1dDQyNWkzbEVUMmJTb3My?= =?utf-8?B?MWF5dFJsbGN3dEpIMVgyS2FpajZYK1k2SWVmVjhrV0d3MjdwZ3FRckVwUWhD?= =?utf-8?B?NklzVVFLU2JVcDN4dlgwdHdmVW9BOER3citpYmVXUmgvd0VTSTZWeFMrQ25I?= =?utf-8?B?Wkx3NXltU01QbjVWZGxKVi9DUGhOWjIvRXIzbGJyOVF5WEhkWnFCMTlYekJ5?= =?utf-8?B?MXJlMUdMSkFMTGJjQS9DYjZIVlh2QTk2ZjV2L3RLSTZiUjNPSHIxdkphZGgw?= =?utf-8?B?YkFuNXhEZVZLRW5TRXpBNFZQOVU4V1YrQkZSSzBMM1QwdlNFR0E4VmgrSGd5?= =?utf-8?B?ZUkxaGFBNFJ2NU1GWUw4RHhYQ0hWTU41eWhzQ1JsSTBTVmxJb1BaeGxFRVA3?= =?utf-8?B?Wm5rYUVFdTlDL3NoT2VxLzM4Z3pJeUhCSmR3c1lCUCs1OFZJRWYvdVlWMVM2?= =?utf-8?B?Q09KdzFrVmJ3Z0RuRDFKbm1pbS9IZnZYKzZmeTk0YXgzWHNwZDQ3YndjUExy?= =?utf-8?B?aGlaV24wb0FkWmo5NThlYTJlSTJoTDBnZlAvaWszYllnSHdaTkdUM3hVSE5O?= =?utf-8?B?eEROTHdWOUpkOS9iVjQvUFNwZndYZCsvV3d3YXlKbStlRFJmQTVHY3o0Qlc1?= =?utf-8?B?aFp5K2RPcVk3ZE9IMkY1Z0JGN3ZLR2lJRmorZHR4OVJwM2FIRGw1WXVKQ2w3?= =?utf-8?B?Z1pTV2xkV3hYQ1kyL3FCVW9DejNhNUl2S01mTklBQ0dMYVVyRFM5Q0VVcWxQ?= =?utf-8?B?WVdRZUhOZE05MHVLNlJVSjV0UVc2U2pzcU5WMXNhakkyQkV3UE5vMVQ1allG?= =?utf-8?B?aGZ5TWNTQWJZanVKT1E0WTA4K0VYWGpjSUZvSVk4QzhsamhVdzZqRyt0NWNo?= =?utf-8?B?ZDhSZFBKTkdxb2hkUmk5OTd4RE1GeGpFakU3dGswcTRReWl5dnlmeElicnVO?= =?utf-8?B?MFhrQlhZRklDc09yeEtQS0NCaXh5S3VLSXBRUVgxVUV2UjBxL2dwRjd1Q29F?= =?utf-8?B?YWtZVDB2QmJjWDN5cGxiRjZHb0wrUE1icmFOdzVzSFh6R2VhdXZVaTVsS2Jr?= =?utf-8?B?UWkxQW9YL3lIQ3J5eTBzeko5NktKUHFhaXE2UWJJdXVRY2ZTbnhIMXBsVzVG?= =?utf-8?B?VDNPVm1IWnRnaVpsTnplZmpJR1dpNlRPdHpqOWxKN3duZytjSTFMY2NsZFNj?= =?utf-8?B?TXZOcUlFSDU1SjA0eklYRE9kdjI0WEE5ODNpNCtvNDkvZ3d2M1Jua2JoV1BM?= =?utf-8?Q?iTMZWORXujrgA=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB2012; 6:M+i1vE2PhWczbuc+k8nQQ23S1f4feRfhpSPgPbnm+xqivOKA6GMRxF41AgyLkWehXjrjedbqUWIbutez3cyKJ4pu9EkU9fl5KbVWNxSt1qe9Q2VP1/PFcOWQGbryUyzKPYkZUuDrmGOCtfxBrSXP2gLw1srElAVmwCEdkfocWXzlkYRynfeqC/Fx5LlQnqAK0HkRzaAMr4zYGTfTI7XeWr8wakPRRVaVWTJwUUqy+AtRGy7GM33lWDbxP9Z0D+Wts2x58ivNR0ydHeQDbTdd/OLbrYNpRDIzoxfqeX8/DT8=; 5:3lKNegCgal+V91iHYVNjIgT/6VoZVFkC1JwJKz0Np+xv7lq66bp2tjfwasdrBDL+SvrI6ik27F1lEbRkKCHTc6JH8MlRz7wsdEZvY2aCP/bjA+s113Yri8tI9jlQThA/B0S3+uVX7MjKtjF7VZT/yK8UyBB83GQvLtKPnjvMSjg=; 24:a4/H9YS1v+wP1sRBuYLmCwUVVr1mgNYkn/KjeJt7VOfT6y2hFD/akJ7UybqF0yvGlLZvlcP8RV8CqDNZLqM5IBvGyiM9uS8dKPLl+DMkqG8=; 7:kjKzQ6j8ZhN0eTpaT+6ZgHr9VD2FHOj19ZKvOf1977KhpPYQU2fZJEo1ziJy4uZz4OLBrGvzCCA2ONXrzbNGp/4/Ni3iFf6LqmfFg/KLDVnVjmykMev1Yx5APtRUOGenUs4d0JFfsCFcuhZaDLfTBIUAF555Weww7XcpThHorDfcjbVPADP0wcKuR/HV/q3S/GJpxk6wYCS6H7LWxb7LUNh+Nhd60CUY9ECTEixnKZiLgoO/uTWQnJsPqJWz/ZQb SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2016 07:28:02.2648 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB2012 Subject: Re: [dpdk-dev] [PATCH v9 06/25] eal: introduce init macros X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2016 07:28:05 -0000 On Monday 12 September 2016 12:45 PM, David Marchand wrote: > On Wed, Sep 7, 2016 at 4:07 PM, Shreyansh Jain wrote: >> diff --git a/lib/librte_eal/common/include/rte_pci.h b/lib/librte_eal/common/include/rte_pci.h >> index fa74962..cf673e4 100644 >> --- a/lib/librte_eal/common/include/rte_pci.h >> +++ b/lib/librte_eal/common/include/rte_pci.h >> @@ -470,6 +470,16 @@ void rte_eal_pci_dump(FILE *f); >> */ >> void rte_eal_pci_register(struct rte_pci_driver *driver); >> >> +/** Helper for PCI device registeration from driver (eth, crypto) instance */ > > Typo: registration Ok - I will fix this. > >> +#define DRIVER_REGISTER_PCI(nm, pci_drv) \ >> +RTE_INIT(pciinitfn_ ##nm); \ >> +static void pciinitfn_ ##nm(void) \ >> +{ \ >> + (pci_drv).name = RTE_STR(nm);\ >> + rte_eal_pci_register(&pci_drv); \ >> +}\ >> +DRIVER_EXPORT_NAME(nm, __COUNTER__) > > Checkpatch complains about a missing space. Yes, '} \' is expected. somehow missed my merges though checkpatch did complain. Will fix this. > > -- - Shreyansh