From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B3ADE45813; Mon, 19 Aug 2024 16:28:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 498FE40658; Mon, 19 Aug 2024 16:28:26 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mails.dpdk.org (Postfix) with ESMTP id 41E8F40267 for ; Mon, 19 Aug 2024 16:28:24 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7AC43339; Mon, 19 Aug 2024 07:28:49 -0700 (PDT) Received: from [10.1.37.32] (e132423.arm.com [10.1.37.32]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9B6F23F73B; Mon, 19 Aug 2024 07:28:21 -0700 (PDT) Message-ID: Date: Mon, 19 Aug 2024 15:28:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 0/2] dts: port over checksum offload suite To: Dean Marx , probb@iol.unh.edu, npratte@iol.unh.edu, jspewock@iol.unh.edu, luca.vizzarro@arm.com, yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com, juraj.linkes@pantheon.tech Cc: dev@dpdk.org References: <20240816142031.15150-1-dmarx@iol.unh.edu> Content-Language: en-US From: Alex Chapman In-Reply-To: <20240816142031.15150-1-dmarx@iol.unh.edu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Dean, I went over the test suite and it looks really solid, but noticed you didn't update the `conf_yaml_schema.json`, is there any reason for this? On 8/16/24 15:20, Dean Marx wrote: > Port over checksum hardware offload testing suite from old DTS. The > suite verifies the ability of the PMD to recognize whether an incoming > packet has valid or invalid L4/IP checksum values. > > v1: In the original test plan, there were two Tx checksum test cases. I > removed them due to the lack of consistency in testpmd with Tx checksum > flags, either not being displayed during packet transmission or showing > values that did not align with the original test plan. > > Dean Marx (2): > dts: add csum HW offload to testpmd shell > dts: checksum offload test suite > > dts/framework/remote_session/testpmd_shell.py | 124 +++++++++ > dts/tests/TestSuite_checksum_offload.py | 255 ++++++++++++++++++ > 2 files changed, 379 insertions(+) > create mode 100644 dts/tests/TestSuite_checksum_offload.py > Best regards, Alex