From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 05077A00C5; Tue, 15 Feb 2022 11:46:58 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 84A55410F3; Tue, 15 Feb 2022 11:46:58 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 0579140E78 for ; Tue, 15 Feb 2022 11:46:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644922016; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jRz+q9hVl74bqUN1wPSADsqUFmkrQ7hFrZJYzFYXdmo=; b=FfiPpjdh5f35mKc2sWIjLOP/evj/0C4bFHXiAHzi0JbwAhd0lch8YCGbe0aTcFvVe/rcq5 9gckZJEQ15/jcDcmbDZbrQ3G+9yah3olMVktLhEucZ8qVxCQVS1UTNTgmJeoCXBcMOp+6p 1R4reNySUK7/pHyc+MooHfd46Iy3vQQ= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-595-aoot4tMOMHi6Lkoh4UqSoA-1; Tue, 15 Feb 2022 05:46:53 -0500 X-MC-Unique: aoot4tMOMHi6Lkoh4UqSoA-1 Received: by mail-wr1-f69.google.com with SMTP id y8-20020adfc7c8000000b001e755c08b91so1501440wrg.15 for ; Tue, 15 Feb 2022 02:46:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:subject:in-reply-to :content-transfer-encoding; bh=jRz+q9hVl74bqUN1wPSADsqUFmkrQ7hFrZJYzFYXdmo=; b=tgnZ4w81JctCAfL72ENh1VJoBrB0/k/wzsOBvh4iKyO31uOYrLZZLcJFIWKI6E/4BZ 1YQvNgdbM/O2gjmm3Anl1ocbOwi6ygijR6Us8VTVPB/Xv6eyd2pRY4qABIx+ntBfrzlY BKBjzyesc/Bn5ncxOhxVQ/YMa6l70ZNF5FjaC+K9V3GBideelK4W3AWULHD9LOZScn2O DuDt6YRWgnz81yQBbmHUhoKxFjil0VSercUlA1mEtIdhfTWXh3SZ5TpzxJ42ZnQQvQLL 23/Z5YmRvOPeeq+lMfD+7vZfrqoedvFXw+XHi2z7endnY7EV+/PI/y97KqPayjVUz7V6 nfIA== X-Gm-Message-State: AOAM5313OyW4nhYM6XgKVHJegLY0arZOMkhkGmOsSkAJF06zYEOxPQhP GlWi2UdHeOL3Xl0NxWkE8ymDvpOezPpJ+2lF3hsMuxQMqufVngdTMzStjXYKR11y02JXQQHb8QF tWlY= X-Received: by 2002:a05:600c:2d4b:: with SMTP id a11mr2554213wmg.44.1644922012253; Tue, 15 Feb 2022 02:46:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJwBpQ21ZZByQUgIhEvZEIezMX0+YG2psaIo6TTQHA6FiptLy+YCfvpIQ3dQC4iMe4fusp1WyQ== X-Received: by 2002:a05:600c:2d4b:: with SMTP id a11mr2554207wmg.44.1644922012068; Tue, 15 Feb 2022 02:46:52 -0800 (PST) Received: from [192.168.0.36] ([78.16.131.8]) by smtp.gmail.com with ESMTPSA id x17sm5950011wro.68.2022.02.15.02.46.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Feb 2022 02:46:51 -0800 (PST) Message-ID: Date: Tue, 15 Feb 2022 10:46:50 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 To: Ferruh Yigit , Radu Nicolau , Jingjing Wu , Beilei Xing Cc: dev@dpdk.org, yux.jiang@intel.com, Luca Boccassi References: <20220210130923.1442905-1-radu.nicolau@intel.com> <05a27976-6664-190c-38b7-9b63c7294973@intel.com> From: Kevin Traynor Subject: Re: [PATCH] net/iavf: fix segmentation offload buffer size In-Reply-To: <05a27976-6664-190c-38b7-9b63c7294973@intel.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 15/02/2022 10:06, Ferruh Yigit wrote: > On 2/10/2022 1:09 PM, Radu Nicolau wrote: >> This reverts commit ff8b8bcd2ebe, which resulted in incorrect buffer size >> being computed for TSO packets. >> >> Fixes: ff8b8bcd2ebe ("net/iavf: fix segmentation offload condition") >> > > Commit 'ff8b8bcd2ebe' was already fixing segmentation offload, > are we having the initial issue back when this patch reverted? > Is there a fix for that initial issue? > > +Kevin, Luca, > Since this patch reverts a fix done after 21.11, is there a way > to stop that fix to be merged for 21.11.x? > This revert patch would show up for us as a relevant one to backport, so in the worst case where initial fix was already pushed to dpdk.org, the revert would be taken too and the net result would be ok by release time. In this case, as the initial fix is not pushed to dpdk.org stable branches yet and as you have let us know, we can just make a note to skip it, or remove from a personal staging repo if already backported there. I'll add an email filter for 'reverts' to catch this so you won't have to ping manually, but feel free to do that as I suspect (hope :-)) it's only a handful of patches per release. Thanks for highlighting, Kevin. >> Signed-off-by: Radu Nicolau >> --- >> drivers/net/iavf/iavf_rxtx.c | 7 ++++--- >> 1 file changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c >> index b0fed1b992..ba272bb211 100644 >> --- a/drivers/net/iavf/iavf_rxtx.c >> +++ b/drivers/net/iavf/iavf_rxtx.c >> @@ -2464,9 +2464,10 @@ iavf_fill_data_desc(volatile struct iavf_tx_desc *desc, >> desc->buffer_addr = rte_mbuf_data_iova(m); >> >> /* calculate data buffer size less set header lengths */ >> - if (m->ol_flags & (RTE_MBUF_F_TX_TCP_SEG | RTE_MBUF_F_TX_UDP_SEG)) { >> - if (m->ol_flags & RTE_MBUF_F_TX_TUNNEL_MASK) >> - hdrlen += m->outer_l3_len; >> + if ((m->ol_flags & RTE_MBUF_F_TX_TUNNEL_MASK) && >> + (m->ol_flags & (RTE_MBUF_F_TX_TCP_SEG | >> + RTE_MBUF_F_TX_UDP_SEG))) { >> + hdrlen += m->outer_l3_len; >> if (m->ol_flags & RTE_MBUF_F_TX_L4_MASK) >> hdrlen += m->l3_len + m->l4_len; >> else >