From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 703EEA0588; Thu, 16 Apr 2020 17:52:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 538591DB03; Thu, 16 Apr 2020 17:52:44 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 11BD71D159 for ; Thu, 16 Apr 2020 17:52:41 +0200 (CEST) IronPort-SDR: 8CjgeOOV3brI0htZ/RRih/bPNuNOB62Ri5IQknUj6tYC6snb/65NvCef7tNk7mYA5zpiyLpR6Y adOHZl1WqqGA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2020 08:52:41 -0700 IronPort-SDR: hfYaVoYZjEkib9XRcdwKW2Cp971dJG/7gved2jNZFvZIVcaAtOo0BTpp5l7ioN205hsiC7oTSH Q/IdYPvjMg4A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,391,1580803200"; d="scan'208";a="427877778" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.252.21.63]) ([10.252.21.63]) by orsmga005.jf.intel.com with ESMTP; 16 Apr 2020 08:52:38 -0700 To: Jeff Guo , "Iremonger, Bernard" , "orika@mellanox.com" , "Ye, Xiaolong" , "Zhang, Qi Z" Cc: "dev@dpdk.org" , "Wu, Jingjing" , "Cao, Yahui" , "Su, Simei" References: <20200318170401.7938-5-jia.guo@intel.com> <20200416191944.23284-1-jia.guo@intel.com> <20200416191944.23284-4-jia.guo@intel.com> <103d4a2c-6145-8f19-2fb3-4c5b09704528@intel.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: Date: Thu, 16 Apr 2020 16:52:37 +0100 MIME-Version: 1.0 In-Reply-To: <103d4a2c-6145-8f19-2fb3-4c5b09704528@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [dpdk-dev v6 3/3] app/testpmd: add new types to RSS hash commands X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/16/2020 4:15 PM, Jeff Guo wrote: > hi, bernard > > > On 4/16/2020 7:16 PM, Iremonger, Bernard wrote: >> Hi Jeff, >> >>> -----Original Message----- >>> From: Guo, Jia >>> Sent: Thursday, April 16, 2020 8:20 PM >>> To: Iremonger, Bernard ; >>> orika@mellanox.com; Ye, Xiaolong ; Zhang, Qi Z >>> >>> Cc: dev@dpdk.org; Wu, Jingjing ; Cao, Yahui >>> ; Su, Simei ; Guo, Jia >>> >>> Subject: [dpdk-dev v6 3/3] app/testpmd: add new types to RSS hash >>> commands >>> >>> Add some new types, such as eth/l2-src-only/l2-dst-only/svlan/cvlan/ >>> l2tpv3/esp/ah/pfcp types into RSS hash commands, it could be used to >>> configure these rss input set by cmdline. >>> >>> Example testpmd commands was: >>> testpmd>flow create 0 ingress pattern eth / ipv4 / l2tpv3oip / end \ >>> actions rss types l2tpv3 end key_len 0 queues end / end >>> >>> Signed-off-by: Jeff Guo >>> --- >>> v6->v5: >>> add some missing part and refine commit log >>> --- >>> app/test-pmd/cmdline.c | 34 +++++++++++++++++++++++++++++----- >>> app/test-pmd/config.c | 15 ++++++++++++--- >>> 2 files changed, 41 insertions(+), 8 deletions(-) >>> >> The dpdk/doc/guides/testpmd_app_ug/testpmd_funcs.rst file needs to be updated for the new RSS values. >> Section 4.6.16. port config -RSS > > > ok, i think the doc is definitely need, and also the rss rule flow > setting. please expect it in the next version. Thanks. Hi Jeff, I have merged Bernard's "configure RSS hash" patch already to next-net, when sending next version, can you please rebase on top of latest next-net? Thanks, ferruh > > >>> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index >>> 863b567c1..4164767b8 100644 >>> --- a/app/test-pmd/cmdline.c >>> +++ b/app/test-pmd/cmdline.c >>> @@ -2270,9 +2270,13 @@ cmd_config_rss_parsed(void *parsed_result, >>> int ret; >>> >>> if (!strcmp(res->value, "all")) >>> -rss_conf.rss_hf = ETH_RSS_IP | ETH_RSS_TCP | >>> -ETH_RSS_UDP | ETH_RSS_SCTP | >>> -ETH_RSS_L2_PAYLOAD; >>> +rss_conf.rss_hf = ETH_RSS_ETH | ETH_RSS_S_VLAN | >>> +ETH_RSS_C_VLAN | ETH_RSS_IP | ETH_RSS_TCP | >>> +ETH_RSS_UDP | ETH_RSS_SCTP | >>> ETH_RSS_L2_PAYLOAD | >>> +ETH_RSS_L2TPV3 | ETH_RSS_ESP | ETH_RSS_AH | >>> +ETH_RSS_PFCP; >>> +else if (!strcmp(res->value, "eth")) >>> +rss_conf.rss_hf = ETH_RSS_ETH; >>> else if (!strcmp(res->value, "ip")) >>> rss_conf.rss_hf = ETH_RSS_IP; >>> else if (!strcmp(res->value, "udp")) >>> @@ -2299,6 +2303,22 @@ cmd_config_rss_parsed(void *parsed_result, >>> rss_conf.rss_hf = ETH_RSS_L4_SRC_ONLY; >>> else if (!strcmp(res->value, "l4-dst-only")) >>> rss_conf.rss_hf = ETH_RSS_L4_DST_ONLY; >>> +else if (!strcmp(res->value, "l2-src-only")) >>> +rss_conf.rss_hf = ETH_RSS_L2_SRC_ONLY; >>> +else if (!strcmp(res->value, "l2-dst-only")) >>> +rss_conf.rss_hf = ETH_RSS_L2_DST_ONLY; >>> +else if (!strcmp(res->value, "s-vlan")) >>> +rss_conf.rss_hf = ETH_RSS_S_VLAN; >>> +else if (!strcmp(res->value, "c-vlan")) >>> +rss_conf.rss_hf = ETH_RSS_C_VLAN; >>> +else if (!strcmp(res->value, "l2tpv3")) >>> +rss_conf.rss_hf = ETH_RSS_L2TPV3; >>> +else if (!strcmp(res->value, "esp")) >>> +rss_conf.rss_hf = ETH_RSS_ESP; >>> +else if (!strcmp(res->value, "ah")) >>> +rss_conf.rss_hf = ETH_RSS_AH; >>> +else if (!strcmp(res->value, "pfcp")) >>> +rss_conf.rss_hf = ETH_RSS_PFCP; >>> else if (!strcmp(res->value, "none")) >>> rss_conf.rss_hf = 0; >>> else if (!strcmp(res->value, "default")) @@ -2467,7 +2487,9 @@ >>> cmdline_parse_token_string_t cmd_config_rss_hash_key_rss_type = >>> "ipv4-other#ipv6#ipv6-frag#ipv6-tcp#ipv6- >>> udp#" >>> "ipv6-sctp#ipv6-other#l2-payload#ipv6-ex#" >>> "ipv6-tcp-ex#ipv6-udp-ex#" >>> - "l3-src-only#l3-dst-only#l4-src-only#l4-dst- >>> only"); >>> + "l3-src-only#l3-dst-only#l4-src-only#l4-dst- >>> only#" >>> + "l2-src-only#l2-dst-only#s-vlan#c-vlan#" >>> + "l2tpv3#esp#ah#pfcp"); >>> cmdline_parse_token_string_t cmd_config_rss_hash_key_value = >>> TOKEN_STRING_INITIALIZER(struct cmd_config_rss_hash_key, key, >>> NULL); >>> >>> @@ -2478,7 +2500,9 @@ cmdline_parse_inst_t cmd_config_rss_hash_key = >>> { >>> "ipv4|ipv4-frag|ipv4-tcp|ipv4-udp|ipv4-sctp|ipv4-other|" >>> "ipv6|ipv6-frag|ipv6-tcp|ipv6-udp|ipv6-sctp|ipv6-other|" >>> "l2-payload|ipv6-ex|ipv6-tcp-ex|ipv6-udp-ex|" >>> -"l3-src-only|l3-dst-only|l4-src-only|l4-dst-only " >>> +"l3-src-only|l3-dst-only|l4-src-only|l4-dst-only|" >>> +"l2-src-only|l2-dst-only|s-vlan|c-vlan|" >>> +"l2tpv3|esp|ah|pfcp " >>> "", >>> .tokens = { >>> (void *)&cmd_config_rss_hash_key_port, diff --git >>> a/app/test-pmd/config.c b/app/test-pmd/config.c index >>> 71aeb5413..c8196e47a 100644 >>> --- a/app/test-pmd/config.c >>> +++ b/app/test-pmd/config.c >>> @@ -75,10 +75,15 @@ static const struct { }; >>> >>> const struct rss_type_info rss_type_table[] = { >>> -{ "all", ETH_RSS_IP | ETH_RSS_TCP | >>> -ETH_RSS_UDP | ETH_RSS_SCTP | >>> -ETH_RSS_L2_PAYLOAD }, >>> +{ "all", ETH_RSS_ETH | ETH_RSS_IP | ETH_RSS_TCP | ETH_RSS_UDP | >>> +ETH_RSS_SCTP | ETH_RSS_L2_PAYLOAD | ETH_RSS_L2TPV3 | >>> +ETH_RSS_ESP | ETH_RSS_AH | ETH_RSS_PFCP}, >>> { "none", 0 }, >>> +{ "eth", ETH_RSS_ETH }, >>> +{ "l2-src-only", ETH_RSS_L2_SRC_ONLY }, >>> +{ "l2-dst-only", ETH_RSS_L2_DST_ONLY }, >>> +{ "s-vlan", ETH_RSS_S_VLAN }, >>> +{ "c-vlan", ETH_RSS_C_VLAN }, >>> { "ipv4", ETH_RSS_IPV4 }, >>> { "ipv4-frag", ETH_RSS_FRAG_IPV4 }, >>> { "ipv4-tcp", ETH_RSS_NONFRAG_IPV4_TCP }, @@ -108,6 +113,10 >>> @@ const struct rss_type_info rss_type_table[] = { >>> { "l3-dst-only", ETH_RSS_L3_DST_ONLY }, >>> { "l4-src-only", ETH_RSS_L4_SRC_ONLY }, >>> { "l4-dst-only", ETH_RSS_L4_DST_ONLY }, >>> +{ "l2tpv3", ETH_RSS_L2TPV3 }, >>> +{ "esp", ETH_RSS_ESP }, >>> +{ "ah", ETH_RSS_AH }, >>> +{ "pfcp", ETH_RSS_PFCP }, >>> { NULL, 0 }, >>> }; >>> >>> -- >>> 2.20.1 >> Regards, >> >> Bernard.