From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
Cc: Harry van Haaren <harry.van.haaren@intel.com>
Subject: Re: [dpdk-dev] [PATCH] raw/ioat: fix bus requiring virtual addressing when no devs
Date: Thu, 6 May 2021 16:16:46 +0100 [thread overview]
Message-ID: <a277a69b-457b-3242-9028-cc86c347f58c@intel.com> (raw)
In-Reply-To: <20210506150908.797110-1-bruce.richardson@intel.com>
On 06-May-21 4:09 PM, Bruce Richardson wrote:
> If after a bus scan, there are no devices using a particular bus, then
> that bus should not be taken into account when deciding whether DPDK
> should be run in VA or PA addressing mode. This becomes an issue when
> the DSA bus driver code is used on a system without an IOMMU. The PCI
> bus correctly reports that it only works in PA mode, while the DSA bus -
> also correctly - reports that it works only in VA mode. The difference
> is that there will be no devices found in a scan for the DSA bus, since
> the kernel driver can only present those to userspace in the presence of
> an IOMMU.
>
> While we could change DSA instance to always report that it does not
> care about the addressing mode, this would imply that it could be used
> with DPDK in PA mode which is not the case. Therefore, this patch
> changes the driver to report DC (don't care) in the case where no
> devices are present, and VA otherwise.
>
> NOTE: this addressing mode use of VA-only applies only in the case of
> using DSA through the idxd kernel driver. The use of DSA though vfio-pci
> is unaffected and works as with other PCI devices.
>
> Fixes: b7aaf417f936 ("raw/ioat: add bus driver for device scanning automatically")
>
> Reported-by: Harry van Haaren <harry.van.haaren@intel.com>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
Tested-by: Anatoly Burakov <anatoly.burakov@intel.com>
--
Thanks,
Anatoly
next prev parent reply other threads:[~2021-05-06 15:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 15:09 Bruce Richardson
2021-05-06 15:16 ` Burakov, Anatoly [this message]
2021-05-06 15:27 ` Van Haaren, Harry
2021-05-07 12:30 ` Walsh, Conor
2021-05-10 10:37 ` Thomas Monjalon
2021-05-06 15:27 ` Burakov, Anatoly
2021-05-06 15:34 ` Bruce Richardson
2021-05-10 10:18 ` Thomas Monjalon
2021-05-10 11:20 ` Bruce Richardson
2021-05-10 12:02 ` Thomas Monjalon
2021-05-10 10:13 ` Thomas Monjalon
2021-05-10 10:22 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a277a69b-457b-3242-9028-cc86c347f58c@intel.com \
--to=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).