From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B2E544326B; Thu, 2 Nov 2023 08:33:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A00224029E; Thu, 2 Nov 2023 08:33:45 +0100 (CET) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mails.dpdk.org (Postfix) with ESMTP id E2B2540282 for ; Thu, 2 Nov 2023 08:33:43 +0100 (CET) Received: from kwepemi500020.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4SLbBl30RVz1P7gR; Thu, 2 Nov 2023 15:30:39 +0800 (CST) Received: from [10.67.121.175] (10.67.121.175) by kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Thu, 2 Nov 2023 15:33:41 +0800 Message-ID: Date: Thu, 2 Nov 2023 15:33:40 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v8 10/10] app/testpmd: add RSS hash algorithms display To: Ferruh Yigit , , Aman Singh , Yuying Zhang CC: , , References: <20230315110033.30143-1-liudongdong3@huawei.com> <20231101074039.3088716-1-haijie1@huawei.com> <20231101074039.3088716-11-haijie1@huawei.com> <8790bba9-cc45-48c5-9f2a-c191d5d64800@amd.com> From: Jie Hai In-Reply-To: <8790bba9-cc45-48c5-9f2a-c191d5d64800@amd.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.175] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemi500020.china.huawei.com (7.221.188.8) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2023/11/1 21:42, Ferruh Yigit wrote: > On 11/1/2023 7:40 AM, Jie Hai wrote: >> Add the command "show port X rss-hash algorithm" to display >> the RSS hash algorithms of port X. An example is shown: >> >> testpmd> show port 0 rss-hash algorithm >> RSS algorithm: >> toeplitz >> >> Signed-off-by: Jie Hai >> Acked-by: Huisong Li >> --- >> app/test-pmd/cmdline.c | 29 ++++++++++++++++++++++++----- >> app/test-pmd/config.c | 29 ++++++++++------------------- >> app/test-pmd/testpmd.h | 2 +- >> > > Can you please update testpmd documentation, > 'doc/guides/testpmd_app_ug/testpmd_funcs.rst', too? > > <...> Thanks, will add. > >> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c >> index b9fdb7e8f162..23fb4f8aa781 100644 >> --- a/app/test-pmd/config.c >> +++ b/app/test-pmd/config.c >> @@ -1504,24 +1504,7 @@ rss_config_display(struct rte_flow_action_rss *rss_conf) >> printf(" %d", rss_conf->queue[i]); >> printf("\n"); >> >> - printf(" function: "); >> - switch (rss_conf->func) { >> - case RTE_ETH_HASH_FUNCTION_DEFAULT: >> - printf("default\n"); >> - break; >> - case RTE_ETH_HASH_FUNCTION_TOEPLITZ: >> - printf("toeplitz\n"); >> - break; >> - case RTE_ETH_HASH_FUNCTION_SIMPLE_XOR: >> - printf("simple_xor\n"); >> - break; >> - case RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ: >> - printf("symmetric_toeplitz\n"); >> - break; >> - default: >> - printf("Unknown function\n"); >> - return; >> - } >> + printf(" function: %s\n", rte_eth_dev_rss_algo_name(rss_conf->func)); >> > > > Above modification can be moved to the patch that adds > 'rte_eth_dev_rss_algo_name()'. > Thanks, will move. > .