From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 9173F2C0A for ; Fri, 16 Sep 2016 09:32:21 +0200 (CEST) Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9BD887F7B4; Fri, 16 Sep 2016 07:32:20 +0000 (UTC) Received: from sopuli.koti.laiskiainen.org (vpn1-5-186.ams2.redhat.com [10.36.5.186]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u8G7WHkq021735; Fri, 16 Sep 2016 03:32:18 -0400 To: Thomas Monjalon , Jan Viktorin , "Hunt, David" , Shreyansh Jain References: <1451682326-5834-1-git-send-email-viktorin@rehivetech.com> <84c34eed-b2cb-5cbe-883c-dbbe3741e35f@intel.com> <20160915150930.6e381c85@pcviktorin.fit.vutbr.cz> <5302721.bs0Wxs4nOl@xps13> Cc: dev@dpdk.org, hemant.agrawal@nxp.com From: Panu Matilainen Message-ID: Date: Fri, 16 Sep 2016 10:32:17 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <5302721.bs0Wxs4nOl@xps13> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Fri, 16 Sep 2016 07:32:21 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v3 02/15] eal/soc: add rte_eal_soc_register/unregister logic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2016 07:32:21 -0000 On 09/15/2016 05:09 PM, Thomas Monjalon wrote: > 2016-09-15 15:09, Jan Viktorin: >> On Thu, 15 Sep 2016 14:00:25 +0100 >> "Hunt, David" wrote: >> >>>> new file mode 100644 >>>> index 0000000..56135ed >>>> --- /dev/null >>>> +++ b/lib/librte_eal/common/eal_common_soc.c >>>> @@ -0,0 +1,56 @@ >>>> +/*- >>>> + * BSD LICENSE >>>> + * >>>> + * Copyright(c) 2016 RehiveTech. All rights reserved. >>>> + * All rights reserved. >>> >>> Duplicate "All rights reserved" >> >> This is present in many source files in DPDK... I don't know why. >> >> lib/librte_eal/common/eal_common_pci.c >> lib/librte_eal/common/eal_common_dev.c >> ... > > It would deserve a dedicated thread to discuss legal sense of these things. > I'm not a lawyer but I think "All rights reserved." has no real sense. > From a layman (such as myself) perspective it indeed seems totally ludicrous in the context of this particular license :) Whether it makes more sense to lawyers I wouldn't know, but as for the background: it's present in both 2- and 3-clause BSD licenses so *one* of them is probably best left alone. According to https://fedoraproject.org/wiki/Licensing:BSD, in the 3-clause BSD license "All rights reserved" is on a line of its own. In the other variants it follows the copyright holder. So that's probably where the duplicates originate from. - Panu -