From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E44942DAE; Tue, 4 Jul 2023 03:40:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4D6B240F18; Tue, 4 Jul 2023 03:40:15 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 7F76F40E03 for ; Tue, 4 Jul 2023 03:40:13 +0200 (CEST) Received: from dggpeml100024.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Qw5724hPjzTkyM for ; Tue, 4 Jul 2023 09:39:10 +0800 (CST) Received: from [10.67.100.224] (10.67.100.224) by dggpeml100024.china.huawei.com (7.185.36.115) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 4 Jul 2023 09:40:11 +0800 Subject: Re: [PATCH v4 0/9] expand list of optional libraries To: Bruce Richardson , References: <20230622134840.3225975-1-bruce.richardson@intel.com> <20230623150708.2203918-1-bruce.richardson@intel.com> From: fengchengwen Message-ID: Date: Tue, 4 Jul 2023 09:40:10 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20230623150708.2203918-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.100.224] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml100024.china.huawei.com (7.185.36.115) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Series-acked-by: Chengwen Feng On 2023/6/23 23:06, Bruce Richardson wrote: > DPDK still has many libraries which cannot be disabled as part of a > build. With the ongoing work to make it easier to only build a subset > of the libraries in DPDK, we can also work to expand the list of > libraries which can be enabled/disabled as desired. > > This patch addresses a number of the "low-hanging fruit" libraries, > where only the unit test builds need minor changes to support > making the library optional. The rest of the build system is already > well set up for selective disabling of libraries. > > For better support of enabling components, especially those more > integrated into DPDK unit tests, rework of the test meson.build file > is likely needed. For example, it could probably be better rewritten > to use a dictionary of files and the dependencies of each file, and > the unit test commands each provides. However, such rework is a > significant effort, and outside the scope of this patchset. > > V4: > - fix more issues with disabling eventdev: > * ensure dlb2 driver doesn't directly reference the static lib > * ensure l3fwd can be built using makefiles without eventdev > * remove dependency on eventdev for unit tests like pdump that > don't actually need it. > > V3: > - rebase on top of main. > - make eventdev an optional dependency of l3fwd > - Fix incorrect define reference - RTE_LIB_IP_FRAG vs RTE_IP_FRAG > > V2: fix checkpatch issues, since checkpatch doesn't like empty commit > messages (even if the title is pretty self-explanatory!) > > Bruce Richardson (9): > examples/l3fwd: make eventdev an optional dependency > event/dlb2: skip configuration if no eventdev lib > build: make most device classes optional > build: make membership library optional > build: make bpf library optional > build: make efd library optional > build: make distributor library optional > build: make fragmentation library optional > build: make reorder library optional > > app/test/meson.build | 89 +++++++++++++--------- > drivers/event/dlb2/meson.build | 2 +- > examples/l3fwd/l3fwd_em.c | 2 + > examples/l3fwd/l3fwd_em_hlm.h | 2 + > examples/l3fwd/l3fwd_event.c | 2 + > examples/l3fwd/l3fwd_event.h | 7 +- > examples/l3fwd/l3fwd_event_generic.c | 2 + > examples/l3fwd/l3fwd_event_internal_port.c | 2 + > examples/l3fwd/l3fwd_fib.c | 2 + > examples/l3fwd/l3fwd_lpm.c | 2 + > examples/l3fwd/main.c | 65 ++++++++++++---- > examples/l3fwd/meson.build | 5 +- > lib/meson.build | 13 ++++ > 13 files changed, 143 insertions(+), 52 deletions(-) > > -- > 2.39.2 > > . >