From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-CO1-obe.outbound.protection.outlook.com (mail-eopbgr690040.outbound.protection.outlook.com [40.107.69.40]) by dpdk.org (Postfix) with ESMTP id DA94F1B113 for ; Fri, 28 Sep 2018 13:13:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tpYWUkz2eIW7XlRpXKxJOyxoj6TSk1gYN9++V+z8kpg=; b=LTsbyoiAv+3BL4ECic1kIfBiOOtqg7AIQwilwlu13AaXWFLU0qIuu0ADY7rO1x+pyy9XuorafEi+NqO2mBrCbVeb0/htSoyNOPE3ZGxnq8ZYB+PNd6iojlmCEuSpDMqJN0ztZBGfizbZ0CZ1xQeXd2oL+8TrKhQrKSR/shJCA9g= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Anoob.Joseph@cavium.com; Received: from [10.88.100.222] (115.113.156.2) by BN7PR07MB4900.namprd07.prod.outlook.com (2603:10b6:408::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1143.18; Fri, 28 Sep 2018 11:13:22 +0000 From: "Joseph, Anoob" To: Fiona Trahe Cc: Akhil Goyal , Anoob Joseph , Pablo de Lara , Thomas Monjalon , Murthy NSSR , Jerin Jacob , Narayana Prasad , dev@dpdk.org, Ankur Dwivedi , Nithin Dabilpuram , Ragothaman Jayaraman , Srisivasubramanian S , Tejasree Kondoj References: <1528476325-15585-1-git-send-email-anoob.joseph@caviumnetworks.com> <1536033560-21541-1-git-send-email-ajoseph@caviumnetworks.com> <1536033560-21541-10-git-send-email-ajoseph@caviumnetworks.com> <0b2cecb1-f055-61d6-3c10-802d0d647b96@nxp.com> <21787cc6-1151-53e9-a86b-aa008b421fb1@caviumnetworks.com> Message-ID: Date: Fri, 28 Sep 2018 16:44:20 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [115.113.156.2] X-ClientProxiedBy: MA1PR0101CA0019.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:21::29) To BN7PR07MB4900.namprd07.prod.outlook.com (2603:10b6:408::10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2b6253b3-c10e-426d-cca7-08d625336cd0 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BN7PR07MB4900; X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4900; 3:cryl/GmF/6Kxt6qgPgi6fPH1OvFR1kQs6cWUn6uZvGlM2erNNWG9SDSOmZS6W5uttknGigmm32JWXqRerNysmT8LCUYHutCE1AA4zFAXXhPsl4rA4aiPoAU2Zo1+oAT2fEEFSuJBvBFoQOwo+6LhB9szsJ+bJcNdx+DzPfBuKgcX01GFpCKodkczb5UBfClXqvsbYczTm/8WySeTSzKuazIIUp5HFcSvE6MZiS4ZLXIFwVnGjvQzT7WPQr0I/gOX; 25:fpmbIU6pTCo7ToMaJu8cOgO63PVSHuQ5relrIkOlnbqSE8O1phShc+xPtO0SW06N9XD/ErCmYpIm5Do5ZMC9BPnynKatH+SybLlaclHV0AJ80KIwTXIR4Cj9zcltIyHW20eRdy+cUC8byZijleqCntdgHfo6RrlxXkzFGAAODWcvu3/7u9ug1pt/XLf1VBd8872x5zWsmIzFFUgjrqc49qoptsDPaU4KZ66M6AlHmwN1ADTUPWPSt7XBA7HoEbkrjwwVnKFqwV1/XA9JfwIPFMnRjzO+guPy4UhOmHp+NUvc8gKiUDx2PPWJjs4uThpiPQ078bzKG7V3LsURDdBVsw==; 31:AWr+M0fODSfQU2MTODNyhQn+S6+FVkqeDGdNx2dUW8/X3OGMoNsi2s9F73CXNxxfZ41eoVqErhrcq8OH/GpvoLsx0zCWobkKxcgn9WEcZ/R7i0SeoDotGFGGZXnKTGe0u8sGyN1pAO0+nIx7FQY4I+eiO5uWBbq4viqvA7C+fDE0O5r7ZhhNLlnTrY5TmjSfTS+1W7cOaQ2gr9uVDY0i/5PW2+JRMDODZVEw9HHO3rE= X-MS-TrafficTypeDiagnostic: BN7PR07MB4900: X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4900; 20:a5dJMlWEvt5QNGzaD8MZA7iYqDjGjwOCpLzCERKFxVNpnzDhBxaW0Oj0OGYJwFgu2kYyEY0YXZSb728wzaQRFWtq0xiIunEnWJ61gqw9LpOeDDlgQobMeQvInJz4o1kohq1ZFt2YZL0Y6hMcw0d2vVLn2eRI1WRiqgrywLUQSiOTJpYGqfZOL/VmP87RM8JGFPE1lzpo42HaxDHqqiDD7ZGsOw7m/KfTbO9+KCVF64/OlD2ifq1ysQ6fcVf0uHVePwhmUu3XNo3PCn0mCmeUTcguWOoxIqX6vIkdF+3IKFVKe/QjRD82Kco3XAnTLuFqD6jTeTd+gXPAbUO9sWC0EYtTChdkh49FUmJ/R/P/5d+y+xKXvdhVYwrXFwX8IMCmuyqI6hrGOKkq5QeAIsQGXpF2wK2TY6agS96Tv2WX9LadhJsF9GJP3wlwlEsvbVWaSRnaiqBQvduq8HjpzMZY0jzQfXb35H3Q1ybmIfsCb0HQEa1mwFwYnRJMTvKZTxSV8edGNte4AQyoLlC2nVU1GVhjR9wuKVfORWPV8ZPWYfXxNrTz2e/4p8gBHEvlxsdL/f1/6Y828fIU62su72ZjGYgCBhLa1+A8UL4TyxpdtrQ=; 4:VKLXCPwJx+IRbsUiVnkXaHAy31yRD4NBfqBQAAziubIvDQVEbuuT4RJ3lm7nXoWjmo8rBdX8MwL2OHkrwQX94rfsy9u245UJxsEvF2rPrC1GUfQpEAJUGssW+wgCqbXTfIqwq+cv/7eNa2ZFpeSGQHW0tgpz4VB2DxOJWnZkC2xXTOOuABATCWrse4r9022h5xIcWABbQmIlDzLu4aip3P9bWh9GqrnDmzaaATOygfB+2ruh+dcEMxMvF6Uh9ttjhESw8ZbEt3rdEPIXk5TFwQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3231355)(944501410)(52105095)(93006095)(3002001)(149066)(150057)(6041310)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(201708071742011)(7699051); SRVR:BN7PR07MB4900; BCL:0; PCL:0; RULEID:; SRVR:BN7PR07MB4900; X-Forefront-PRVS: 0809C12563 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(346002)(376002)(136003)(39860400002)(396003)(366004)(199004)(189003)(54906003)(58126008)(316002)(8936002)(68736007)(6486002)(3260700006)(36756003)(4326008)(97736004)(67846002)(229853002)(65826007)(6916009)(6306002)(23676004)(2486003)(93886005)(52116002)(25786009)(16576012)(5660300001)(966005)(52146003)(42882007)(53936002)(478600001)(81166006)(8676002)(81156014)(16526019)(14444005)(34290500001)(6116002)(65956001)(50466002)(65806001)(956004)(6246003)(3846002)(2870700001)(486006)(66066001)(446003)(7736002)(2616005)(476003)(305945005)(106356001)(105586002)(26005)(2906002)(53546011)(76176011)(386003)(31696002)(31686004)(64126003)(47776003)(77096007)(72206003)(107886003)(11346002); DIR:OUT; SFP:1101; SCL:1; SRVR:BN7PR07MB4900; H:[10.88.100.222]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjdQUjA3TUI0OTAwOzIzOkdML2ViS2UyWTJNdTdBMVQ4WmZxNlpndHo2?= =?utf-8?B?UVJBVU04TGxjdU94UDcxSnYzVklPeTB6My94MG5MclcyZVhkbE9jL0ZKVDZt?= =?utf-8?B?YklwQmFNdThRbk8yK01Nckh1Tnc3bGxtMzhtZUs3eGorcnZlZjJPbHdwTUF6?= =?utf-8?B?SU16dEgyS1VmR0RUT1dJOWQrRmY5cmlRQ2dVQXdsK1ZuMkF2QTdQVnNwUHBa?= =?utf-8?B?NFM0ZkhtVzRySGlWVWZPNXhBRjR3SHk1WlRqblBrL252aUdEdjQ1SG93amIr?= =?utf-8?B?VGU2QUkvQlNJa2EzVHBCRDRzV1c5a1MzcGFjQmlPaXQyMk5RaEtjMlhoVVhw?= =?utf-8?B?WDZWNnhQR3RSYlY2d0VCcmp2Y3gzZ0IrUS9oamgvRk90VzBGUzhJdlZrcnVI?= =?utf-8?B?dEdFWFB4VklpN05KWk9kTHZBWlVUaGk2QnlaOXEvenpxY21HQ3ZaOCtkYlls?= =?utf-8?B?RkNpNk1ZN2gya0xFWGtqMGpCOFp4aFlkQUFlRnc0MUd2RXREODlNMlFEWFpq?= =?utf-8?B?UUNOZDk0VnRBRlJsUXZHRThJSXRyRkorakswQXdENXcrRG16WllFUUV2ek8x?= =?utf-8?B?TkRkcU4xNXZwUTdza0lncWd6TVFYalhYeGZId3I2RXdRbmZTcSthYklFME1E?= =?utf-8?B?aWhyeHh2Szhlb043UWtRNklOTGZhaWIxODZOZnBTKzB5MnFvY0NmMmxhWXJv?= =?utf-8?B?RkI0Q3h0aEJ4YlNySXlwc0RPYkRmRENsbGNyQ2tMOEcwWVE1R1dpQkVsV0tk?= =?utf-8?B?b203ckkvYjNkLzcxQlExcHE3ZGJrNUMxRkFtNGxuR0NuR3l6RkxQTFJoQWJZ?= =?utf-8?B?ZTZPamNiK2F4YW5YOCsvTkd2L0x6ek1wRGVmMFpjSW44ODZNcnVPUHNUblc4?= =?utf-8?B?U2l3aUlLRzh2OUNRVWY1b3JnVHp3dm91RG5MWTdqNUVOZkg1NXU5VmRXcWpE?= =?utf-8?B?TXFBT1hOanZESG0vZCt2MFRNWUJXL3BPL05QUjFzVjNqZW0zckI4U0d5VkNs?= =?utf-8?B?TUVMWS9weU5uVUdUUy9lSFpObFYwQVF1N1poSmowL0grRmI5L3pqRVJtd1pQ?= =?utf-8?B?MkZrZW9xV0pYeXVteHFwYWhFSEJ5R0JrdStlWnRMN1dXeEJXYk9mVUdMb3ND?= =?utf-8?B?N3JzV1IxZHlhTERxa2p2L3hmN3FpWHpRUDF6d2ZZOG1Pcmt3bG1JbjRwMWUz?= =?utf-8?B?VHdMaDAyL3A4QSsvKy9qVG1DYVNZUTJYN3d2Y2RUcHJZZmpGKzhSVk1DQ0ZS?= =?utf-8?B?WVN6VnNlT0lOTWhRVk0wZnJ3eStFZjZKZ0hnTDJKSThpd0pLUHBHcjQ5RFhQ?= =?utf-8?B?MTB0cGJvSFFFVmJGS1BtOWU5Q0ZhTGhIN3BlT3MzZ3U3c1pqMERRUk1hcno5?= =?utf-8?B?M1MrMkRmRHR2WUtDNmc2UkgrZUpOK0R1VFJGeHM2TGRiZmZhZStWT0Fhc0xv?= =?utf-8?B?VmJmQWt5ZHhkTDR5eVIxNHQ3alZuSGVlbnQwMUJpaTVqLzlJTlEwWDZadHJT?= =?utf-8?B?T0llL3FURGVZRmhEUUhTUWJza1ZhV3ZxNngzYVFxWnpHUnpPTlhFRzBnOStz?= =?utf-8?B?N1dmTldhcFU3NFBFaWEwTjlDTHVjV3lML2c2MklkN01DVlJjcEd6dm9tSS9F?= =?utf-8?B?TWpiTVBGTTJJTDRma1RqRXNyb0RsbE5XUHNGSmJ4dDNLL2tWRHhhbEZ2MGxy?= =?utf-8?B?Y0MrcVFycThRT3RmRHhoM0JjejZVMEdtVU9Bb2dQaTJSam9KN0NmTXFjTzMv?= =?utf-8?B?QU1CamFuWWs5d1FnUm9NMXEzNmtiY25td0FybGN3aTZPTGtVZitUamZwZDZs?= =?utf-8?B?blh0Z05QVHcwMEJXNDF1VkZsSE9Gb1RRa2lNcVpIRTdmVjlkdG0zRTlsOHFm?= =?utf-8?B?U0E4bmlsbm1YMlJiOFI0cmJ5NlpNL2NWbjhTSWp0YmxOUjIzVjdZZjJLNXhJ?= =?utf-8?B?OFNWMmo0bEpzandkQnhQMHIyempMQVVxbHVCM1RaYzZsd3VqRHV2VWpzWjNj?= =?utf-8?B?NmpaQVBESnZrLzhIZTBzb1ZCUVgyRUc4VVhLSmE5S29GUTRiRSt0ZE51dHpP?= =?utf-8?B?Ylpyd3ZFWDhqeExBSzF5dTc4elYvNGsybEZtTkc1UWczWjNKUURCT1NrbmhD?= =?utf-8?Q?U/BpV26dGy7n7W5bRqFX1Zw=3D?= X-Microsoft-Antispam-Message-Info: vAGZzCk8jdK0BYBz7xSF1xz1LdvMcH0YTxBNt0z5k89p4lYnVaf0ui7V3VCb0NQfxBB5Slelh/3n5yZz39lWmdp2o/Oy/lcJxvXZrJJtqC/JF1E4Rbhwhq9ylqItghzB24lesHDfJzOByqf2OgHsvv3US3vRe16WCR2TCkwjEb864FLpFYR2PqrWScne7atjCIuAsk4JSCCJxf4eDSUlVps0NW7rH6h15ZRIstT+Zjg9yb3b1Fd6Jj5ePM3GeRsBvVBt4XOt2Xv45jvXTsE6prlrbu561OeVvZEKoNrPJffNlgccCQTqteUL7vMuRoMHtA/wi6fWHPvRI14rL7vcDOwnU13IfkXou9RzaNd8wdU= X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4900; 6:MMFWsrtBZIJ0WSg25bh1KIDQzJI2nMjK5ugTadsXwYjTVF5mtFUuXbULSxgo4AU3yb+pcXWcYLgyFYgn61cGA9GBunBlFCe/xwY2rFz66pDuBlLQacNvIZSSEi/+LZ0fwyW/S5ceigEEMKTH7BGMQciptEzw6/WD/vfrW6YiqE0p6A6QPWs3WqPK5MswHsJ9vKrk9KNzYkXvxzQ+44asylEJt6ZJW32t6szyH6KU6cwX00yTXOpt2CbxDtMTjDLx5OKEFv1n48y+ptzm+lF+8ch9lujnp9gcA7FK7054F6kcCZW0iGk9H8bgtSTQUDpOf9+n/UG/B84t8SvZp7XiIl1xpfpaxIZwOzbZyUwq0vLqk0O9LhwDhIcgfvmalKzhPkTL4ZdVFkxhz3pLba0ayCJdqaVhTt2dL8dNPimiM7oV30vfjBMVYPeqIUkhEX0P+19cY4beXRLFNbYWJdgv9g==; 5:ZQBhox/mdYkZP0llPz8cSmI1SuETUIg/P0FtQlcoPpf6mpmHOAytqlJSl9Buq+XGMVJAaSEpCEeZ92tSCHBqngbVJfuK5EJ5t2TwiI9EQtp5efP+ZHoI2Ott7Hyb6PwKsq+j2VNWDnt0v4+YjZ4ClSx/9vDQQCBVPboxCqtye3U=; 7:1XjxE0MhRbzNlnD+NCTtZpMagX7N7mShIANa8vPY5qxiRdkweov4/MjXdj3bXW+V86ZiB6yPQPfGCVfOa/L6WsNFR6acVqAFCZY47M9y1pabb6qaylDAwLbbWXxcJTqYW+4YH16thHYlWB7VL5hX+rRzdYNrSv6DLClRSHKg4aqefuzTSLruxhcg8UY/mceViqz7q/qIvbUV8bWuTrg0zCeieMLZcZbN94TszrJ9ySbv+2rjHpFt/667Y9FRi/4y SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2018 11:13:22.8982 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2b6253b3-c10e-426d-cca7-08d625336cd0 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR07MB4900 Subject: Re: [dpdk-dev] [PATCH v2 09/33] crypto/octeontx: adds symmetric capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Sep 2018 11:13:35 -0000 Hi Fiona, Did you get a chance to look at this? Thanks, Anoob On 24-09-2018 17:06, Joseph, Anoob wrote: > Hi Fiona, > > Can you please comment on this? > > We are adding all capabilities of octeontx-crypto PMD as a macro in > otx_cryptodev_capabilites.h file and then we are using it from > otx_cryptodev_ops.c. This is the approach followed by QAT crypto PMD. > As per my understanding, this is to ensure that cryptodev_ops file > remains simple. For other PMDs with fewer number of capabilities, the > structure can be populated in the .c file itself without the size of > the file coming into the picture. > > But this would cause checkpatch to report error. Akhil's suggestion is > to move the entire definition to a header and include it from the .c > file. I believe, the QAT approach was to avoid variable definition in > the header. What do you think would be a better approach here? > > Thanks, > Anoob > On 17-09-2018 18:05, Joseph, Anoob wrote: >> Hi Akhil, >> >> On 17-09-2018 17:31, Akhil Goyal wrote: >>> External Email >>> >>>> diff --git a/drivers/crypto/octeontx/otx_cryptodev_ops.c >>>> b/drivers/crypto/octeontx/otx_cryptodev_ops.c >>>> index d25f9c1..cc0030e 100644 >>>> --- a/drivers/crypto/octeontx/otx_cryptodev_ops.c >>>> +++ b/drivers/crypto/octeontx/otx_cryptodev_ops.c >>>> @@ -10,9 +10,15 @@ >>>>   #include "cpt_pmd_logs.h" >>>> >>>>   #include "otx_cryptodev.h" >>>> +#include "otx_cryptodev_capabilities.h" >>>>   #include "otx_cryptodev_hw_access.h" >>>>   #include "otx_cryptodev_ops.h" >>>> >>>> +static const struct rte_cryptodev_capabilities otx_capabilities[] = { >>>> +     OTX_SYM_CAPABILITIES, >>>> +     RTE_CRYPTODEV_END_OF_CAPABILITIES_LIST() >>>> +}; >>>> + >>> >>> better to have otx_capabilities structure defined in the >>> otx_cryptodev_capabilities.h >>> >>> I don't see any value addition of creating a macro in one file using >>> in a separate structure in another file >>> >>> which doesn't have anything new in that structure. It would also >>> give checkpatch error. >>> >>> You can directly have a capability structure without the #define. >> This was the convention followed in qat driver. >> >> https://git.dpdk.org/dpdk/tree/drivers/crypto/qat/qat_sym_capabilities.h >> >> I guess it was to avoid variable definition in header. May be Pablo >> too can comment on this. I'll make the change accordingly. >> >> Thanks, >> Anoob >> >