From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 802C6A034F; Wed, 13 May 2020 08:51:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CDDC61C1C9; Wed, 13 May 2020 08:51:10 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id DEF8A1BFD3 for ; Wed, 13 May 2020 08:51:08 +0200 (CEST) IronPort-SDR: Wlm3MQUr01YV3q4JnoI8Sy50zEDu6vduUs6CuNsn3w40LVIOmgsBxm59CAWmRpYSLsy4VQm1el q8qBlVuKZCPg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2020 23:51:07 -0700 IronPort-SDR: 1S9PJCmmIWSKUZZD+7unBRFdSAZEeHushH1wemWB8OcxecIESY1Y3O+ohlnN2Kfh+MPfjHXnGZ g6pqHELLriNQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,386,1583222400"; d="scan'208";a="286921573" Received: from jguo15x-mobl.ccr.corp.intel.com (HELO [10.67.68.157]) ([10.67.68.157]) by fmsmga004.fm.intel.com with ESMTP; 12 May 2020 23:51:06 -0700 To: Chenxu Di , dev@dpdk.org Cc: beilei.xing@intel.com References: <20200507030928.42082-1-chenxux.di@intel.com> <20200513022645.37302-1-chenxux.di@intel.com> From: Jeff Guo Message-ID: Date: Wed, 13 May 2020 14:51:05 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200513022645.37302-1-chenxux.di@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: fix out of bounds read issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" hi, chenxu On 5/13/2020 10:26 AM, Chenxu Di wrote: > This patch fixes (out-of-bounds read) coverity issue. > > Coverity issue: 357699 > Coverity issue: 357694 > Fixes: feaae285b342 ("net/i40e: support hash configuration in RSS flow") > > Signed-off-by: Chenxu Di > --- > drivers/net/i40e/i40e_ethdev.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c > index 749d85f54..c2d5c6835 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -13179,6 +13179,9 @@ i40e_rss_config_hash_function(struct i40e_pf *pf, > break; > } > > + if (i == UINT64_BIT) > + return 0; > + Should this function need to return none zero value and show error info out, or said should considerate "out of bound" as a configure failed. > for (j = I40E_FILTER_PCTYPE_INVALID + 1; > j < I40E_FILTER_PCTYPE_MAX; j++) { > if (pf->adapter->pctypes_tbl[i] & (1ULL << j)) > @@ -13311,6 +13314,9 @@ i40e_rss_clear_hash_function(struct i40e_pf *pf, > break; > } > > + if (i == UINT64_BIT) > + return 0; > + > for (j = I40E_FILTER_PCTYPE_INVALID + 1; > j < I40E_FILTER_PCTYPE_MAX; j++) { > if (pf->adapter->pctypes_tbl[i] & (1ULL << j))