Re: [dpdk-dev] [dpdk-techboard] Consider improving the DPDKcontribution processes

["Burakov, Anatoly" <anatoly.burakov@intel.com>]

On 26-May-20 11:33 AM, Thomas Monjalon wrote:

> 
>>> And therein lies the problem: Thomas (David, etc.) doesn't look at every
>>> area of the code, he relies on us to do it. However, *he* is doing the
>>> committing, and fixing up patches, etc. - so, i can't really say things
>>> like, "hey, your indentation's wrong here, but Thomas will fix it on
>>> apply" because that's me pushing more work onto Thomas, something i
>>> don't think i have the moral right to do :)
> 
> You can send a new version of the patch with the details fixed,
> publicly readable, reviewable, and ready to be pushed.

To be completely honest, that's something that's never occurred to me, 
and it sounds like a great idea. The downside is that taking over 
someone else's patch and resubmitting it may be taken the wrong way :) 
(and could also lead to confusion e.g. regarding versioning)

> 
> 
>>> So, while Thomas is free to "fix on apply" at his own desire, i don't
>>> think we have to make this a habit.
> 
> Yes, it should be more or less an exception.
> 
> Bottom line, it is important to be transparent and predictable,
> while keeping some flexibility.
> 
> 


-- 
Thanks,
Anatoly