From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 72F13A04FF; Wed, 4 May 2022 16:35:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1DFD040C35; Wed, 4 May 2022 16:35:10 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 0444A4069F for ; Wed, 4 May 2022 16:35:08 +0200 (CEST) Received: from [192.168.108.214] (unknown [188.170.87.12]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 4B42A82; Wed, 4 May 2022 17:35:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 4B42A82 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1651674908; bh=cSck1+/XSA2Xu2+sn8dqe1ijdsYqHYiDr6YDF5febNM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=pMU6uftPCnGgWjLkuVL+gWPzqyGKHm9JCD1Q6BgaKqQZXqbiLfU9TCaBCSyQRJ/ZB rK2r1MhP9DgDfQ7N/Z/QR0/2pSVlGJ/zIRuaW9iW/CvI21hYSVDvhA3LWQdeXqbo3M F1puOcr4ajYILhTm5QhwD1ePgQPcSP0m4eDkAS8U= Message-ID: Date: Wed, 4 May 2022 17:35:07 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH 4/8] vmxnet3: add get hw version api Content-Language: en-US To: Pankaj Gupta , jbehrens@vmware.com, yongwang@vmware.com Cc: dev@dpdk.org References: <20220503042257.15626-1-pagupta@vmware.com> <20220503042257.15626-5-pagupta@vmware.com> From: Andrew Rybchenko In-Reply-To: <20220503042257.15626-5-pagupta@vmware.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org hw -> HW However, the API says that it is a firmware version get Consier: net/vmxnet3: report HW version on FW version get On 5/3/22 07:22, Pankaj Gupta wrote: > Implement fw_version_get API for vmxnet3 fw -> FW "for vmxnet3" is a duplicate, since summary already says so. > > Tested, using testpmd, for different hardware version on > ESXi 7.0 Update 2. > > Signed-off-by: Pankaj Gupta > --- > drivers/net/vmxnet3/vmxnet3_ethdev.c | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c > index a76796716b..f77399f145 100644 > --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c > +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c > @@ -103,6 +103,10 @@ static int > vmxnet3_rss_reta_query(struct rte_eth_dev *dev, > struct rte_eth_rss_reta_entry64 *reta_conf, > uint16_t reta_size); > +static int > +vmxnet3_hw_ver_get(struct rte_eth_dev *dev, > + char *fw_version, size_t fw_size); > + > static int vmxnet3_dev_rx_queue_intr_enable(struct rte_eth_dev *dev, > uint16_t queue_id); > static int vmxnet3_dev_rx_queue_intr_disable(struct rte_eth_dev *dev, > @@ -147,6 +151,7 @@ static const struct eth_dev_ops vmxnet3_eth_dev_ops = { > .rx_queue_intr_disable = vmxnet3_dev_rx_queue_intr_disable, > .reta_update = vmxnet3_rss_reta_update, > .reta_query = vmxnet3_rss_reta_query, > + .fw_version_get = vmxnet3_hw_ver_get, In general, addition order does not matter and it is recommended to follow order in eth_dev_ops here (and where functions are declared, and where functions are defined). > }; > > struct vmxnet3_xstats_name_off { > @@ -1764,3 +1769,19 @@ vmxnet3_rss_reta_query(struct rte_eth_dev *dev, > > return 0; > } > + > +static int > +vmxnet3_hw_ver_get(struct rte_eth_dev *dev, > + char *fw_version, size_t fw_size) > +{ > + int ret; > + struct vmxnet3_hw *hw = dev->data->dev_private; > + > + ret = snprintf(fw_version, fw_size, "v%d", hw->version); > + > + ret += 1; /* add the size of '\0' */ > + if (fw_size < (uint32_t)ret) > + return ret; > + else > + return 0; > +}