From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5FD6FA0C47; Tue, 26 Oct 2021 13:46:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1B50440E0F; Tue, 26 Oct 2021 13:46:40 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id E58BA4069C for ; Tue, 26 Oct 2021 13:46:37 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10148"; a="316089006" X-IronPort-AV: E=Sophos;i="5.87,182,1631602800"; d="scan'208";a="316089006" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2021 04:46:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,182,1631602800"; d="scan'208";a="494178176" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga007.fm.intel.com with ESMTP; 26 Oct 2021 04:46:36 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 26 Oct 2021 04:46:35 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 26 Oct 2021 04:46:35 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 26 Oct 2021 04:46:35 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.47) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 26 Oct 2021 04:46:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FoWTiuvwTtGOc6x8s7uk5JX6VGNpRE7GBZlDBsap+Wc+Npy6IZNiG2oC0YtQCd1OmraTydOvdPQcsi6WgUORj772hGNOMOoAlcv92JLfU7rh9B49FNeitBb692BTpiQwGnJ03cMxZHM3GSqMOrzLM1h9ynGmPwk64VKKZ3CoVBD8m6jNkI2tF3F2N4aE9KH5YmXOeyyaLbozdo1hiQiy8FMrF7JJMEFwxYyxYlXfvQW09CIuyTtHHJ1+EUq7vlLDgjUPeBZZeIme8YNJ3VGUUF0yCnpdttOBGMiIs3FIGzHwGiQjich1zG+JlZYsW5DrGcteYiZOzfwUqbgE65/lWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XDAisgq4pRzrm072ymq6MQo0gVcH7OHg25oLMLYyA6o=; b=YtragIsG+H8E/8tEXjKcZiiBisBqHFeUQpAQ725OXR+o+yZgBBo/13fW5Mz8aO77hca8CP5AGnHeSsH/oOGLUtKqO1/1/oeTEuY8/qOCy+5FCx5CX1L2BqSPnMv8cTs3+PhnfXukcuXGHRE+Gz8QXgVErau7Q10H+BbKA73ji4MrrhcTpxmjFyduDt6efnCYlIwfIUgN/o+5+Og9n23xk9jj3c3OnlQKHqW3cYkLY4FQhUt44pyyGBj83JqbS7qbsfT9isxCmHVo5CI9rqSlcLQBLOg9L44hQicQW66dL6G2Z2rm2XkDB+TmkQLo7XfHT27F/IXm7HXLETaMT5OWNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XDAisgq4pRzrm072ymq6MQo0gVcH7OHg25oLMLYyA6o=; b=TLGJDfMIHIb7IGYMVZVLZTOVoOO4fZe3m2rFkO/tpSh8dZ+3M3s+mMCwYavnc68ek3db2hLLr0RPdooIcdp3SoZBcq3Hh0GCRD5SPhXFNvMWe1nsw/QegR5wFZsjyd9LoQ+zkaYmSSzlFM5we2AVoREv8dQzZz9Vgi3tzvBKi4E= Authentication-Results: broadcom.com; dkim=none (message not signed) header.d=none;broadcom.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4871.namprd11.prod.outlook.com (2603:10b6:510:30::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.13; Tue, 26 Oct 2021 11:46:28 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%6]) with mapi id 15.20.4628.020; Tue, 26 Oct 2021 11:46:28 +0000 Message-ID: Date: Tue, 26 Oct 2021 12:46:13 +0100 Content-Language: en-US To: Ajit Khaparde , Somnath Kotur , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , Haiyue Wang , John Daley , Hyong Youb Kim , Gaetan Rivet , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , "Min Hu (Connor)" , Yisen Zhuang , Lijun Ou , Beilei Xing , Jingjing Wu , Beilei Xing , Qiming Yang , Qi Zhang , Rosen Xu , Liron Himi , Jerin Jacob , Nithin Dabilpuram , "Kiran Kumar K" , Rasesh Mody , Devendra Singh Rawat , Andrew Rybchenko , Jasvinder Singh , Cristian Dumitrescu , Keith Wiles , Jiawen Wu , Jian Wang CC: Ori Kam , Dmitry Kozlyuk , References: <20211019123722.3414694-1-dkozlyuk@nvidia.com> <20211021063503.3632732-1-dkozlyuk@nvidia.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211021063503.3632732-1-dkozlyuk@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB9PR02CA0026.eurprd02.prod.outlook.com (2603:10a6:10:1d9::31) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB9PR02CA0026.eurprd02.prod.outlook.com (2603:10a6:10:1d9::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14 via Frontend Transport; Tue, 26 Oct 2021 11:46:18 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a5e155b1-ff27-4923-f56d-08d998763ebc X-MS-TrafficTypeDiagnostic: PH0PR11MB4871: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4wzznKQkTFQ4tpg4HwsG5+zRMkkMW5sMIdHykX02uZ5qpb9UpPzRCSh4sU+x1BTgSmw4Lgr5pcLihr2EbQt4GKo31SvZAw2CY3IGk7ZYoPy4OneanD6WRgulB1xVdEFBCa/Xo2CAFPKRoK/JL2Bqv8iBdLvV8aUgO/R9ggF/ALqkQiOa/L73mLXl2QOQq3oMx0ldzdiqwpJEdlYfXRCHzkQz2dB6OiWAJVxVKQvLOR7LW1ixPCBDUMNetYpf5sG8axq5xEUiHObqwxP6hKfG3qbhKi6xlx6dEj2Oh8978NiQqwfcl/JSua+MWc279JFwI2R9wzdmrgxEX4oEs8vdVNAGe3EIr2A33xu9/fcrGh/iTHlWVakmaWy0puQGjd9lnJnDqXFWnKY44bo9PWT+5LC9rG6/oLsusOmf2XTac0fI1LF0B3gIWXAKXRLfkZxTqNLwJuR43btBtWOyULSwVC2EQo8GB4qWsxpGxVvQcFtzwMPudv4rFPxnNnCPPTAtT9bHUl2sGFL6M+F+NWOQLIK2yuqkS2jjuzfTB72/M9Ti9Tix6nLQKVZjol/wX5xjTTH8uJG+WH+LDoLdQuTmh8uzbcJ+NCEteDDe4MnWsKnW551iSSpsOqoNGay5LvwCHTw89bLsQ5QwCcwN/ux6v0UN3VbQgpqov3PtixNx+uawi+cBZbewwgr9ej5WNSo7cIkunqud2iaabHgF8nrq1Mh0HjdaZVaViaNGGsV53WQYWhu7P9zo2hLPrcVxKa+t6ERz60hhYjXbomrwjjtOuL5xfO1T7CPdLM2gk659XcDu+gvO2tj6Aw4zL3y2IljbtxSiC5QW7uHggDeEdAg0UsapLLLCgnoykW/OuLYSiGk= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(36756003)(6666004)(2906002)(956004)(83380400001)(26005)(53546011)(2616005)(7416002)(44832011)(86362001)(31696002)(316002)(31686004)(186003)(66946007)(16576012)(66556008)(66476007)(82960400001)(38100700002)(4326008)(8936002)(6486002)(8676002)(921005)(966005)(5660300002)(508600001)(54906003)(110136005)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b0FETlVVOU4yWVpVT1hUaVhnU05CczlMeDV0UjNKNFhwajlpaU4vcnZmVGsy?= =?utf-8?B?clZuSVhtR0ZBSEhJTE9XakVRTlNBaXM2QTRiQWcvL3M2V1pzdUZsT1FmRnJp?= =?utf-8?B?bGlLK1lxUzBzTjRHZkpTMm0yaDVGS0JHWkIxaFFMK1VZMHNCOENlSC9IaFZa?= =?utf-8?B?YlI0Rjl6NHhIeFJRYkN2d09XMm1HR0k0MXVPU1d3ZitIMDlZYTdVZm43aGJr?= =?utf-8?B?U3J1c1pWUS9NTzFDVUFVdVgyaTIyMmdnS1NwNXVBeTBKMWlsS2syVFpRSkt0?= =?utf-8?B?UlVpNkFYd2p1dXZmNVJhWTlSdnRLb1pJMnh5UWZPTmhnVnpReTZKbGU5UnZj?= =?utf-8?B?RHowMWFDVWFjUEtYZ1VWQU1DM01iSElBRkdNdGVYL1lZbDl1Q0dqZ1FiTlBC?= =?utf-8?B?YzdTRnd5dGtWTmJxYUxMby9WcWFWcDk3K2lIMlFkdXlab0k1bDhJakVWQnlz?= =?utf-8?B?K1lSUE5MMjFpSzVoczV5dTVLL2N2TVU3Q3UwakdSZVRRNWdKNTMrbUxBNDFU?= =?utf-8?B?Q3Q1WjBGakZpNkh2dldaVDBsYXQ5cU5scnhsTUgxMVlsck9pVndXOHpEV1Y1?= =?utf-8?B?b2dwTEtVdEFoaTRUUDBGT0VSdEFINHJrUkoxL1Y1RXRWQjk2bFB6djV6V1dh?= =?utf-8?B?Nkdjd2E4VGJNdkp3cTRHbmltczlJRzVnbTI3VElaTnBoQnVSU2JKQXlpVXFs?= =?utf-8?B?Y3plS2NKckFZcDQ5c2pPRHpxREJNTW5jYlE2WWxEbUxPZDlkM2dleHlid1Fk?= =?utf-8?B?S0ZFZk9xZjYvQ2FsSUF4OExjNUV5QVVBcmVQV1R6d1hTUzhyM2s5RExGRkhM?= =?utf-8?B?d2FWSXJTN0xFSWpnZmVGb085VTEvTXlDOHFTWmZJR3UzdHBsUktOQTYzeUpS?= =?utf-8?B?cUZrMzRaazN0ekRNSEhxMTlWZml5aFh5Si9RZ2g1dUlZb004engvVmkzaitJ?= =?utf-8?B?cnZlYTFnUkdaTnhhOWp0WHg2b29lOUZyVmdoNjg5V1RBeGhKdUl0UXdnL3I1?= =?utf-8?B?WGlKcUNZNE1lSDRXYVQzODA3MEYraEhtUDdKL05ZeEtnejNvbHB2dSsrUldW?= =?utf-8?B?YWtKOGtDSkxkNDB0UjM5eDQ0SUUyRmR0c1kwaHVKZHNtWHl4eHhUazR0dXFT?= =?utf-8?B?OGozOVNTVGhrckZYZEpVWU1IQ2FzUFBmUENVTEdwWkNna0o0WG11d3gyQ0Ew?= =?utf-8?B?VEUvWUpmTzErNm1QeHVBeGRCWTVLdGdMQkRLUG1lTzBRVmlRVzc1dkVacHpp?= =?utf-8?B?Z0UxNXV6cHBJSUg3Q2xjR0crbXRKMUo0WmlpN1RzMFNldy84eFM3dVlJOStY?= =?utf-8?B?amh3dDJuWDJZanpqOHpxRWphc0xFMHNJZ2F0SlluMkltdjdFN3llTnhOTHVu?= =?utf-8?B?Q2ZUSDlKeHJLK2tVUVI1TENkbXNZY1V2eW5JWFVkdGJIVFVURlFadVpHbVFF?= =?utf-8?B?OVNyM0E1aGxmU0NDa0xCTllkeENQeGoyVEVveGNDeStJNkQ1UGNzTGpSeHZS?= =?utf-8?B?cHh5YXQveTZqaUxIaVE0TzhLMzh1M1pPdWpvTngyTW9yeVY5TUU5d1pqNzJX?= =?utf-8?B?NWlZSGU3KzhITzZScEQwZ2tMUUZ4WFMxODJoVFI1WXBFQ3hoMUs0RXVvcUVa?= =?utf-8?B?WU55R0lXV0VLOWQ2dzhrL2trQ25BSU5FQXpOOEJVbmRianBuS1lJNEdOTUti?= =?utf-8?B?cXpyODFab0JnN1NuS0ZQMHZrYnJCUnNTV0dpN3hYWWJVc3B6TFo0NW5JaVpo?= =?utf-8?B?MVFOWmNUTm5TN202SVRmMnhIZ0VBRWtseGVsdXdWdzZlTzN2OU5PR3JBTTZH?= =?utf-8?B?cVBXTXdXd0RJbzFsK1BwaHpxV2xtSzlsMzI3U25YRFdQTWN4d2V6Smordy9H?= =?utf-8?B?SHVtak1seDlyQWk3YWo4MkF6SGZpZUxja0M1dFVJNEE2eGJHUTlkUDZadzF1?= =?utf-8?B?eUc0NW9NZC9vOU94SVZEVnBnL3JjRVZRb0tOeElSVnBOTk5oUE1vZkI1cVVX?= =?utf-8?B?WFNsVHFXU1I5MUNpb0R0Vlgzdzl2dEtvOG9CYkM5dGJoQWFMWGIwcjRXSEJY?= =?utf-8?B?RW05cGdCamhKa2lrZHZRK0dwbExyQkVBZThCbEgraDBYVmtNR2VxYXpUTysx?= =?utf-8?B?TGJMcjVhWkRFQVRmY0lvWWlXMFJsUzVaRjJLKzVJK0UvTm13aHdZWVJORGRk?= =?utf-8?Q?CLY2Y9eEQLG6ulVa59Kh10g=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: a5e155b1-ff27-4923-f56d-08d998763ebc X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2021 11:46:28.0678 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +8i0korQqJuWOKPNxKN0Bju1Xb8lmIf3rv8FKpDIbu9VGSMiwkgw1bRGdrogs/vtjIbw7z0oCq9VSe+ZHzRHVQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4871 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4 0/6] Flow entites behavior on port restart X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/21/2021 7:34 AM, Dmitry Kozlyuk wrote: > It is unspecified whether flow rules and indirect actions are kept > when a port is stopped, possibly reconfigured, and started again. > Vendors approach the topic differently, e.g. mlx5 and i40e PMD > disagree in whether flow rules can be kept, and mlx5 PMD would keep > indirect actions. In the end, applications are greatly affected > by whatever contract there is and need to know it. > > Applications may wish to restart the port to reconfigure it, > e.g. switch offloads or even modify queues. > Keeping rte_flow entities enables application improvements: > 1. Since keeping the rules across restart comes with the ability > to create rules before the device is started. This allows > to have all the rules created at the moment of start, > so that there is no time frame when traffic is coming already, > but the rules are not yet created (restored). > 2. When a rule or an indirect action has some associated state, > such as a counter, application saves the need to keep > additional state in order to cope with information loss > if such an entity would be destroyed. > > It is proposed to advertise capabilities of keeping flow rules > and indirect actions (as a special case of shared object) > using a combination of ethdev info and rte_flow calls. > Then a bug is fixed in mlx5 PMD that prevented indirect RSS action > from being kept, and the driver starts advertising the new capability. > > Prior discussions: > 1) http://inbox.dpdk.org/dev/20210727073121.895620-1-dkozlyuk@nvidia.com/ > 2) http://inbox.dpdk.org/dev/20210901085516.3647814-1-dkozlyuk@nvidia.com/ > > v4: 1. Fix rebase conflicts (CI). > 2. State rule behavior when a port is not started or stopped (Ori). > 3. Improve wording on rule features, add examples (Andrew). > 4. State that rules/actions that cannot be kept while other can be > must be destroyed by the application (Andrew/Ori). > 5. Add rationale to the cover letter (Andrew). > > Dmitry Kozlyuk (6): > ethdev: add capability to keep flow rules on restart > ethdev: add capability to keep shared objects on restart > net: advertise no support for keeping flow rules > net/mlx5: discover max flow priority using DevX > net/mlx5: create drop queue using DevX > net/mlx5: preserve indirect actions on restart > Requesting review from PMD maintainers. Since this patch tries to define behavior on keeping/flushing flow rules after port stop/start/configure, better to get more feedback from various vendors, please review/comment on patch so that we can get it for -rc2. If there is no comment the patch can go in as it is for -rc2. Thanks, ferruh