From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id CB6C9FA30 for ; Fri, 2 Dec 2016 12:23:13 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP; 02 Dec 2016 03:23:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,729,1477983600"; d="scan'208";a="907949511" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.29]) ([10.237.220.29]) by orsmga003.jf.intel.com with ESMTP; 02 Dec 2016 03:23:11 -0800 To: Wenzhuo Lu , dev@dpdk.org References: <1480637533-37425-1-git-send-email-wenzhuo.lu@intel.com> <1480637533-37425-32-git-send-email-wenzhuo.lu@intel.com> Cc: "Chen Jing D(Mark)" From: Ferruh Yigit Message-ID: Date: Fri, 2 Dec 2016 11:23:11 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 MIME-Version: 1.0 In-Reply-To: <1480637533-37425-32-git-send-email-wenzhuo.lu@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 31/31] i40e: enhance in sanity check of mac X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Dec 2016 11:23:14 -0000 On 12/2/2016 12:12 AM, Wenzhuo Lu wrote: > When VF sends request to add a new mac address, PF host > will check if it's a non-zero or uncast address, or it > will return with error. In fact, VF still can set multicast > address. This change remove to check if it's a unicast > address. > > Signed-off-by: Chen Jing D(Mark) > --- commit subject tag should be: "net/i40e:", and MAC is uppercase. > drivers/net/i40e/i40e_pf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c > index 4b0da75..c9cca1e 100644 > --- a/drivers/net/i40e/i40e_pf.c > +++ b/drivers/net/i40e/i40e_pf.c > @@ -890,7 +890,7 @@ > mac = (struct ether_addr *)(addr_list->list[i].addr); > (void)rte_memcpy(&filter.mac_addr, mac, ETHER_ADDR_LEN); > filter.filter_type = RTE_MACVLAN_PERFECT_MATCH; > - if(!is_valid_assigned_ether_addr(mac) || > + if(is_zero_ether_addr(mac) || checkpatch warning: ERROR:SPACING: space required before the open parenthesis '(' > i40e_vsi_add_mac(vf->vsi, &filter)) { > ret = I40E_ERR_INVALID_MAC_ADDR; > goto send_msg; >